All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Jianfeng Tan <jianfeng.tan@linux.alibaba.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, mst@redhat.com
Subject: Re: [PATCH] net/packet: fix packet drop as of virtio gso
Date: Mon, 29 Oct 2018 10:40:18 +0800	[thread overview]
Message-ID: <7e894134-0178-e9e0-c584-8c607a270901@redhat.com> (raw)
In-Reply-To: <a74d414f-bee1-9754-8735-81cb07dc430b@linux.alibaba.com>


On 2018/10/28 上午7:42, Jianfeng Tan wrote:
>
> On 10/8/2018 11:14 AM, Jason Wang wrote:
>>
>>
>> On 2018年09月29日 23:41, Jianfeng Tan wrote:
>>> When we use raw socket as the vhost backend, a packet from virito with
>>> gso offloading information, cannot be sent out in later validaton at
>>> xmit path, as we did not set correct skb->protocol which is further 
>>> used
>>> for looking up the gso function.
>>
>> Hi:
>>
>> May I ask the reason for using raw socket for vhost? It was not a 
>> common setup with little care in the past few years. And it was slow 
>> since it lacks some recent improvements. Can it be replaced with e.g 
>> macvtap?
>
> Hi Jason,
>
> Apologize for late response. We are in container environment, in which 
> case veth is used mostly. Either tap or macvtap cannot be put into an 
> isolated netns. 


I think it can? See 17af2bce88d31e65ed73d638bb752d2e13c66ced.


> Another thing could be macvlan as the backend of vhost, which is not 
> supported either. So unfortunately, improving raw socket is the only 
> choice I suppose.


Btw, you can setup macvtap on top of veth. Does this help?

Thanks


>
> Thanks,
> Jianfeng

  reply	other threads:[~2018-10-29 11:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29 15:41 [PATCH] net/packet: fix packet drop as of virtio gso Jianfeng Tan
2018-10-05  5:23 ` David Miller
2018-10-08  3:14 ` Jason Wang
2018-10-27 23:42   ` Jianfeng Tan
2018-10-29  2:40     ` Jason Wang [this message]
2018-10-29  3:51       ` Jianfeng Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e894134-0178-e9e0-c584-8c607a270901@redhat.com \
    --to=jasowang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jianfeng.tan@linux.alibaba.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.