From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"thomas.hellstrom@linux.intel.com"
<thomas.hellstrom@linux.intel.com>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable
Date: Fri, 28 Jan 2022 13:50:42 +0000 [thread overview]
Message-ID: <7eaebcb777af22defc813cfe5071230123e56400.camel@intel.com> (raw)
In-Reply-To: <20220128063644.GH1978@kadam>
On Fri, 2022-01-28 at 09:36 +0300, Dan Carpenter wrote:
> On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote:
> > On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote:
> > > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote:
> > > > This "ret" declaration shadows an existing "ret" variable at
> > > > the
> > > > top of
> > > > the function. Delete it.
> > > >
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > >
> > > and pushing right now
> >
> > Should probably have had a Fixes: tag on this one. I'm not 100%
Well, I had added while pushing yesterday... but...
> > sure
> > whether the faulty patch is already upstream. In that case we might
> > need to manually include it in a -fixes pull.
> >
>
> It's not really a bug. It's just a Sparse warning which is disabled
> by default (-Wshadow). The patch is in linux-next.
Yeap, but it is good to add Fixes so if anyone is backporting the other
patch it is clear that this patch is a good addition on top.
>
> Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async
> unbinding")
hmm... you are right... this one was the one...
I had added
Fixes: f6c466b84cfa ("drm/i915: Add support for moving fence waiting")
pointing to the original patch that introduced this int ret
instead of the one that created the duplication...
so my Fixes addition can actually break some backport out there...
But luckily I believe that these 2 patches will be backported together
anyway...
Sorry about the confusion,
Rodrigo.
>
> regards,
> dan carpenter
>
WARNING: multiple messages have this Message-ID (diff)
From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"thomas.hellstrom@linux.intel.com"
<thomas.hellstrom@linux.intel.com>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable
Date: Fri, 28 Jan 2022 13:50:42 +0000 [thread overview]
Message-ID: <7eaebcb777af22defc813cfe5071230123e56400.camel@intel.com> (raw)
In-Reply-To: <20220128063644.GH1978@kadam>
On Fri, 2022-01-28 at 09:36 +0300, Dan Carpenter wrote:
> On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote:
> > On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote:
> > > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote:
> > > > This "ret" declaration shadows an existing "ret" variable at
> > > > the
> > > > top of
> > > > the function. Delete it.
> > > >
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > >
> > > and pushing right now
> >
> > Should probably have had a Fixes: tag on this one. I'm not 100%
Well, I had added while pushing yesterday... but...
> > sure
> > whether the faulty patch is already upstream. In that case we might
> > need to manually include it in a -fixes pull.
> >
>
> It's not really a bug. It's just a Sparse warning which is disabled
> by default (-Wshadow). The patch is in linux-next.
Yeap, but it is good to add Fixes so if anyone is backporting the other
patch it is clear that this patch is a good addition on top.
>
> Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async
> unbinding")
hmm... you are right... this one was the one...
I had added
Fixes: f6c466b84cfa ("drm/i915: Add support for moving fence waiting")
pointing to the original patch that introduced this int ret
instead of the one that created the duplication...
so my Fixes addition can actually break some backport out there...
But luckily I believe that these 2 patches will be backported together
anyway...
Sorry about the confusion,
Rodrigo.
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2022-01-28 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 8:51 [PATCH] drm/i915: delete shadow "ret" variable Dan Carpenter
2022-01-27 8:51 ` [Intel-gfx] " Dan Carpenter
2022-01-27 11:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-01-27 14:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-01-27 22:26 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2022-01-27 22:26 ` Rodrigo Vivi
2022-01-28 6:20 ` Thomas Hellström
2022-01-28 6:20 ` Thomas Hellström
2022-01-28 6:36 ` Dan Carpenter
2022-01-28 6:36 ` Dan Carpenter
2022-01-28 13:50 ` Vivi, Rodrigo [this message]
2022-01-28 13:50 ` Vivi, Rodrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eaebcb777af22defc813cfe5071230123e56400.camel@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.