* [PATCH] samples/bpf: Fix compilation failure for samples/bpf on Loongarch Fedora
@ 2023-07-10 1:51 Haoran Jiang
2023-07-10 4:40 ` Huacai Chen
0 siblings, 1 reply; 7+ messages in thread
From: Haoran Jiang @ 2023-07-10 1:51 UTC (permalink / raw)
To: linux-kernel
Cc: loongarch, llvm, bpf, chenhuacai, trix, ndesaulniers, nathan,
jolsa, haoluo, sdf, kpsingh, john.fastabend, yhs, song,
martin.lau, andrii, daniel, ast, kernel, yangtiezhu
When building the latest samples/bpf on Loongarch Fedora
make M=samples/bpf
There are compilation errors as follows:
In file included from ./linux/samples/bpf/sockex2_kern.c:2:
In file included from ./include/uapi/linux/in.h:25:
In file included from ./include/linux/socket.h:8:
In file included from ./include/linux/uio.h:9:
In file included from ./include/linux/thread_info.h:60:
In file included from ./arch/loongarch/include/asm/thread_info.h:15:
In file included from ./arch/loongarch/include/asm/processor.h:13:
In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
^~~~~~~~~~~~~~~
1 error generated.
larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
and the header file location is specified at compile time.
Test on Loongarch Fedora:
https://github.com/fedora-remix-loongarch/releases-info
Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
---
samples/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 615f24ebc49c..b301796a3862 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
@echo " CLANG-bpf " $@
$(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
-I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
- -I$(LIBBPF_INCLUDE) \
+ -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
-D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
-D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
-Wno-gnu-variable-sized-type-not-at-end \
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] samples/bpf: Fix compilation failure for samples/bpf on Loongarch Fedora
2023-07-10 1:51 [PATCH] samples/bpf: Fix compilation failure for samples/bpf on Loongarch Fedora Haoran Jiang
@ 2023-07-10 4:40 ` Huacai Chen
2023-07-10 5:27 ` [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora Haoran Jiang
0 siblings, 1 reply; 7+ messages in thread
From: Huacai Chen @ 2023-07-10 4:40 UTC (permalink / raw)
To: Haoran Jiang
Cc: linux-kernel, loongarch, llvm, bpf, trix, ndesaulniers, nathan,
jolsa, haoluo, sdf, kpsingh, john.fastabend, yhs, song,
martin.lau, andrii, daniel, ast, kernel, yangtiezhu
Please use LoongArch instead of Loongarch in the title and commit message.
Huacai
On Mon, Jul 10, 2023 at 10:08 AM Haoran Jiang <jianghaoran@kylinos.cn> wrote:
>
> When building the latest samples/bpf on Loongarch Fedora
>
> make M=samples/bpf
>
> There are compilation errors as follows:
>
> In file included from ./linux/samples/bpf/sockex2_kern.c:2:
> In file included from ./include/uapi/linux/in.h:25:
> In file included from ./include/linux/socket.h:8:
> In file included from ./include/linux/uio.h:9:
> In file included from ./include/linux/thread_info.h:60:
> In file included from ./arch/loongarch/include/asm/thread_info.h:15:
> In file included from ./arch/loongarch/include/asm/processor.h:13:
> In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
> ./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
> ^~~~~~~~~~~~~~~
> 1 error generated.
>
> larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
> and the header file location is specified at compile time.
>
> Test on Loongarch Fedora:
> https://github.com/fedora-remix-loongarch/releases-info
>
> Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
> ---
> samples/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 615f24ebc49c..b301796a3862 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
> @echo " CLANG-bpf " $@
> $(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
> -I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
> - -I$(LIBBPF_INCLUDE) \
> + -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
> -D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
> -D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
> -Wno-gnu-variable-sized-type-not-at-end \
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora
2023-07-10 4:40 ` Huacai Chen
@ 2023-07-10 5:27 ` Haoran Jiang
2023-07-10 5:54 ` Huacai Chen
0 siblings, 1 reply; 7+ messages in thread
From: Haoran Jiang @ 2023-07-10 5:27 UTC (permalink / raw)
To: chenhuacai
Cc: andrii, ast, bpf, daniel, haoluo, jianghaoran, john.fastabend,
jolsa, kernel, kpsingh, linux-kernel, llvm, loongarch,
martin.lau, nathan, ndesaulniers, sdf, song, trix, yangtiezhu,
yhs
When building the latest samples/bpf on LoongArch Fedora
make M=samples/bpf
There are compilation errors as follows:
In file included from ./linux/samples/bpf/sockex2_kern.c:2:
In file included from ./include/uapi/linux/in.h:25:
In file included from ./include/linux/socket.h:8:
In file included from ./include/linux/uio.h:9:
In file included from ./include/linux/thread_info.h:60:
In file included from ./arch/loongarch/include/asm/thread_info.h:15:
In file included from ./arch/loongarch/include/asm/processor.h:13:
In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
^~~~~~~~~~~~~~~
1 error generated.
larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
and the header file location is specified at compile time.
Test on LoongArch Fedora:
https://github.com/fedora-remix-loongarch/releases-info
Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
---
v2:
use LoongArch instead of Loongarch in the title and commit message.
---
samples/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 615f24ebc49c..b301796a3862 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
@echo " CLANG-bpf " $@
$(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
-I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
- -I$(LIBBPF_INCLUDE) \
+ -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
-D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
-D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
-Wno-gnu-variable-sized-type-not-at-end \
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora
2023-07-10 5:27 ` [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora Haoran Jiang
@ 2023-07-10 5:54 ` Huacai Chen
2023-07-11 7:39 ` Daniel Borkmann
0 siblings, 1 reply; 7+ messages in thread
From: Huacai Chen @ 2023-07-10 5:54 UTC (permalink / raw)
To: Haoran Jiang
Cc: andrii, ast, bpf, daniel, haoluo, john.fastabend, jolsa, kernel,
kpsingh, linux-kernel, llvm, loongarch, martin.lau, nathan,
ndesaulniers, sdf, song, trix, yangtiezhu, yhs
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
On Mon, Jul 10, 2023 at 1:34 PM Haoran Jiang <jianghaoran@kylinos.cn> wrote:
>
> When building the latest samples/bpf on LoongArch Fedora
>
> make M=samples/bpf
>
> There are compilation errors as follows:
>
> In file included from ./linux/samples/bpf/sockex2_kern.c:2:
> In file included from ./include/uapi/linux/in.h:25:
> In file included from ./include/linux/socket.h:8:
> In file included from ./include/linux/uio.h:9:
> In file included from ./include/linux/thread_info.h:60:
> In file included from ./arch/loongarch/include/asm/thread_info.h:15:
> In file included from ./arch/loongarch/include/asm/processor.h:13:
> In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
> ./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
> ^~~~~~~~~~~~~~~
> 1 error generated.
>
> larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
> and the header file location is specified at compile time.
>
> Test on LoongArch Fedora:
> https://github.com/fedora-remix-loongarch/releases-info
>
> Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
>
> ---
> v2:
> use LoongArch instead of Loongarch in the title and commit message.
> ---
> samples/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 615f24ebc49c..b301796a3862 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
> @echo " CLANG-bpf " $@
> $(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
> -I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
> - -I$(LIBBPF_INCLUDE) \
> + -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
> -D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
> -D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
> -Wno-gnu-variable-sized-type-not-at-end \
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora
2023-07-10 5:54 ` Huacai Chen
@ 2023-07-11 7:39 ` Daniel Borkmann
2023-07-11 10:39 ` 回复:[PATCH " jianghaoran
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Borkmann @ 2023-07-11 7:39 UTC (permalink / raw)
To: Huacai Chen, Haoran Jiang
Cc: andrii, ast, bpf, haoluo, john.fastabend, jolsa, kernel, kpsingh,
linux-kernel, llvm, loongarch, martin.lau, nathan, ndesaulniers,
sdf, song, trix, yangtiezhu, yhs
On 7/10/23 7:54 AM, Huacai Chen wrote:
> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
>
> On Mon, Jul 10, 2023 at 1:34 PM Haoran Jiang <jianghaoran@kylinos.cn> wrote:
>>
>> When building the latest samples/bpf on LoongArch Fedora
>>
>> make M=samples/bpf
>>
>> There are compilation errors as follows:
>>
>> In file included from ./linux/samples/bpf/sockex2_kern.c:2:
>> In file included from ./include/uapi/linux/in.h:25:
>> In file included from ./include/linux/socket.h:8:
>> In file included from ./include/linux/uio.h:9:
>> In file included from ./include/linux/thread_info.h:60:
>> In file included from ./arch/loongarch/include/asm/thread_info.h:15:
>> In file included from ./arch/loongarch/include/asm/processor.h:13:
>> In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
>> ./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
>> ^~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
>> and the header file location is specified at compile time.
>>
>> Test on LoongArch Fedora:
>> https://github.com/fedora-remix-loongarch/releases-info
>>
>> Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
>>
>> ---
>> v2:
>> use LoongArch instead of Loongarch in the title and commit message.
>> ---
>> samples/bpf/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
>> index 615f24ebc49c..b301796a3862 100644
>> --- a/samples/bpf/Makefile
>> +++ b/samples/bpf/Makefile
>> @@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
>> @echo " CLANG-bpf " $@
>> $(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
>> -I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
>> - -I$(LIBBPF_INCLUDE) \
>> + -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
There's still one location in XDP_SAMPLE_CFLAGS, do we need the $(CLANG_SYS_INCLUDES)
there as well?
>> -D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
>> -D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
>> -Wno-gnu-variable-sized-type-not-at-end \
>> --
>> 2.27.0
>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复:[PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora
2023-07-11 7:39 ` Daniel Borkmann
@ 2023-07-11 10:39 ` jianghaoran
0 siblings, 0 replies; 7+ messages in thread
From: jianghaoran @ 2023-07-11 10:39 UTC (permalink / raw)
To: Daniel Borkmann, Huacai Chen
Cc: andrii, ast, bpf, haoluo, john.fastabend, jolsa, kernel, kpsingh,
linux-kernel, llvm, loongarch, martin.lau, nathan, ndesaulniers,
sdf, song, trix, yangtiezhu, yhs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="euc-tw", Size: 2929 bytes --]
Çã 2023-07-11ÑÓßæĨÎû 09:39 +0200¡¢Daniel Borkmann£¡ú笡¨
> On 7/10/23 7:54 AM, Huacai Chen wrote:
> > Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
> >
> > On Mon, Jul 10, 2023 at 1:34PM Haoran Jiang <
> > jianghaoran@kylinos.cn> wrote:
> > > When building the latest samples/bpf on LoongArch Fedora
> > >
> > > make M=samples/bpf
> > >
> > > There are compilation errors as follows:
> > >
> > > In file included from ./linux/samples/bpf/sockex2_kern.c:2:
> > > In file included from ./include/uapi/linux/in.h:25:
> > > In file included from ./include/linux/socket.h:8:
> > > In file included from ./include/linux/uio.h:9:
> > > In file included from ./include/linux/thread_info.h:60:
> > > In file included from
> > > ./arch/loongarch/include/asm/thread_info.h:15:
> > > In file included from
> > > ./arch/loongarch/include/asm/processor.h:13:
> > > In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
> > > ./arch/loongarch/include/asm/loongarch.h:13:10: fatal error:
> > > 'larchintrin.h' file not found
> > > ^~~~~~~~~~~~~~~
> > > 1 error generated.
> > >
> > > larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
> > > and the header file location is specified at compile time.
> > >
> > > Test on LoongArch Fedora:
> > > https://github.com/fedora-remix-loongarch/releases-info
> > >
> > > Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
> > >
> > > ---
> > > v2:
> > > use LoongArch instead of Loongarch in the title and commit
> > > message.
> > > ---
> > > samples/bpf/Makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> > > index 615f24ebc49c..b301796a3862 100644
> > > --- a/samples/bpf/Makefile
> > > +++ b/samples/bpf/Makefile
> > > @@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
> > > @echo " CLANG-bpf " $@
> > > $(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE)
> > > $(BPF_EXTRA_CFLAGS) \
> > > -I$(obj)
> > > -I$(srctree)/tools/testing/selftests/bpf/ \
> > > - -I$(LIBBPF_INCLUDE) \
> > > + -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
>
> There's still one location in XDP_SAMPLE_CFLAGS, do we need the
> $(CLANG_SYS_INCLUDES)
> there as well?
XDP_SAMPLE_CFLAGS only affects the compilation of xdp_sample_user.c. It
is a user-mode application¡¢the associated header files of clang are not
used. larchintrin.h will only be included in *.bpf.c and *kern.c
files.So I don't think $(CLANG_SYS_INCLUDES) needs to be included here.
>
> > > -D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value
> > > -Wno-pointer-sign \
> > > -D__TARGET_ARCH_$(SRCARCH) -Wno-compare-
> > > distinct-pointer-types \
> > > -Wno-gnu-variable-sized-type-not-at-end \
> > > --
> > > 2.27.0
> > >
> > >
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora
@ 2023-07-10 5:25 Haoran Jiang
0 siblings, 0 replies; 7+ messages in thread
From: Haoran Jiang @ 2023-07-10 5:25 UTC (permalink / raw)
To: linux-kernel
Cc: loongarch, llvm, bpf, chenhuacai, trix, ndesaulniers, nathan,
jolsa, haoluo, sdf, kpsingh, john.fastabend, yhs, song,
martin.lau, andrii, daniel, ast, kernel, yangtiezhu
When building the latest samples/bpf on LoongArch Fedora
make M=samples/bpf
There are compilation errors as follows:
In file included from ./linux/samples/bpf/sockex2_kern.c:2:
In file included from ./include/uapi/linux/in.h:25:
In file included from ./include/linux/socket.h:8:
In file included from ./include/linux/uio.h:9:
In file included from ./include/linux/thread_info.h:60:
In file included from ./arch/loongarch/include/asm/thread_info.h:15:
In file included from ./arch/loongarch/include/asm/processor.h:13:
In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
^~~~~~~~~~~~~~~
1 error generated.
larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
and the header file location is specified at compile time.
Test on LoongArch Fedora:
https://github.com/fedora-remix-loongarch/releases-info
Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
---
v2:
use LoongArch instead of Loongarch in the title and commit message.
---
samples/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 615f24ebc49c..b301796a3862 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
@echo " CLANG-bpf " $@
$(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
-I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
- -I$(LIBBPF_INCLUDE) \
+ -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
-D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
-D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
-Wno-gnu-variable-sized-type-not-at-end \
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-07-11 10:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-10 1:51 [PATCH] samples/bpf: Fix compilation failure for samples/bpf on Loongarch Fedora Haoran Jiang
2023-07-10 4:40 ` Huacai Chen
2023-07-10 5:27 ` [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf on LoongArch Fedora Haoran Jiang
2023-07-10 5:54 ` Huacai Chen
2023-07-11 7:39 ` Daniel Borkmann
2023-07-11 10:39 ` 回复:[PATCH " jianghaoran
2023-07-10 5:25 [PATCH " Haoran Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.