From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Anson Huang <anson.huang@nxp.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, "tglx@linutronix.de" <tglx@linutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, Daniel Baluta <daniel.baluta@nxp.com>, Jacky Bai <ping.bai@nxp.com>, "l.stach@pengutronix.de" <l.stach@pengutronix.de>, Abel Vesa <abel.vesa@nxp.com>, "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>, "ccaione@baylibre.com" <ccaione@baylibre.com>, "angus@akkea.ca" <angus@akkea.ca>, "agx@sigxcpu.org" <agx@sigxcpu.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH V5 1/5] clocksource: imx-sysctr: Add internal clock divider handle Date: Tue, 6 Aug 2019 12:27:51 +0200 [thread overview] Message-ID: <7edad4d7-5ba2-d710-eb8d-b3ff97051a41@linaro.org> (raw) In-Reply-To: <DB3PR0402MB3916B06E8907604A71169063F5D50@DB3PR0402MB3916.eurprd04.prod.outlook.com> On 06/08/2019 03:55, Anson Huang wrote: > Gentle ping... Coming back from vacation. It is in the pipe ... :) >> From: Anson Huang <Anson.Huang@nxp.com> >> >> The system counter block guide states that the base clock is internally divided >> by 3 before use, that means the clock input of system counter defined in DT >> should be base clock which is normally from OSC, and then internally divided >> by 3 before use. >> >> Signed-off-by: Anson Huang <Anson.Huang@nxp.com> >> --- >> Changes since V4: >> - to solve the clock driver probed after system counter driver issue, >> now we can easily switch to >> use fixed clock defined in DT and get its rate, then divided by 3 to >> get real clock rate for >> system counter driver, no need to add "clock-frequency" property in >> DT. >> --- >> drivers/clocksource/timer-imx-sysctr.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/clocksource/timer-imx-sysctr.c >> b/drivers/clocksource/timer-imx-sysctr.c >> index fd7d680..b7c80a3 100644 >> --- a/drivers/clocksource/timer-imx-sysctr.c >> +++ b/drivers/clocksource/timer-imx-sysctr.c >> @@ -20,6 +20,8 @@ >> #define SYS_CTR_EN 0x1 >> #define SYS_CTR_IRQ_MASK 0x2 >> >> +#define SYS_CTR_CLK_DIV 0x3 >> + >> static void __iomem *sys_ctr_base; >> static u32 cmpcr; >> >> @@ -134,6 +136,9 @@ static int __init sysctr_timer_init(struct device_node >> *np) >> if (ret) >> return ret; >> >> + /* system counter clock is divided by 3 internally */ >> + to_sysctr.of_clk.rate /= SYS_CTR_CLK_DIV; >> + >> sys_ctr_base = timer_of_base(&to_sysctr); >> cmpcr = readl(sys_ctr_base + CMPCR); >> cmpcr &= ~SYS_CTR_EN; >> -- >> 2.7.4 > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Anson Huang <anson.huang@nxp.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, "tglx@linutronix.de" <tglx@linutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, Daniel Baluta <daniel.baluta@nxp.com>, Jacky Bai <ping.bai@nxp.com>, "l.stach@pengutronix.de" <l.stach@pengutronix.de>, Abel Vesa <abel.vesa@nxp.com>, "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>, "ccaione@baylibre.com" <ccaione@baylibre.com>, "angus@akkea.ca" <angus@akkea.ca>, "agx@sigxcpu.org" <agx@sigxcpu.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH V5 1/5] clocksource: imx-sysctr: Add internal clock divider handle Date: Tue, 6 Aug 2019 12:27:51 +0200 [thread overview] Message-ID: <7edad4d7-5ba2-d710-eb8d-b3ff97051a41@linaro.org> (raw) In-Reply-To: <DB3PR0402MB3916B06E8907604A71169063F5D50@DB3PR0402MB3916.eurprd04.prod.outlook.com> On 06/08/2019 03:55, Anson Huang wrote: > Gentle ping... Coming back from vacation. It is in the pipe ... :) >> From: Anson Huang <Anson.Huang@nxp.com> >> >> The system counter block guide states that the base clock is internally divided >> by 3 before use, that means the clock input of system counter defined in DT >> should be base clock which is normally from OSC, and then internally divided >> by 3 before use. >> >> Signed-off-by: Anson Huang <Anson.Huang@nxp.com> >> --- >> Changes since V4: >> - to solve the clock driver probed after system counter driver issue, >> now we can easily switch to >> use fixed clock defined in DT and get its rate, then divided by 3 to >> get real clock rate for >> system counter driver, no need to add "clock-frequency" property in >> DT. >> --- >> drivers/clocksource/timer-imx-sysctr.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/clocksource/timer-imx-sysctr.c >> b/drivers/clocksource/timer-imx-sysctr.c >> index fd7d680..b7c80a3 100644 >> --- a/drivers/clocksource/timer-imx-sysctr.c >> +++ b/drivers/clocksource/timer-imx-sysctr.c >> @@ -20,6 +20,8 @@ >> #define SYS_CTR_EN 0x1 >> #define SYS_CTR_IRQ_MASK 0x2 >> >> +#define SYS_CTR_CLK_DIV 0x3 >> + >> static void __iomem *sys_ctr_base; >> static u32 cmpcr; >> >> @@ -134,6 +136,9 @@ static int __init sysctr_timer_init(struct device_node >> *np) >> if (ret) >> return ret; >> >> + /* system counter clock is divided by 3 internally */ >> + to_sysctr.of_clk.rate /= SYS_CTR_CLK_DIV; >> + >> sys_ctr_base = timer_of_base(&to_sysctr); >> cmpcr = readl(sys_ctr_base + CMPCR); >> cmpcr &= ~SYS_CTR_EN; >> -- >> 2.7.4 > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-06 10:27 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-10 6:30 [PATCH V5 1/5] clocksource: imx-sysctr: Add internal clock divider handle Anson.Huang 2019-07-10 6:30 ` Anson.Huang 2019-07-10 6:30 ` [PATCH V5 2/5] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms Anson.Huang 2019-07-10 6:30 ` Anson.Huang 2019-07-22 3:12 ` Shawn Guo 2019-07-22 3:12 ` Shawn Guo 2019-07-10 6:30 ` [PATCH V5 3/5] arm64: dts: imx8mm: Add system counter node Anson.Huang 2019-07-10 6:30 ` Anson.Huang 2019-07-22 3:15 ` Shawn Guo 2019-07-22 3:15 ` Shawn Guo 2019-07-23 2:29 ` Anson Huang 2019-07-23 2:29 ` Anson Huang 2019-07-23 2:29 ` Anson Huang 2019-07-10 6:30 ` [PATCH V5 4/5] arm64: dts: imx8mq: " Anson.Huang 2019-07-10 6:30 ` Anson.Huang 2019-07-10 6:30 ` [PATCH V5 5/5] arm64: dts: imx8mm: Enable cpu-idle driver Anson.Huang 2019-07-10 6:30 ` Anson.Huang 2019-08-15 16:12 ` Daniel Lezcano 2019-08-15 16:12 ` Daniel Lezcano 2019-08-16 1:03 ` Anson Huang 2019-08-16 1:03 ` Anson Huang 2019-08-16 1:03 ` Anson Huang 2019-08-19 7:27 ` Shawn Guo 2019-08-19 7:27 ` Shawn Guo 2019-08-06 1:55 ` [PATCH V5 1/5] clocksource: imx-sysctr: Add internal clock divider handle Anson Huang 2019-08-06 1:55 ` Anson Huang 2019-08-06 1:55 ` Anson Huang 2019-08-06 10:27 ` Daniel Lezcano [this message] 2019-08-06 10:27 ` Daniel Lezcano 2019-08-06 10:27 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7edad4d7-5ba2-d710-eb8d-b3ff97051a41@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=abel.vesa@nxp.com \ --cc=agx@sigxcpu.org \ --cc=aisheng.dong@nxp.com \ --cc=andrew.smirnov@gmail.com \ --cc=angus@akkea.ca \ --cc=anson.huang@nxp.com \ --cc=catalin.marinas@arm.com \ --cc=ccaione@baylibre.com \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=ping.bai@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.