* [U-Boot] [PATCH v2 0/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization.
@ 2017-07-01 6:56 Gautam Bhat
2017-07-01 6:56 ` [U-Boot] [PATCH v2 1/1] " Gautam Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Gautam Bhat @ 2017-07-01 6:56 UTC (permalink / raw)
To: u-boot
This change sets the VLDO4 settings output to 2.8V in PMIC
initialization. I accidentally noticed this when I was testing
the DSI voltage input which was 3.3V. Not setting the proper voltage
can harm some of the voltage sensitive peripheral.
Changes in v2:
- Removed extra parentheses for 0xF.
- Modified subject and commit messages as per the recommendation.
Gautam Bhat (1):
Set VLD04 output to 2.8V in PMIC initialization.
board/freescale/mx7dsabresd/mx7dsabresd.c | 10 ++++++++++
1 file changed, 10 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 1/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization.
2017-07-01 6:56 [U-Boot] [PATCH v2 0/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization Gautam Bhat
@ 2017-07-01 6:56 ` Gautam Bhat
2017-07-01 15:18 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Gautam Bhat @ 2017-07-01 6:56 UTC (permalink / raw)
To: u-boot
This change sets the VLDO4 settings output to 2.8V in PMIC
initialization so that the MIPI DSI/CSI input voltage is 2.8V
as per the schematics. The original code provides an output of
3.3V which violates the voltage mentioned in the schematics.
Acked-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
---
Changes in v2:
- Removed extra parentheses for 0xF.
- Modified subject and commit messages as per the recommendation.
board/freescale/mx7dsabresd/mx7dsabresd.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index ecea5a529a..c9ff2d8e40 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -341,6 +341,7 @@ int power_init_board(void)
{
struct udevice *dev;
int ret, dev_id, rev_id;
+ uint regval;
ret = pmic_get("pfuze3000", &dev);
if (ret == -ENODEV)
@@ -354,6 +355,15 @@ int power_init_board(void)
pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);
+ /*
+ * Set the voltage of VLDO4 output to 2.8V which feeds
+ * the MIPI DSI and MIPI CSI inputs.
+ */
+ regval = pmic_reg_read(dev, PFUZE3000_VLD4CTL);
+ regval &= ~0xF;
+ regval |= 0xA; /* Set to 2.8V */
+ pmic_reg_write(dev, PFUZE3000_VLD4CTL, regval);
+
return 0;
}
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2 1/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization.
2017-07-01 6:56 ` [U-Boot] [PATCH v2 1/1] " Gautam Bhat
@ 2017-07-01 15:18 ` Fabio Estevam
2017-07-02 19:20 ` [U-Boot] [PATCH v3 0/1] mx7dsabresd: " Gautam Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2017-07-01 15:18 UTC (permalink / raw)
To: u-boot
Hi Gautam,
On Sat, Jul 1, 2017 at 3:56 AM, Gautam Bhat <mindentropy@gmail.com> wrote:
> This change sets the VLDO4 settings output to 2.8V in PMIC
> initialization so that the MIPI DSI/CSI input voltage is 2.8V
> as per the schematics. The original code provides an output of
> 3.3V which violates the voltage mentioned in the schematics.
>
> Acked-by: Fabio Estevam <festevam@gmail.com>
Please don't add an Acked-by unless you explicitly received it.
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
> ---
>
> Changes in v2:
> - Removed extra parentheses for 0xF.
> - Modified subject and commit messages as per the recommendation.
>
> board/freescale/mx7dsabresd/mx7dsabresd.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
> index ecea5a529a..c9ff2d8e40 100644
> --- a/board/freescale/mx7dsabresd/mx7dsabresd.c
> +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
> @@ -341,6 +341,7 @@ int power_init_board(void)
> {
> struct udevice *dev;
> int ret, dev_id, rev_id;
> + uint regval;
unsigned int regval;
to make it consistent with other usage in this file.
>
> ret = pmic_get("pfuze3000", &dev);
> if (ret == -ENODEV)
> @@ -354,6 +355,15 @@ int power_init_board(void)
>
> pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);
>
> + /*
> + * Set the voltage of VLDO4 output to 2.8V which feeds
> + * the MIPI DSI and MIPI CSI inputs.
> + */
> + regval = pmic_reg_read(dev, PFUZE3000_VLD4CTL);
> + regval &= ~0xF;
> + regval |= 0xA; /* Set to 2.8V */
> + pmic_reg_write(dev, PFUZE3000_VLD4CTL, regval);
Please use pmic_clrsetbits for consistency.
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v3 0/1] mx7dsabresd: Set VLD04 output to 2.8V in PMIC initialization.
2017-07-01 15:18 ` Fabio Estevam
@ 2017-07-02 19:20 ` Gautam Bhat
2017-07-02 19:20 ` [U-Boot] [PATCH v3 1/1] " Gautam Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Gautam Bhat @ 2017-07-02 19:20 UTC (permalink / raw)
To: u-boot
This change sets the VLDO4 settings output to 2.8V in PMIC
initialization. I accidentally noticed this when I was testing
the DSI voltage input which was 3.3V. Not setting the proper voltage
can harm some of the voltage sensitive peripheral.
Changes in v3:
- Used pmic_clrsetbits for consistency.
Gautam Bhat (1):
Set VLD04 output to 2.8V in PMIC initialization.
board/freescale/mx7dsabresd/mx7dsabresd.c | 6 ++++++
1 file changed, 6 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v3 1/1] mx7dsabresd: Set VLD04 output to 2.8V in PMIC initialization.
2017-07-02 19:20 ` [U-Boot] [PATCH v3 0/1] mx7dsabresd: " Gautam Bhat
@ 2017-07-02 19:20 ` Gautam Bhat
2017-07-02 22:09 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Gautam Bhat @ 2017-07-02 19:20 UTC (permalink / raw)
To: u-boot
This change sets the VLDO4 settings output to 2.8V in PMIC
initialization so that the MIPI DSI/CSI input voltage is 2.8V
as per the schematics. The original code provides an output of
3.3V which violates the voltage mentioned in the schematics.
Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
---
Changes in v3:
- Used pmic_clrsetbits for consistency.
board/freescale/mx7dsabresd/mx7dsabresd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index ecea5a529a..7d22501d26 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -354,6 +354,12 @@ int power_init_board(void)
pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);
+ /*
+ * Set the voltage of VLDO4 output to 2.8V which feeds
+ * the MIPI DSI and MIPI CSI inputs.
+ */
+ pmic_clrsetbits(dev, PFUZE3000_VLD4CTL, 0xF, 0xA);
+
return 0;
}
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v3 1/1] mx7dsabresd: Set VLD04 output to 2.8V in PMIC initialization.
2017-07-02 19:20 ` [U-Boot] [PATCH v3 1/1] " Gautam Bhat
@ 2017-07-02 22:09 ` Fabio Estevam
2017-07-05 9:57 ` Stefano Babic
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2017-07-02 22:09 UTC (permalink / raw)
To: u-boot
On Sun, Jul 2, 2017 at 4:20 PM, Gautam Bhat <mindentropy@gmail.com> wrote:
> This change sets the VLDO4 settings output to 2.8V in PMIC
> initialization so that the MIPI DSI/CSI input voltage is 2.8V
> as per the schematics. The original code provides an output of
> 3.3V which violates the voltage mentioned in the schematics.
>
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
Acked-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v3 1/1] mx7dsabresd: Set VLD04 output to 2.8V in PMIC initialization.
2017-07-02 22:09 ` Fabio Estevam
@ 2017-07-05 9:57 ` Stefano Babic
0 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2017-07-05 9:57 UTC (permalink / raw)
To: u-boot
On 03/07/2017 00:09, Fabio Estevam wrote:
> On Sun, Jul 2, 2017 at 4:20 PM, Gautam Bhat <mindentropy@gmail.com> wrote:
>> This change sets the VLDO4 settings output to 2.8V in PMIC
>> initialization so that the MIPI DSI/CSI input voltage is 2.8V
>> as per the schematics. The original code provides an output of
>> 3.3V which violates the voltage mentioned in the schematics.
>>
>> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
>
> Acked-by: Fabio Estevam <fabio.estevam@nxp.com>
>
Applied to u-boot-imx, -next, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-05 9:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-01 6:56 [U-Boot] [PATCH v2 0/1] mx7sabresd: Set VLD04 output to 2.8V in PMIC initialization Gautam Bhat
2017-07-01 6:56 ` [U-Boot] [PATCH v2 1/1] " Gautam Bhat
2017-07-01 15:18 ` Fabio Estevam
2017-07-02 19:20 ` [U-Boot] [PATCH v3 0/1] mx7dsabresd: " Gautam Bhat
2017-07-02 19:20 ` [U-Boot] [PATCH v3 1/1] " Gautam Bhat
2017-07-02 22:09 ` Fabio Estevam
2017-07-05 9:57 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.