All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <jiwei.sun@windriver.com>, <linux-kernel@vger.kernel.org>,
	<linux-mtd@lists.infradead.org>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<jiwei.sun.bj@qq.com>
Subject: Re: [PATCH] mtd: spi-nor: make s25fl129p1 skip SFDP parsing
Date: Tue, 24 Dec 2019 00:29:18 +0000	[thread overview]
Message-ID: <7f0a49d4-b693-f18d-50ff-4ad5b4fc05e3@microchip.com> (raw)
In-Reply-To: <20191219081212.16927-1-jiwei.sun@windriver.com>

Hi, Jiwei,

On 12/19/19 10:12 AM, Jiwei Sun wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: jsun4 <jiwei.sun@windriver.com>
> 
> The right page size of S25FL129P has been gotten in the function
> spi_nor_info_init_params() before invoking spi_nor_parse_bfpt(),
> it is 256-bytes, but the size will be changed to 512 bytes in the
> following function spi_nor_parse_bfpt(). And there is no explanation of
> the SFDP according to the datasheet of S25FL129P. So we can skip
> SFDP parsing.
> 

Would you please dump the sfdp so that we can check what's going on?
If the BFPT table has the page size param wrong, we can use the
post_bfpt hook to correct it. This way we will still benefit of
the rest of the info from BFPT.

Cheers,
ta

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <jiwei.sun@windriver.com>, <linux-kernel@vger.kernel.org>,
	<linux-mtd@lists.infradead.org>
Cc: richard@nod.at, vigneshr@ti.com, jiwei.sun.bj@qq.com,
	miquel.raynal@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: make s25fl129p1 skip SFDP parsing
Date: Tue, 24 Dec 2019 00:29:18 +0000	[thread overview]
Message-ID: <7f0a49d4-b693-f18d-50ff-4ad5b4fc05e3@microchip.com> (raw)
In-Reply-To: <20191219081212.16927-1-jiwei.sun@windriver.com>

Hi, Jiwei,

On 12/19/19 10:12 AM, Jiwei Sun wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: jsun4 <jiwei.sun@windriver.com>
> 
> The right page size of S25FL129P has been gotten in the function
> spi_nor_info_init_params() before invoking spi_nor_parse_bfpt(),
> it is 256-bytes, but the size will be changed to 512 bytes in the
> following function spi_nor_parse_bfpt(). And there is no explanation of
> the SFDP according to the datasheet of S25FL129P. So we can skip
> SFDP parsing.
> 

Would you please dump the sfdp so that we can check what's going on?
If the BFPT table has the page size param wrong, we can use the
post_bfpt hook to correct it. This way we will still benefit of
the rest of the info from BFPT.

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-12-24  0:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19  8:12 [PATCH] mtd: spi-nor: make s25fl129p1 skip SFDP parsing Jiwei Sun
2019-12-24  0:29 ` Tudor.Ambarus [this message]
2019-12-24  0:29   ` Tudor.Ambarus
  -- strict thread matches above, loose matches on Subject: below --
2019-12-19  7:57 Jiwei Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f0a49d4-b693-f18d-50ff-4ad5b4fc05e3@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=jiwei.sun.bj@qq.com \
    --cc=jiwei.sun@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.