All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: peter.ujfalusi@ti.com, alsa-devel@alsa-project.org,
	amistry@google.com, nartemiev@google.com,
	Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
	Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Chuhong Yuan <hslester96@gmail.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: add dai_reoder flag to reverse the stop sequence
Date: Tue, 6 Jul 2021 00:30:10 +0530	[thread overview]
Message-ID: <7f1ad1b3-b509-24cf-00d8-f82766aae0d6@amd.com> (raw)
In-Reply-To: <20210705174241.GF4574@sirena.org.uk>

On 7/5/21 11:12 PM, Mark Brown wrote:
> On Mon, Jul 05, 2021 at 09:28:28PM +0530, Vijendar Mukunda wrote:
> 
>> @@ -982,6 +982,7 @@ struct snd_soc_card {
>>  	unsigned int disable_route_checks:1;
>>  	unsigned int probed:1;
>>  	unsigned int component_chaining:1;
>> +	unsigned int dai_reorder:1;
> 
> This feels like it should be a per dai_link option rather than a card
> wide option - the system could have a mix of links that do and don't
> want this depending on why it's an issue.  The name probably also wants
> to be more specific to what's being reordered, something like
> stop_dma_first for example since it's only for stops and moves the DMA
> first.
> 
As per our understanding by going with card wide option is easier rather
than checking dai link name for re-ordering the stop sequence for
specific platforms.
We will rename the flag as "stop_dma_fist" and will post the new version.

WARNING: multiple messages have this Message-ID (diff)
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com,
	amistry@google.com,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	open list <linux-kernel@vger.kernel.org>,
	Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
	Chuhong Yuan <hslester96@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	peter.ujfalusi@ti.com, Alexander.Deucher@amd.com,
	nartemiev@google.com
Subject: Re: [PATCH] ASoC: add dai_reoder flag to reverse the stop sequence
Date: Tue, 6 Jul 2021 00:30:10 +0530	[thread overview]
Message-ID: <7f1ad1b3-b509-24cf-00d8-f82766aae0d6@amd.com> (raw)
In-Reply-To: <20210705174241.GF4574@sirena.org.uk>

On 7/5/21 11:12 PM, Mark Brown wrote:
> On Mon, Jul 05, 2021 at 09:28:28PM +0530, Vijendar Mukunda wrote:
> 
>> @@ -982,6 +982,7 @@ struct snd_soc_card {
>>  	unsigned int disable_route_checks:1;
>>  	unsigned int probed:1;
>>  	unsigned int component_chaining:1;
>> +	unsigned int dai_reorder:1;
> 
> This feels like it should be a per dai_link option rather than a card
> wide option - the system could have a mix of links that do and don't
> want this depending on why it's an issue.  The name probably also wants
> to be more specific to what's being reordered, something like
> stop_dma_first for example since it's only for stops and moves the DMA
> first.
> 
As per our understanding by going with card wide option is easier rather
than checking dai link name for re-ordering the stop sequence for
specific platforms.
We will rename the flag as "stop_dma_fist" and will post the new version.

  reply	other threads:[~2021-07-05 18:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 15:58 [PATCH] ASoC: add dai_reoder flag to reverse the stop sequence Vijendar Mukunda
2021-07-05 15:58 ` Vijendar Mukunda
2021-07-05 17:42 ` Mark Brown
2021-07-05 17:42   ` Mark Brown
2021-07-05 19:00   ` Mukunda,Vijendar [this message]
2021-07-05 19:00     ` Mukunda,Vijendar
2021-07-05 19:29     ` Mark Brown
2021-07-05 19:29       ` Mark Brown
2021-07-05 20:10       ` Mukunda,Vijendar
2021-07-05 20:10         ` Mukunda,Vijendar
2021-07-06 12:30         ` Mark Brown
2021-07-06 12:30           ` Mark Brown
2021-07-05 18:06 ` kernel test robot
2021-07-05 18:06   ` kernel test robot
2021-07-05 19:14   ` Mukunda,Vijendar
2021-07-05 19:14     ` Mukunda, Vijendar
2021-07-05 19:01 ` kernel test robot
2021-07-05 19:01   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f1ad1b3-b509-24cf-00d8-f82766aae0d6@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Basavaraj.Hiregoudar@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amistry@google.com \
    --cc=broonie@kernel.org \
    --cc=hslester96@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nartemiev@google.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@ti.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.