From: Grygorii Strashko <grygorii.strashko@ti.com> To: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org> Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: drop vid0 configuration in dual_mac modey Date: Mon, 26 Nov 2018 12:57:20 -0600 [thread overview] Message-ID: <7f2c5e66-3b42-f921-c52d-236f5adc44bf@ti.com> (raw) In-Reply-To: <20181126162644.GA23230@khorivan> On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote: > On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote: >> In dual_mac mode CPSW driver uses vid1 and vid2 by default to implement >> dual mac mode wich are used to configure pvids for each external ports. >> But, historicaly, it also adds vid0 to ALE table and sets "untag" bits for both >> ext. ports. As result, it's imposible to use priority tagged packets in >> dual mac mode. >> >> Hence, drop vid0 configuration in dual mac mode as it's not required for dual >> mac mode functionality and, this way, make it possible to use priority >> tagged packet in dual mac mode. > So, now it's enabled to be added via regular ndo. > I have similar change in mind, but was going to send it after > mcast/ucast, and - enabling same vlans patch... > > 2 things stopped me to add this: > > 1) Moving it to be enabled via regular call is Ok, but in dual mac mode > it causes overlaps, at least while vid deletion. So decided to wait till > same vlans series is applied. TI driver documentation mentions this restriction "While adding VLAN id to the eth interfaces, same VLAN id should not be added in both interfaces which will lead to VLAN forwarding and act as switch" > > 2) Wanted implement somehow similar handling for single port boards > in one patch, not only for dual mac mode. This part was not clear and > not verified completely... > > So, if it's needed now, maybe better at this moment only remove > untag field? and remove vlan0 later, once other vlan changes applied. > > Say: > > cpsw_ale_add_vlan(cpsw->ale, cpsw->data.default_vlan, > ALE_ALL_PORTS, 0, ALE_ALL_PORTS, 0); > > instead of: > cpsw_ale_add_vlan(cpsw->ale, cpsw->data.default_vlan, > ALE_ALL_PORTS, ALE_ALL_PORTS, 0, 0); > This patch affects only dual_mac mode and in this mode adding vid0 by default is definitely make no sense in any case. [1] http://processors.wiki.ti.com/index.php/Linux_Core_CPSW_User%27s_Guide#Dual_Standalone_EMAC_mode >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> drivers/net/ethernet/ti/cpsw.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) -- regards, -grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com> To: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: drop vid0 configuration in dual_mac modey Date: Mon, 26 Nov 2018 12:57:20 -0600 [thread overview] Message-ID: <7f2c5e66-3b42-f921-c52d-236f5adc44bf@ti.com> (raw) In-Reply-To: <20181126162644.GA23230@khorivan> On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote: > On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote: >> In dual_mac mode CPSW driver uses vid1 and vid2 by default to implement >> dual mac mode wich are used to configure pvids for each external ports. >> But, historicaly, it also adds vid0 to ALE table and sets "untag" bits for both >> ext. ports. As result, it's imposible to use priority tagged packets in >> dual mac mode. >> >> Hence, drop vid0 configuration in dual mac mode as it's not required for dual >> mac mode functionality and, this way, make it possible to use priority >> tagged packet in dual mac mode. > So, now it's enabled to be added via regular ndo. > I have similar change in mind, but was going to send it after > mcast/ucast, and - enabling same vlans patch... > > 2 things stopped me to add this: > > 1) Moving it to be enabled via regular call is Ok, but in dual mac mode > it causes overlaps, at least while vid deletion. So decided to wait till > same vlans series is applied. TI driver documentation mentions this restriction "While adding VLAN id to the eth interfaces, same VLAN id should not be added in both interfaces which will lead to VLAN forwarding and act as switch" > > 2) Wanted implement somehow similar handling for single port boards > in one patch, not only for dual mac mode. This part was not clear and > not verified completely... > > So, if it's needed now, maybe better at this moment only remove > untag field? and remove vlan0 later, once other vlan changes applied. > > Say: > > cpsw_ale_add_vlan(cpsw->ale, cpsw->data.default_vlan, > ALE_ALL_PORTS, 0, ALE_ALL_PORTS, 0); > > instead of: > cpsw_ale_add_vlan(cpsw->ale, cpsw->data.default_vlan, > ALE_ALL_PORTS, ALE_ALL_PORTS, 0, 0); > This patch affects only dual_mac mode and in this mode adding vid0 by default is definitely make no sense in any case. [1] http://processors.wiki.ti.com/index.php/Linux_Core_CPSW_User%27s_Guide#Dual_Standalone_EMAC_mode >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> drivers/net/ethernet/ti/cpsw.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) -- regards, -grygorii
next prev parent reply other threads:[~2018-11-26 18:57 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-25 23:46 [PATCH net-next] net: ethernet: ti: cpsw: drop vid0 configuration in dual_mac mode Grygorii Strashko 2018-11-25 23:46 ` Grygorii Strashko 2018-11-26 16:26 ` [PATCH net-next] net: ethernet: ti: cpsw: drop vid0 configuration in dual_mac modey Ivan Khoronzhuk 2018-11-26 18:57 ` Grygorii Strashko [this message] 2018-11-26 18:57 ` Grygorii Strashko 2018-11-26 20:07 ` Ivan Khoronzhuk 2018-11-27 1:08 ` Grygorii Strashko 2018-11-27 1:08 ` Grygorii Strashko 2018-11-28 21:15 ` Grygorii Strashko 2018-11-28 21:15 ` Grygorii Strashko 2018-11-29 15:26 ` Ivan Khoronzhuk 2018-11-29 23:23 ` Grygorii Strashko 2018-11-29 23:23 ` Grygorii Strashko 2018-11-30 13:42 ` Ivan Khoronzhuk 2018-11-30 13:55 ` Ivan Khoronzhuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7f2c5e66-3b42-f921-c52d-236f5adc44bf@ti.com \ --to=grygorii.strashko@ti.com \ --cc=davem@davemloft.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=nsekhar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.