From: Florian Fainelli <f.fainelli@gmail.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Srinath Mannam <srinath.mannam@broadcom.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 01/13] phy: usb: EHCI DMA may lose a burst of DMA data for 7255xA0 family
Date: Fri, 3 Jan 2020 10:22:54 -0800 [thread overview]
Message-ID: <7f52c9eb-7cd6-db19-f67e-1d8e95621c4c@gmail.com> (raw)
In-Reply-To: <20200103181811.22939-2-alcooperx@gmail.com>
On 1/3/20 10:17 AM, Al Cooper wrote:
> When the EHCI controller received a 512 byte USB packet that
> had to be broken into 2 256 byte bursts across the SCB bus AND
> there was a following 512 byte USB packet, the second burst of
> data from the first packet was sometimes being lost. If the
> burst size was changed to 128 bytes via the EBR_SCB_SIZE field
> in the USB_CTRL_EBRIDGE register we'd see the 4th 128 byte burst
> of the first packet being lost. This problem became much worse
> if other threads were running that accessed memory, like a memcpy
> test. Setting the EBR_SCB_SIZE to 512, which prevents breaking
> the EHCI USB packet (max size of 512 bytes) into bursts, fixed
> the problem.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Srinath Mannam <srinath.mannam@broadcom.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 01/13] phy: usb: EHCI DMA may lose a burst of DMA data for 7255xA0 family
Date: Fri, 3 Jan 2020 10:22:54 -0800 [thread overview]
Message-ID: <7f52c9eb-7cd6-db19-f67e-1d8e95621c4c@gmail.com> (raw)
In-Reply-To: <20200103181811.22939-2-alcooperx@gmail.com>
On 1/3/20 10:17 AM, Al Cooper wrote:
> When the EHCI controller received a 512 byte USB packet that
> had to be broken into 2 256 byte bursts across the SCB bus AND
> there was a following 512 byte USB packet, the second burst of
> data from the first packet was sometimes being lost. If the
> burst size was changed to 128 bytes via the EBR_SCB_SIZE field
> in the USB_CTRL_EBRIDGE register we'd see the 4th 128 byte burst
> of the first packet being lost. This problem became much worse
> if other threads were running that accessed memory, like a memcpy
> test. Setting the EBR_SCB_SIZE to 512, which prevents breaking
> the EHCI USB packet (max size of 512 bytes) into bursts, fixed
> the problem.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-03 18:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 18:17 [PATCH v4 00/13] phy: usb: Updates to Broadcom STB USB PHY driver Al Cooper
2020-01-03 18:17 ` Al Cooper
2020-01-03 18:17 ` [PATCH v4 01/13] phy: usb: EHCI DMA may lose a burst of DMA data for 7255xA0 family Al Cooper
2020-01-03 18:17 ` Al Cooper
2020-01-03 18:22 ` Florian Fainelli [this message]
2020-01-03 18:22 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 02/13] phy: usb: Get all drivers that use USB clks using correct enable/disable Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:23 ` Florian Fainelli
2020-01-03 18:23 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 03/13] phy: usb: Put USB phys into IDDQ on suspend to save power in S2 mode Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:23 ` Florian Fainelli
2020-01-03 18:23 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 04/13] phy: usb: Add "wake on" functionality Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:24 ` Florian Fainelli
2020-01-03 18:24 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 05/13] phy: usb: Restructure in preparation for adding 7216 USB support Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:25 ` Florian Fainelli
2020-01-03 18:25 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 06/13] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:25 ` Florian Fainelli
2020-01-03 18:25 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 07/13] phy: usb: Add support for new Synopsys USB controller on the 7216 Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:26 ` Florian Fainelli
2020-01-03 18:26 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 08/13] phy: usb: Add support for new Synopsys USB controller on the 7211b0 Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:26 ` Florian Fainelli
2020-01-03 18:26 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 09/13] phy: usb: fix driver to defer on clk_get defer Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:26 ` Florian Fainelli
2020-01-03 18:26 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 10/13] phy: usb: PHY's MDIO registers not accessible without device installed Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:27 ` Florian Fainelli
2020-01-03 18:27 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 11/13] phy: usb: bdc: Fix occasional failure with BDC on 7211 Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:27 ` Florian Fainelli
2020-01-03 18:27 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 12/13] phy: usb: USB driver is crashing during S3 resume on 7216 Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:28 ` Florian Fainelli
2020-01-03 18:28 ` Florian Fainelli
2020-01-03 18:18 ` [PATCH v4 13/13] phy: usb: Add support for wake and USB low power mode for 7211 S2/S5 Al Cooper
2020-01-03 18:18 ` Al Cooper
2020-01-03 18:28 ` Florian Fainelli
2020-01-03 18:28 ` Florian Fainelli
2020-01-06 5:25 ` [PATCH v4 00/13] phy: usb: Updates to Broadcom STB USB PHY driver Kishon Vijay Abraham I
2020-01-06 5:25 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f52c9eb-7cd6-db19-f67e-1d8e95621c4c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.