All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Yu <jack.yu@realtek.com>
To: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Brent Lu" <brent.lu@intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"kent_chen@realtek.com [陳建宏]" <kent_chen@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>,
	Yong Zhi <yong.zhi@intel.com>,
	Libin Yang <libin.yang@linux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
	Dharageswari R <dharageswari.r@intel.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Fred Oh <fred.oh@linux.intel.com>,
	Tzung-Bi Shih <tzungbi@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support
Date: Thu, 18 Mar 2021 01:21:03 +0000	[thread overview]
Message-ID: <7f91482a93aa4d429ee574d730eeca6a@realtek.com> (raw)
In-Reply-To: <af990f6f-3a8b-3a1e-a02a-3bfe96e4d80a@linux.intel.com>

> > This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset
> > codec and ALC1015Q-VB speaker amplifier combination on JasperLake
> > platform.
> >
> > This driver also supports ALC1015Q-CG if running in auto-mode.
> > Following table shows the audio interface support of the two
> > amplifiers.
> >
> >            | ALC1015Q-CG | ALC1015Q-VB
> > =====================================
> > I2C       | Yes         | No
> > Auto-mode | 48K, 64fs   | 16k, 32fs
> >                          | 48k, 32fs
> >                          | 48k, 64fs
> >
> > Signed-off-by: Brent Lu <brent.lu@intel.com>
> 
> The code is looks fine, but Jack Yu added a separate patch that makes
> RTL1019 equivalent to RTL1015, so should this patch also handle the
> RTL1019 case?
> 
For rt1019 non-i2c mode (auto mode), it uses the sdb pin to enable amp, the same as rt1015 non-i2c mode,
therefore we propose rt1019(auto mode) to use rt1015p instead of adding a new driver for it.

WARNING: multiple messages have this Message-ID (diff)
From: Jack Yu <jack.yu@realtek.com>
To: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Brent Lu" <brent.lu@intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"kent_chen@realtek.com [陳建宏]" <kent_chen@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Dharageswari R <dharageswari.r@intel.com>,
	Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jie Yang <yang.jie@linux.intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Fred Oh <fred.oh@linux.intel.com>,
	Tzung-Bi Shih <tzungbi@google.com>,
	Mark Brown <broonie@kernel.org>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Libin Yang <libin.yang@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>,
	Yong Zhi <yong.zhi@intel.com>
Subject: RE: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support
Date: Thu, 18 Mar 2021 01:21:03 +0000	[thread overview]
Message-ID: <7f91482a93aa4d429ee574d730eeca6a@realtek.com> (raw)
In-Reply-To: <af990f6f-3a8b-3a1e-a02a-3bfe96e4d80a@linux.intel.com>

> > This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset
> > codec and ALC1015Q-VB speaker amplifier combination on JasperLake
> > platform.
> >
> > This driver also supports ALC1015Q-CG if running in auto-mode.
> > Following table shows the audio interface support of the two
> > amplifiers.
> >
> >            | ALC1015Q-CG | ALC1015Q-VB
> > =====================================
> > I2C       | Yes         | No
> > Auto-mode | 48K, 64fs   | 16k, 32fs
> >                          | 48k, 32fs
> >                          | 48k, 64fs
> >
> > Signed-off-by: Brent Lu <brent.lu@intel.com>
> 
> The code is looks fine, but Jack Yu added a separate patch that makes
> RTL1019 equivalent to RTL1015, so should this patch also handle the
> RTL1019 case?
> 
For rt1019 non-i2c mode (auto mode), it uses the sdb pin to enable amp, the same as rt1015 non-i2c mode,
therefore we propose rt1019(auto mode) to use rt1015p instead of adding a new driver for it.

  parent reply	other threads:[~2021-03-18  1:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 11:08 [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support Brent Lu
2021-03-17 11:08 ` Brent Lu
2021-03-17 14:02 ` Pierre-Louis Bossart
2021-03-17 14:02   ` Pierre-Louis Bossart
2021-03-17 15:37   ` Lu, Brent
2021-03-17 15:37     ` Lu, Brent
2021-03-18  1:21     ` Jack Yu
2021-03-18  1:21       ` Jack Yu
2021-03-18  2:19       ` kent_chen@realtek.com [陳建宏]
2021-03-18  2:19         ` kent_chen@realtek.com [陳建宏]
2021-03-18  1:21   ` Jack Yu [this message]
2021-03-18  1:21     ` Jack Yu
2021-03-18 10:57     ` Pierre-Louis Bossart
2021-03-18 10:57       ` Pierre-Louis Bossart
2021-03-18 18:36 ` Mark Brown
2021-03-18 18:36   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f91482a93aa4d429ee574d730eeca6a@realtek.com \
    --to=jack.yu@realtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=dharageswari.r@intel.com \
    --cc=fred.oh@linux.intel.com \
    --cc=guennadi.liakhovetski@linux.intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kent_chen@realtek.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=libin.yang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sathyanarayana.nujella@intel.com \
    --cc=tiwai@suse.com \
    --cc=tzungbi@google.com \
    --cc=yang.jie@linux.intel.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.