* [PATCH v2] media: exynos4-is: Add missed check for pinctrl_lookup_state()
@ 2020-05-28 6:41 ` Chuhong Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Chuhong Yuan @ 2020-05-28 6:41 UTC (permalink / raw)
Cc: Kyungmin Park, Sylwester Nawrocki, Mauro Carvalho Chehab,
Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Chuhong Yuan
fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state().
Add the missed check to fix it.
Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Add fixes tag.
drivers/media/platform/exynos4-is/media-dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index 9aaf3b8060d5..9c31d950cddf 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -1270,6 +1270,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd)
pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl,
PINCTRL_STATE_IDLE);
+ if (IS_ERR(pctl->state_idle))
+ return PTR_ERR(pctl->state_idle);
+
return 0;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] media: exynos4-is: Add missed check for pinctrl_lookup_state()
@ 2020-05-28 6:41 ` Chuhong Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Chuhong Yuan @ 2020-05-28 6:41 UTC (permalink / raw)
Cc: linux-samsung-soc, Chuhong Yuan, linux-kernel,
Krzysztof Kozlowski, Kyungmin Park, Kukjin Kim,
Sylwester Nawrocki, Mauro Carvalho Chehab, linux-arm-kernel,
linux-media
fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state().
Add the missed check to fix it.
Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Add fixes tag.
drivers/media/platform/exynos4-is/media-dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index 9aaf3b8060d5..9c31d950cddf 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -1270,6 +1270,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd)
pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl,
PINCTRL_STATE_IDLE);
+ if (IS_ERR(pctl->state_idle))
+ return PTR_ERR(pctl->state_idle);
+
return 0;
}
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: exynos4-is: Add missed check for pinctrl_lookup_state()
2020-05-28 6:41 ` Chuhong Yuan
@ 2020-08-10 9:31 ` Sylwester Nawrocki
-1 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2020-08-10 9:31 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Kyungmin Park, Mauro Carvalho Chehab, Kukjin Kim,
Krzysztof Kozlowski, linux-media, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Hi,
On 28.05.2020 08:41, Chuhong Yuan wrote:
> fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state().
> Add the missed check to fix it.
>
> Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Add fixes tag.
>
> drivers/media/platform/exynos4-is/media-dev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
> index 9aaf3b8060d5..9c31d950cddf 100644
> --- a/drivers/media/platform/exynos4-is/media-dev.c
> +++ b/drivers/media/platform/exynos4-is/media-dev.c
> @@ -1270,6 +1270,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd)
>
> pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl,
> PINCTRL_STATE_IDLE);
> + if (IS_ERR(pctl->state_idle))
> + return PTR_ERR(pctl->state_idle);
Unfortunately this is not correct, with that change the driver currently
fails to initialize. The "idle" pinctrl state is optional and might not
be specified in DT, as explained in the DT binding documentation added
by the patch you mentioned in the "Fixes" tag.
Actually the "idle" state is now not used in any mainline dts, I will
post a patch that removes related code in the driver.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: exynos4-is: Add missed check for pinctrl_lookup_state()
@ 2020-08-10 9:31 ` Sylwester Nawrocki
0 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2020-08-10 9:31 UTC (permalink / raw)
To: Chuhong Yuan
Cc: linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
Kyungmin Park, Kukjin Kim, Mauro Carvalho Chehab,
linux-arm-kernel, linux-media
Hi,
On 28.05.2020 08:41, Chuhong Yuan wrote:
> fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state().
> Add the missed check to fix it.
>
> Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Add fixes tag.
>
> drivers/media/platform/exynos4-is/media-dev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
> index 9aaf3b8060d5..9c31d950cddf 100644
> --- a/drivers/media/platform/exynos4-is/media-dev.c
> +++ b/drivers/media/platform/exynos4-is/media-dev.c
> @@ -1270,6 +1270,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd)
>
> pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl,
> PINCTRL_STATE_IDLE);
> + if (IS_ERR(pctl->state_idle))
> + return PTR_ERR(pctl->state_idle);
Unfortunately this is not correct, with that change the driver currently
fails to initialize. The "idle" pinctrl state is optional and might not
be specified in DT, as explained in the DT binding documentation added
by the patch you mentioned in the "Fixes" tag.
Actually the "idle" state is now not used in any mainline dts, I will
post a patch that removes related code in the driver.
--
Thanks,
Sylwester
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-10 9:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200528064613eucas1p268b1692ad11d7d2be863280be7d378c1@eucas1p2.samsung.com>
2020-05-28 6:41 ` [PATCH v2] media: exynos4-is: Add missed check for pinctrl_lookup_state() Chuhong Yuan
2020-05-28 6:41 ` Chuhong Yuan
2020-08-10 9:31 ` Sylwester Nawrocki
2020-08-10 9:31 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.