All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times
@ 2017-08-01 15:22 ` Jerome Brunet
  0 siblings, 0 replies; 6+ messages in thread
From: Jerome Brunet @ 2017-08-01 15:22 UTC (permalink / raw)
  To: Kevin Hilman, Carlo Caione
  Cc: Jerome Brunet, linux-amlogic, linux-arm-kernel, linux-kernel, devicetree

Changing the card voltage on the p200 is not instantaneous, especially
when switching from 3.3v to 1.8v.

I take at least 70ms for the regulator to go from 3.3v to 1.8v. Add
margin to that to make sure we don't upset the sdcard during the voltage
switch

Fixes: ef8d2ffedf18 ("ARM64: dts: meson-gxbb: add MMC support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index 9603a635c7af..d3b194c20b72 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -84,6 +84,9 @@
 		/* Based on P200 schematics, signal CARD_1.8V/3.3V_CTR */
 		states = <1800000 0
 			  3300000 1>;
+
+		regulator-settling-time-up-us = <10000>;
+		regulator-settling-time-down-us = <150000>;
 	};
 
 	vddio_boot: regulator-vddio_boot {
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times
@ 2017-08-01 15:22 ` Jerome Brunet
  0 siblings, 0 replies; 6+ messages in thread
From: Jerome Brunet @ 2017-08-01 15:22 UTC (permalink / raw)
  To: linux-arm-kernel

Changing the card voltage on the p200 is not instantaneous, especially
when switching from 3.3v to 1.8v.

I take at least 70ms for the regulator to go from 3.3v to 1.8v. Add
margin to that to make sure we don't upset the sdcard during the voltage
switch

Fixes: ef8d2ffedf18 ("ARM64: dts: meson-gxbb: add MMC support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index 9603a635c7af..d3b194c20b72 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -84,6 +84,9 @@
 		/* Based on P200 schematics, signal CARD_1.8V/3.3V_CTR */
 		states = <1800000 0
 			  3300000 1>;
+
+		regulator-settling-time-up-us = <10000>;
+		regulator-settling-time-down-us = <150000>;
 	};
 
 	vddio_boot: regulator-vddio_boot {
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times
@ 2017-08-01 15:22 ` Jerome Brunet
  0 siblings, 0 replies; 6+ messages in thread
From: Jerome Brunet @ 2017-08-01 15:22 UTC (permalink / raw)
  To: linus-amlogic

Changing the card voltage on the p200 is not instantaneous, especially
when switching from 3.3v to 1.8v.

I take at least 70ms for the regulator to go from 3.3v to 1.8v. Add
margin to that to make sure we don't upset the sdcard during the voltage
switch

Fixes: ef8d2ffedf18 ("ARM64: dts: meson-gxbb: add MMC support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index 9603a635c7af..d3b194c20b72 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -84,6 +84,9 @@
 		/* Based on P200 schematics, signal CARD_1.8V/3.3V_CTR */
 		states = <1800000 0
 			  3300000 1>;
+
+		regulator-settling-time-up-us = <10000>;
+		regulator-settling-time-down-us = <150000>;
 	};
 
 	vddio_boot: regulator-vddio_boot {
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times
  2017-08-01 15:22 ` Jerome Brunet
  (?)
@ 2017-08-01 19:49   ` Kevin Hilman
  -1 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2017-08-01 19:49 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Carlo Caione, linux-amlogic, linux-arm-kernel, linux-kernel, devicetree

Jerome Brunet <jbrunet@baylibre.com> writes:

> Changing the card voltage on the p200 is not instantaneous, especially
> when switching from 3.3v to 1.8v.
>
> I take at least 70ms for the regulator to go from 3.3v to 1.8v. Add
> margin to that to make sure we don't upset the sdcard during the voltage
> switch
>
> Fixes: ef8d2ffedf18 ("ARM64: dts: meson-gxbb: add MMC support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Applied to v4.14/dt64,

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times
@ 2017-08-01 19:49   ` Kevin Hilman
  0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2017-08-01 19:49 UTC (permalink / raw)
  To: linux-arm-kernel

Jerome Brunet <jbrunet@baylibre.com> writes:

> Changing the card voltage on the p200 is not instantaneous, especially
> when switching from 3.3v to 1.8v.
>
> I take at least 70ms for the regulator to go from 3.3v to 1.8v. Add
> margin to that to make sure we don't upset the sdcard during the voltage
> switch
>
> Fixes: ef8d2ffedf18 ("ARM64: dts: meson-gxbb: add MMC support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Applied to v4.14/dt64,

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times
@ 2017-08-01 19:49   ` Kevin Hilman
  0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2017-08-01 19:49 UTC (permalink / raw)
  To: linus-amlogic

Jerome Brunet <jbrunet@baylibre.com> writes:

> Changing the card voltage on the p200 is not instantaneous, especially
> when switching from 3.3v to 1.8v.
>
> I take at least 70ms for the regulator to go from 3.3v to 1.8v. Add
> margin to that to make sure we don't upset the sdcard during the voltage
> switch
>
> Fixes: ef8d2ffedf18 ("ARM64: dts: meson-gxbb: add MMC support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Applied to v4.14/dt64,

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-01 19:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 15:22 [PATCH] ARM64: dts: meson-gxbb: p20x: add card regulator settle times Jerome Brunet
2017-08-01 15:22 ` Jerome Brunet
2017-08-01 15:22 ` Jerome Brunet
2017-08-01 19:49 ` Kevin Hilman
2017-08-01 19:49   ` Kevin Hilman
2017-08-01 19:49   ` Kevin Hilman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.