From: Kevin Hilman <khilman@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Carlo Caione <carlo@caione.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: meson-sm: use generic compatible
Date: Thu, 19 Oct 2017 12:25:30 +0200 [thread overview]
Message-ID: <7h8tg7zb6t.fsf@baylibre.com> (raw)
In-Reply-To: <20171017204959.kfbhn2yxhv2sb5qg@rob-hp-laptop> (Rob Herring's message of "Tue, 17 Oct 2017 15:50:00 -0500")
Rob Herring <robh@kernel.org> writes:
> On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote:
>> The meson secure monitor seems to be compatible with more SoCs than
>> initially thought. Let's use the most generic compatible he have in
>> DT instead of the gxbb specific one
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++--
>> drivers/firmware/meson/meson_sm.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> Seems like a pointless, not backwards compatible change to me.
I've verified that it's backwards compatible with existing upstream DTs.
> end, it's just a string to match on. Who cares what the string is.
As platform maintiner, I very much care what the strings are and I want
it to be coherent with the platform generic names, and I want the
SoC-specific strings to correspond to the actual SoC names.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] firmware: meson-sm: use generic compatible
Date: Thu, 19 Oct 2017 12:25:30 +0200 [thread overview]
Message-ID: <7h8tg7zb6t.fsf@baylibre.com> (raw)
In-Reply-To: <20171017204959.kfbhn2yxhv2sb5qg@rob-hp-laptop> (Rob Herring's message of "Tue, 17 Oct 2017 15:50:00 -0500")
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
> On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote:
>> The meson secure monitor seems to be compatible with more SoCs than
>> initially thought. Let's use the most generic compatible he have in
>> DT instead of the gxbb specific one
>>
>> Signed-off-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>> ---
>> Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++--
>> drivers/firmware/meson/meson_sm.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> Seems like a pointless, not backwards compatible change to me.
I've verified that it's backwards compatible with existing upstream DTs.
> end, it's just a string to match on. Who cares what the string is.
As platform maintiner, I very much care what the strings are and I want
it to be coherent with the platform generic names, and I want the
SoC-specific strings to correspond to the actual SoC names.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] firmware: meson-sm: use generic compatible
Date: Thu, 19 Oct 2017 12:25:30 +0200 [thread overview]
Message-ID: <7h8tg7zb6t.fsf@baylibre.com> (raw)
In-Reply-To: <20171017204959.kfbhn2yxhv2sb5qg@rob-hp-laptop> (Rob Herring's message of "Tue, 17 Oct 2017 15:50:00 -0500")
Rob Herring <robh@kernel.org> writes:
> On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote:
>> The meson secure monitor seems to be compatible with more SoCs than
>> initially thought. Let's use the most generic compatible he have in
>> DT instead of the gxbb specific one
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++--
>> drivers/firmware/meson/meson_sm.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> Seems like a pointless, not backwards compatible change to me.
I've verified that it's backwards compatible with existing upstream DTs.
> end, it's just a string to match on. Who cares what the string is.
As platform maintiner, I very much care what the strings are and I want
it to be coherent with the platform generic names, and I want the
SoC-specific strings to correspond to the actual SoC names.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] firmware: meson-sm: use generic compatible
Date: Thu, 19 Oct 2017 12:25:30 +0200 [thread overview]
Message-ID: <7h8tg7zb6t.fsf@baylibre.com> (raw)
In-Reply-To: <20171017204959.kfbhn2yxhv2sb5qg@rob-hp-laptop> (Rob Herring's message of "Tue, 17 Oct 2017 15:50:00 -0500")
Rob Herring <robh@kernel.org> writes:
> On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote:
>> The meson secure monitor seems to be compatible with more SoCs than
>> initially thought. Let's use the most generic compatible he have in
>> DT instead of the gxbb specific one
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++--
>> drivers/firmware/meson/meson_sm.c | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> Seems like a pointless, not backwards compatible change to me.
I've verified that it's backwards compatible with existing upstream DTs.
> end, it's just a string to match on. Who cares what the string is.
As platform maintiner, I very much care what the strings are and I want
it to be coherent with the platform generic names, and I want the
SoC-specific strings to correspond to the actual SoC names.
Kevin
next prev parent reply other threads:[~2017-10-19 10:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 13:47 [PATCH] firmware: meson-sm: use generic compatible Jerome Brunet
2017-10-12 13:47 ` Jerome Brunet
2017-10-12 13:47 ` Jerome Brunet
2017-10-12 13:47 ` Jerome Brunet
2017-10-17 20:50 ` Rob Herring
2017-10-17 20:50 ` Rob Herring
2017-10-17 20:50 ` Rob Herring
2017-10-17 20:50 ` Rob Herring
2017-10-18 7:27 ` Jerome Brunet
2017-10-18 7:27 ` Jerome Brunet
2017-10-18 7:27 ` Jerome Brunet
2017-10-19 10:25 ` Kevin Hilman [this message]
2017-10-19 10:25 ` Kevin Hilman
2017-10-19 10:25 ` Kevin Hilman
2017-10-19 10:25 ` Kevin Hilman
2017-10-19 21:18 ` Rob Herring
2017-10-19 21:18 ` Rob Herring
2017-10-19 21:18 ` Rob Herring
2017-10-19 21:18 ` Rob Herring
2017-10-20 8:30 ` Jerome Brunet
2017-10-20 8:30 ` Jerome Brunet
2017-10-20 8:30 ` Jerome Brunet
2017-10-20 8:30 ` Jerome Brunet
2017-10-20 19:34 ` Rob Herring
2017-10-20 19:34 ` Rob Herring
2017-10-20 19:34 ` Rob Herring
2017-10-20 19:34 ` Rob Herring
2017-10-23 8:13 ` Jerome Brunet
2017-10-23 8:13 ` Jerome Brunet
2017-10-23 8:13 ` Jerome Brunet
2017-10-23 8:13 ` Jerome Brunet
2017-10-23 19:29 ` Rob Herring
2017-10-23 19:29 ` Rob Herring
2017-10-23 19:29 ` Rob Herring
2017-10-23 19:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8tg7zb6t.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.