* [PATCH] MMC: meson: remove unused variable
@ 2016-09-15 15:43 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-15 15:43 UTC (permalink / raw)
To: Ulf Hansson
Cc: Arnd Bergmann, Carlo Caione, Kevin Hilman, linux-mmc,
linux-arm-kernel, linux-amlogic, linux-kernel
The newly added meson mmc driver causes a build warning from an unused
variable:
drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
This removes the variable.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
---
drivers/mmc/host/meson-gxbb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
index c73c62178764..193d343d0afe 100644
--- a/drivers/mmc/host/meson-gxbb.c
+++ b/drivers/mmc/host/meson-gxbb.c
@@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct meson_host *host = mmc_priv(mmc);
- struct mmc_command *cmd = host->cmd;
WARN_ON(host->mrq != mrq);
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] MMC: meson: remove unused variable
@ 2016-09-15 15:43 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-15 15:43 UTC (permalink / raw)
To: linux-arm-kernel
The newly added meson mmc driver causes a build warning from an unused
variable:
drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
This removes the variable.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
---
drivers/mmc/host/meson-gxbb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
index c73c62178764..193d343d0afe 100644
--- a/drivers/mmc/host/meson-gxbb.c
+++ b/drivers/mmc/host/meson-gxbb.c
@@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct meson_host *host = mmc_priv(mmc);
- struct mmc_command *cmd = host->cmd;
WARN_ON(host->mrq != mrq);
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] MMC: meson: remove unused variable
@ 2016-09-15 15:43 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-15 15:43 UTC (permalink / raw)
To: linus-amlogic
The newly added meson mmc driver causes a build warning from an unused
variable:
drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
This removes the variable.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
---
drivers/mmc/host/meson-gxbb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
index c73c62178764..193d343d0afe 100644
--- a/drivers/mmc/host/meson-gxbb.c
+++ b/drivers/mmc/host/meson-gxbb.c
@@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct meson_host *host = mmc_priv(mmc);
- struct mmc_command *cmd = host->cmd;
WARN_ON(host->mrq != mrq);
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MMC: meson: remove unused variable
2016-09-15 15:43 ` Arnd Bergmann
(?)
@ 2016-09-15 16:37 ` Kevin Hilman
-1 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2016-09-15 16:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Carlo Caione, linux-mmc, linux-arm-kernel,
linux-amlogic, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
kbuild test robot reported this also, so I already fixed it for linux-next.
Kevin
> ---
> drivers/mmc/host/meson-gxbb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> {
> struct meson_host *host = mmc_priv(mmc);
> - struct mmc_command *cmd = host->cmd;
>
> WARN_ON(host->mrq != mrq);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] MMC: meson: remove unused variable
@ 2016-09-15 16:37 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2016-09-15 16:37 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
kbuild test robot reported this also, so I already fixed it for linux-next.
Kevin
> ---
> drivers/mmc/host/meson-gxbb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> {
> struct meson_host *host = mmc_priv(mmc);
> - struct mmc_command *cmd = host->cmd;
>
> WARN_ON(host->mrq != mrq);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] MMC: meson: remove unused variable
@ 2016-09-15 16:37 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2016-09-15 16:37 UTC (permalink / raw)
To: linus-amlogic
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")
kbuild test robot reported this also, so I already fixed it for linux-next.
Kevin
> ---
> drivers/mmc/host/meson-gxbb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> {
> struct meson_host *host = mmc_priv(mmc);
> - struct mmc_command *cmd = host->cmd;
>
> WARN_ON(host->mrq != mrq);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-15 16:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 15:43 [PATCH] MMC: meson: remove unused variable Arnd Bergmann
2016-09-15 15:43 ` Arnd Bergmann
2016-09-15 15:43 ` Arnd Bergmann
2016-09-15 16:37 ` Kevin Hilman
2016-09-15 16:37 ` Kevin Hilman
2016-09-15 16:37 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.