From: Kevin Hilman <khilman@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Kukjin Kim <kgene@kernel.org>, Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Tyler Baker <tyler.baker@linaro.org>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc\@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend
Date: Tue, 31 Mar 2015 14:02:04 -0700 [thread overview]
Message-ID: <7hiodg98z7.fsf@deeprootsystems.com> (raw)
In-Reply-To: <551976F1.1000605@collabora.co.uk> (Javier Martinez Canillas's message of "Mon, 30 Mar 2015 18:16:49 +0200")
Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:
[...]
> Unfortunately I don't fully understand why this clock needs to be
> enabled. It would be good if someone at Samsung can explain in more
> detail what the real problem really is.
+1
Maybe Abhilash can shed some light here?
We really should know *why* this is needed because having the fix in the
clock driver just doesn't seem right. It seems like the DMA driver
should be managing this clock.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Kukjin Kim <kgene@kernel.org>, Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Tyler Baker <tyler.baker@linaro.org>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend
Date: Tue, 31 Mar 2015 14:02:04 -0700 [thread overview]
Message-ID: <7hiodg98z7.fsf@deeprootsystems.com> (raw)
In-Reply-To: <551976F1.1000605@collabora.co.uk> (Javier Martinez Canillas's message of "Mon, 30 Mar 2015 18:16:49 +0200")
Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:
[...]
> Unfortunately I don't fully understand why this clock needs to be
> enabled. It would be good if someone at Samsung can explain in more
> detail what the real problem really is.
+1
Maybe Abhilash can shed some light here?
We really should know *why* this is needed because having the fix in the
clock driver just doesn't seem right. It seems like the DMA driver
should be managing this clock.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend
Date: Tue, 31 Mar 2015 14:02:04 -0700 [thread overview]
Message-ID: <7hiodg98z7.fsf@deeprootsystems.com> (raw)
In-Reply-To: <551976F1.1000605@collabora.co.uk> (Javier Martinez Canillas's message of "Mon, 30 Mar 2015 18:16:49 +0200")
Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:
[...]
> Unfortunately I don't fully understand why this clock needs to be
> enabled. It would be good if someone at Samsung can explain in more
> detail what the real problem really is.
+1
Maybe Abhilash can shed some light here?
We really should know *why* this is needed because having the fix in the
clock driver just doesn't seem right. It seems like the DMA driver
should be managing this clock.
Kevin
next prev parent reply other threads:[~2015-03-31 21:02 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 15:53 [RFC PATCH v3 0/2] ARM: EXYNOS: Fix Suspend-to-RAM on Exynos5420 Javier Martinez Canillas
2015-03-30 15:53 ` Javier Martinez Canillas
2015-03-30 15:53 ` [RFC PATCH v3 1/2] clk: samsung: Add a clock lookup function Javier Martinez Canillas
2015-03-30 15:53 ` Javier Martinez Canillas
2015-03-30 16:02 ` Tomasz Figa
2015-03-30 16:02 ` Tomasz Figa
2015-03-30 16:02 ` Tomasz Figa
2015-03-30 16:08 ` Javier Martinez Canillas
2015-03-30 16:08 ` Javier Martinez Canillas
2015-03-30 16:08 ` Javier Martinez Canillas
2015-03-31 1:40 ` Michael Turquette
2015-03-31 1:40 ` Michael Turquette
2015-03-31 1:40 ` Michael Turquette
2015-03-31 8:59 ` Javier Martinez Canillas
2015-03-31 8:59 ` Javier Martinez Canillas
2015-03-31 8:59 ` Javier Martinez Canillas
2015-04-01 1:29 ` Michael Turquette
2015-04-01 1:29 ` Michael Turquette
2015-04-01 1:29 ` Michael Turquette
2015-04-01 8:26 ` Javier Martinez Canillas
2015-04-01 8:26 ` Javier Martinez Canillas
2015-04-01 8:26 ` Javier Martinez Canillas
2015-03-30 15:53 ` [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend Javier Martinez Canillas
2015-03-30 15:53 ` Javier Martinez Canillas
2015-03-30 16:07 ` Tomasz Figa
2015-03-30 16:07 ` Tomasz Figa
2015-03-30 16:07 ` Tomasz Figa
2015-03-30 16:16 ` Javier Martinez Canillas
2015-03-30 16:16 ` Javier Martinez Canillas
2015-03-30 16:16 ` Javier Martinez Canillas
[not found] ` <CAM4voanL3A=dS8Z-ovi_-EDi9ctyaxZkvjajp+3ZjyNAnqR1aQ@mail.gmail.com>
2015-03-31 20:00 ` Javier Martinez Canillas
2015-03-31 20:00 ` Javier Martinez Canillas
2015-03-31 20:00 ` Javier Martinez Canillas
2015-04-01 11:03 ` Sylwester Nawrocki
2015-04-01 11:03 ` Sylwester Nawrocki
2015-04-01 11:03 ` Sylwester Nawrocki
2015-04-01 11:44 ` Javier Martinez Canillas
2015-04-01 11:44 ` Javier Martinez Canillas
2015-04-01 11:44 ` Javier Martinez Canillas
2015-04-01 17:31 ` Sylwester Nawrocki
2015-04-01 17:31 ` Sylwester Nawrocki
2015-04-01 17:31 ` Sylwester Nawrocki
2015-04-01 22:31 ` Javier Martinez Canillas
2015-04-01 22:31 ` Javier Martinez Canillas
2015-04-01 22:31 ` Javier Martinez Canillas
2015-04-02 12:22 ` Abhilash Kesavan
2015-04-02 12:22 ` Abhilash Kesavan
2015-04-02 12:22 ` Abhilash Kesavan
2015-04-07 10:59 ` Javier Martinez Canillas
2015-04-07 10:59 ` Javier Martinez Canillas
2015-04-07 10:59 ` Javier Martinez Canillas
2015-04-07 11:56 ` Javier Martinez Canillas
2015-04-07 11:56 ` Javier Martinez Canillas
2015-04-07 11:56 ` Javier Martinez Canillas
2015-04-07 12:46 ` Tomasz Figa
2015-04-07 12:46 ` Tomasz Figa
2015-04-07 12:46 ` Tomasz Figa
2015-04-07 14:11 ` Javier Martinez Canillas
2015-04-07 14:11 ` Javier Martinez Canillas
2015-04-07 14:11 ` Javier Martinez Canillas
2015-04-07 14:38 ` Abhilash Kesavan
2015-04-07 14:38 ` Abhilash Kesavan
2015-04-07 14:38 ` Abhilash Kesavan
2015-04-07 15:00 ` Javier Martinez Canillas
2015-04-07 15:00 ` Javier Martinez Canillas
2015-04-07 15:00 ` Javier Martinez Canillas
2015-04-08 1:50 ` Abhilash Kesavan
2015-04-08 1:50 ` Abhilash Kesavan
2015-04-08 1:50 ` Abhilash Kesavan
2015-04-07 18:51 ` Kevin Hilman
2015-04-07 18:51 ` Kevin Hilman
2015-04-07 18:51 ` Kevin Hilman
2015-04-07 21:28 ` Tomasz Figa
2015-04-07 21:28 ` Tomasz Figa
2015-04-07 21:28 ` Tomasz Figa
2015-04-08 5:36 ` Javier Martinez Canillas
2015-04-08 5:36 ` Javier Martinez Canillas
2015-04-08 5:36 ` Javier Martinez Canillas
2015-04-07 14:11 ` Abhilash Kesavan
2015-04-07 14:11 ` Abhilash Kesavan
2015-04-07 14:11 ` Abhilash Kesavan
2015-04-07 14:26 ` Javier Martinez Canillas
2015-04-07 14:26 ` Javier Martinez Canillas
2015-04-07 14:26 ` Javier Martinez Canillas
2015-03-31 21:02 ` Kevin Hilman [this message]
2015-03-31 21:02 ` Kevin Hilman
2015-03-31 21:02 ` Kevin Hilman
2015-04-01 3:19 ` Abhilash Kesavan
2015-04-01 3:19 ` Abhilash Kesavan
2015-04-01 3:19 ` Abhilash Kesavan
2015-04-01 4:03 ` Kevin Hilman
2015-04-01 4:03 ` Kevin Hilman
2015-04-01 4:03 ` Kevin Hilman
2015-04-01 9:16 ` Krzysztof Kozlowski
2015-04-01 9:16 ` Krzysztof Kozlowski
2015-04-01 9:16 ` Krzysztof Kozlowski
2015-04-01 19:02 ` Michael Turquette
2015-04-01 19:02 ` Michael Turquette
2015-04-01 19:02 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hiodg98z7.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.