All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-amlogic@lists.infradead.org, ayan.halder@arm.com,
	linux-arm-kernel@lists.infradead.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v3 8/9] drm/meson: hold 32 lines after vsync to give time for AFBC start
Date: Mon, 09 Dec 2019 14:07:51 -0800	[thread overview]
Message-ID: <7hmuc1rw3s.fsf@baylibre.com> (raw)
In-Reply-To: <20191021091509.3864-9-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> When using an AFBC encoded frame, the AFBC Decoder must be resetted,

minor grammar nit: s/resetted/reset/

> configured and enabled at each vsync IRQ.
>
> To leave time for that, use the maximum lines hold time to give time
> for AFBC setup and avoid visual glitches.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

otherwise...

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-amlogic@lists.infradead.org, ayan.halder@arm.com,
	linux-arm-kernel@lists.infradead.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v3 8/9] drm/meson: hold 32 lines after vsync to give time for AFBC start
Date: Mon, 09 Dec 2019 14:07:51 -0800	[thread overview]
Message-ID: <7hmuc1rw3s.fsf@baylibre.com> (raw)
In-Reply-To: <20191021091509.3864-9-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> When using an AFBC encoded frame, the AFBC Decoder must be resetted,

minor grammar nit: s/resetted/reset/

> configured and enabled at each vsync IRQ.
>
> To leave time for that, use the maximum lines hold time to give time
> for AFBC setup and avoid visual glitches.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

otherwise...

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-amlogic@lists.infradead.org, ayan.halder@arm.com,
	linux-arm-kernel@lists.infradead.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v3 8/9] drm/meson: hold 32 lines after vsync to give time for AFBC start
Date: Mon, 09 Dec 2019 14:07:51 -0800	[thread overview]
Message-ID: <7hmuc1rw3s.fsf@baylibre.com> (raw)
In-Reply-To: <20191021091509.3864-9-narmstrong@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> When using an AFBC encoded frame, the AFBC Decoder must be resetted,

minor grammar nit: s/resetted/reset/

> configured and enabled at each vsync IRQ.
>
> To leave time for that, use the maximum lines hold time to give time
> for AFBC setup and avoid visual glitches.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

otherwise...

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2019-12-09 22:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21  9:15 [PATCH v3 0/9] drm/meson: add AFBC support Neil Armstrong
2019-10-21  9:15 ` Neil Armstrong
2019-10-21  9:15 ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 1/9] drm/meson: add AFBC decoder registers for GXM and G12A Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 2/9] drm/meson: add RDMA register bits defines Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 3/9] drm/meson: store the framebuffer width for plane commit Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 4/9] drm/meson: add RDMA module driver Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 5/9] drm/meson: Add AFBCD " Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 6/9] drm/meson: plane: add support for AFBC mode for OSD1 plane Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 7/9] drm/meson: viu: add AFBC modules routing functions Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15 ` [PATCH v3 8/9] drm/meson: hold 32 lines after vsync to give time for AFBC start Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-12-09 22:07   ` Kevin Hilman [this message]
2019-12-09 22:07     ` Kevin Hilman
2019-12-09 22:07     ` Kevin Hilman
2019-10-21  9:15 ` [PATCH v3 9/9] drm/meson: crtc: add OSD1 plane AFBC commit Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-10-21  9:15   ` Neil Armstrong
2019-12-09 22:09 ` [PATCH v3 0/9] drm/meson: add AFBC support Kevin Hilman
2019-12-09 22:09   ` Kevin Hilman
2019-12-09 22:09   ` Kevin Hilman
2019-12-10 11:01   ` Neil Armstrong
2019-12-10 11:01     ` Neil Armstrong
2019-12-10 11:01     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hmuc1rw3s.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=ayan.halder@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.