All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM64: dts: meson-gxl: fix Mali GPU compatible string
@ 2018-06-23 15:00 Martin Blumenstingl
  2018-06-26  8:06 ` Neil Armstrong
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Blumenstingl @ 2018-06-23 15:00 UTC (permalink / raw)
  To: linus-amlogic

meson-gxl-mali.dtsi is only used on GXL SoCs. Thus it should use the GXL
specific compatible string instead of the GXBB one.
For now this is purely cosmetic since the (out-of-tree) lima driver for
this GPU currently uses the "arm,mali-450" match instead of the SoC
specific one. However, update the .dts to match the documentation since
this driver behavior might change in the future.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
index eb327664a4d8..6aaafff674f9 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
@@ -6,7 +6,7 @@
 
 &apb {
 	mali: gpu at c0000 {
-		compatible = "amlogic,meson-gxbb-mali", "arm,mali-450";
+		compatible = "amlogic,meson-gxl-mali", "arm,mali-450";
 		reg = <0x0 0xc0000 0x0 0x40000>;
 		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM64: dts: meson-gxl: fix Mali GPU compatible string
  2018-06-23 15:00 [PATCH] ARM64: dts: meson-gxl: fix Mali GPU compatible string Martin Blumenstingl
@ 2018-06-26  8:06 ` Neil Armstrong
  2018-06-27 23:42   ` Kevin Hilman
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2018-06-26  8:06 UTC (permalink / raw)
  To: linus-amlogic

On 23/06/2018 17:00, Martin Blumenstingl wrote:
> meson-gxl-mali.dtsi is only used on GXL SoCs. Thus it should use the GXL
> specific compatible string instead of the GXBB one.
> For now this is purely cosmetic since the (out-of-tree) lima driver for
> this GPU currently uses the "arm,mali-450" match instead of the SoC
> specific one. However, update the .dts to match the documentation since
> this driver behavior might change in the future.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
> index eb327664a4d8..6aaafff674f9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
> @@ -6,7 +6,7 @@
>  
>  &apb {
>  	mali: gpu at c0000 {
> -		compatible = "amlogic,meson-gxbb-mali", "arm,mali-450";
> +		compatible = "amlogic,meson-gxl-mali", "arm,mali-450";
>  		reg = <0x0 0xc0000 0x0 0x40000>;
>  		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
>  			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
> 
[...]
Acked-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM64: dts: meson-gxl: fix Mali GPU compatible string
  2018-06-26  8:06 ` Neil Armstrong
@ 2018-06-27 23:42   ` Kevin Hilman
  0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2018-06-27 23:42 UTC (permalink / raw)
  To: linus-amlogic

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 23/06/2018 17:00, Martin Blumenstingl wrote:
>> meson-gxl-mali.dtsi is only used on GXL SoCs. Thus it should use the GXL
>> specific compatible string instead of the GXBB one.
>> For now this is purely cosmetic since the (out-of-tree) lima driver for
>> this GPU currently uses the "arm,mali-450" match instead of the SoC
>> specific one. However, update the .dts to match the documentation since
>> this driver behavior might change in the future.
>> 
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
>> index eb327664a4d8..6aaafff674f9 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi
>> @@ -6,7 +6,7 @@
>>  
>>  &apb {
>>  	mali: gpu at c0000 {
>> -		compatible = "amlogic,meson-gxbb-mali", "arm,mali-450";
>> +		compatible = "amlogic,meson-gxl-mali", "arm,mali-450";
>>  		reg = <0x0 0xc0000 0x0 0x40000>;
>>  		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
>>  			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
>> 
> [...]
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Applied to v4.18/fixes (which I'll be submitting today.)

Kevin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-27 23:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-23 15:00 [PATCH] ARM64: dts: meson-gxl: fix Mali GPU compatible string Martin Blumenstingl
2018-06-26  8:06 ` Neil Armstrong
2018-06-27 23:42   ` Kevin Hilman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.