From: Kevin Hilman <khilman@baylibre.com> To: Jerome NEANNE <jneanne@baylibre.com>, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, will@kernel.org, lee.jones@linaro.org, jneanne@baylibre.com Cc: narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 2/5] mfd: drivers: Add TI TPS65219 PMIC support Date: Tue, 14 Jun 2022 14:03:46 -0700 [thread overview] Message-ID: <7hy1xznej1.fsf@baylibre.com> (raw) In-Reply-To: <20220613090604.9975-3-jneanne@baylibre.com> Jerome NEANNE <jneanne@baylibre.com> writes: > The TPS65219 is a power management IC PMIC designed > to supply a wide range of SoCs > in both portable and stationary applications. > Any SoC can control TPS65219 over a standard I2C interface. > > It contains the following components: > - Regulators. > - Over Temperature warning and Shut down. > - GPIOs > - Multi Function Pins (MFP) > > This patch adds support for tps65219 mfd device. At this time only > the functionalities listed below are made available: > > - Regulators probe and functionalities > - warm and cold reset support > - SW shutdown support > > Signed-off-by: Jerome NEANNE <jneanne@baylibre.com> [...] > +/** > + * pmic_rst_restart: trig tps65219 reset to SOC. > + * > + * Trigged via notifier > + */ > +static int pmic_rst_restart(struct notifier_block *this, > + unsigned long mode, void *cmd) > +{ > + struct tps65219 *tps; > + > + tps = container_of(this, struct tps65219, nb); > + if (tps != NULL) { > + if (WARMNCOLD) This value is hard-coded to 1 in the header, so war reset will always be done. > + tps65219_warm_reset(tps); > + else > + tps65219_cold_reset(tps); Doesn't the reboot_notifier get a value like REBOOT_WARM, REBOOT_COLD etc (c.f. enum in linux/reboot.h) so you could properly select? Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com> To: Jerome NEANNE <jneanne@baylibre.com>, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, will@kernel.org, lee.jones@linaro.org, jneanne@baylibre.com Cc: narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 2/5] mfd: drivers: Add TI TPS65219 PMIC support Date: Tue, 14 Jun 2022 14:03:46 -0700 [thread overview] Message-ID: <7hy1xznej1.fsf@baylibre.com> (raw) In-Reply-To: <20220613090604.9975-3-jneanne@baylibre.com> Jerome NEANNE <jneanne@baylibre.com> writes: > The TPS65219 is a power management IC PMIC designed > to supply a wide range of SoCs > in both portable and stationary applications. > Any SoC can control TPS65219 over a standard I2C interface. > > It contains the following components: > - Regulators. > - Over Temperature warning and Shut down. > - GPIOs > - Multi Function Pins (MFP) > > This patch adds support for tps65219 mfd device. At this time only > the functionalities listed below are made available: > > - Regulators probe and functionalities > - warm and cold reset support > - SW shutdown support > > Signed-off-by: Jerome NEANNE <jneanne@baylibre.com> [...] > +/** > + * pmic_rst_restart: trig tps65219 reset to SOC. > + * > + * Trigged via notifier > + */ > +static int pmic_rst_restart(struct notifier_block *this, > + unsigned long mode, void *cmd) > +{ > + struct tps65219 *tps; > + > + tps = container_of(this, struct tps65219, nb); > + if (tps != NULL) { > + if (WARMNCOLD) This value is hard-coded to 1 in the header, so war reset will always be done. > + tps65219_warm_reset(tps); > + else > + tps65219_cold_reset(tps); Doesn't the reboot_notifier get a value like REBOOT_WARM, REBOOT_COLD etc (c.f. enum in linux/reboot.h) so you could properly select? Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-14 21:03 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-13 9:05 [RFC PATCH 0/5] Add TI TPS65219 PMIC support for AM642 SK board Jerome NEANNE 2022-06-13 9:05 ` Jerome NEANNE 2022-06-13 9:06 ` [RFC PATCH 1/5] regulator: dt-bindings: Add TI TPS65219 PMIC bindings Jerome NEANNE 2022-06-13 9:06 ` Jerome NEANNE 2022-06-16 17:52 ` Rob Herring 2022-06-16 17:52 ` Rob Herring 2022-06-13 9:06 ` [RFC PATCH 2/5] mfd: drivers: Add TI TPS65219 PMIC support Jerome NEANNE 2022-06-13 9:06 ` Jerome NEANNE 2022-06-13 12:57 ` Mark Brown 2022-06-13 12:57 ` Mark Brown 2022-06-14 21:03 ` Kevin Hilman [this message] 2022-06-14 21:03 ` Kevin Hilman 2022-06-13 9:06 ` [RFC PATCH 3/5] regulator: drivers: Add TI TPS65219 PMIC regulators support Jerome NEANNE 2022-06-13 9:06 ` Jerome NEANNE 2022-06-13 13:04 ` Mark Brown 2022-06-13 13:04 ` Mark Brown 2022-06-13 9:06 ` [RFC PATCH 4/5] arm64: Kconfig: Introduce CONFIG_MFD_TPS65219 and CONFIG_REGULATOR_TPS65219 Jerome NEANNE 2022-06-13 9:06 ` Jerome NEANNE 2022-06-13 9:06 ` [RFC PATCH 5/5] arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board Jerome NEANNE 2022-06-13 9:06 ` Jerome NEANNE 2022-06-13 13:06 ` Mark Brown 2022-06-13 13:06 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7hy1xznej1.fsf@baylibre.com \ --to=khilman@baylibre.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=j-keerthy@ti.com \ --cc=jneanne@baylibre.com \ --cc=kristo@kernel.org \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=msp@baylibre.com \ --cc=narmstrong@baylibre.com \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.