* [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL
@ 2009-04-23 5:42 Junio C Hamano
2009-04-23 11:17 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2009-04-23 5:42 UTC (permalink / raw)
To: Jeff King; +Cc: git, Robin H. Johnson
The install target still descends into perl subdirectory when NO_PERL is
requested. Fix this.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* I think the very original from Robin had this exclusion, but somehow it
seems to have got lost. Right now, perl/Makefile does not do anything
that depends on having perl, but I think we do not have/need to rely on
that.
Makefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 49f36f5..6f602c7 100644
--- a/Makefile
+++ b/Makefile
@@ -1529,7 +1529,9 @@ install: all
$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
$(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X git-cvsserver '$(DESTDIR_SQ)$(bindir_SQ)'
$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
+ifndef NO_PERL
$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
+endif
ifndef NO_TCLTK
$(MAKE) -C gitk-git install
$(MAKE) -C git-gui gitexecdir='$(gitexec_instdir_SQ)' install
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL
2009-04-23 5:42 [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL Junio C Hamano
@ 2009-04-23 11:17 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2009-04-23 11:17 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Robin H. Johnson
On Wed, Apr 22, 2009 at 10:42:28PM -0700, Junio C Hamano wrote:
> The install target still descends into perl subdirectory when NO_PERL is
> requested. Fix this.
Oops, good catch.
Acked-by: Jeff King <peff@peff.net>
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-23 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-23 5:42 [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL Junio C Hamano
2009-04-23 11:17 ` Jeff King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.