* What's cooking in git.git (May 2013, #08; Tue, 28)
@ 2013-05-28 21:54 Junio C Hamano
2013-05-29 2:55 ` Felipe Contreras
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Junio C Hamano @ 2013-05-28 21:54 UTC (permalink / raw)
To: git
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
There are topics that are still in 'next', not because they needed
more testing, but only because we already were in the -rc period.
Now that 1.8.3 is out, we will start merging them to 'master' (and
some to 'maint' for 1.8.3.1) probably tomorrow (i.e. after waiting
for a few days to make sure we can have a clean start of the post
1.8.3 maint branch with brown paper bag fixes and nothing else).
The post 1.8.3 cycle will start early next month, at which time the
'next' branch will be rewound and rebuilt. Until then, I expect
that my patch queue may stay slow and leaky while I take a bit of
break.
You can find the changes described here in the integration branches
of the repositories listed at
http://git-blame.blogspot.com/p/git-public-repositories.html
--------------------------------------------------
[New Topics]
* nd/urls-doc-no-file-hyperlink-fix (2013-05-24) 1 commit
- urls.txt: avoid auto converting to hyperlink
Will merge to 'next'.
* cb/log-follow-with-combined (2013-05-28) 1 commit
- fix segfault with git log -c --follow
Will merge to 'next'.
* fc/cleanups (2013-05-28) 3 commits
- test: rebase: fix --interactive test
- test: trivial cleanups
- remote: trivial style cleanup
Will merge to 'next'.
* fc/makefile (2013-05-26) 5 commits
- build: do not install git-remote-testpy
- build: add NO_INSTALL variable
- build: cleanup using $<
- build: cleanup using $^
- build: trivial simplification
(this branch is used by fc/remote-helpers-use-specified-python.)
Will merge to 'next'.
* fc/remote-helpers-use-specified-python (2013-05-28) 4 commits
- remote-helpers: add exec-path links
- remote-helpers: allow direct test execution
- remote-helpers: rename tests
- remote-helpers: generate scripts
(this branch uses fc/makefile.)
I do not particularly think the second from the bottom is a good
change, but it takes the remainder of the series hostage.
Will hopefully be rerolled without it.
* fc/send-email-chainreplyto-warning (2013-05-28) 1 commit
- send-email: remove warning about unset chainreplyto
An overdue removal od "behaviour changed at 1.7.0; if you were
living in a cave, here is what you can adjust to it" message.
Will merge to 'next'.
* ks/difftool-dirdiff-copy-all (2013-05-28) 1 commit
- difftool --dir-diff: always use identical working tree file
"difftool --dir-diff" populates a temporary directory with files,
inviting the user to modify them in place, but in some cases we
weren't expecting the user to modify them and did not take the
change back to the working tree.
The log message has room for clarification, but the change looked
sane.
* nd/prune-packed-dryrun-verbose (2013-05-28) 1 commit
- prune-packed: avoid implying "1" is DRY_RUN in prune_packed_objects()
Will merge to 'next'.
* rj/mingw-compat-st-mode-bits (2013-05-28) 1 commit
- path: Fix a sparse warning
Will merge to 'next'.
* rs/commit-m-no-edit (2013-05-28) 1 commit
- commit: don't start editor if empty message is given with -m
Will merge to 'next'.
* xq/credential-osxkeychain (2013-05-28) 1 commit
- credential-osxkeychain: support more protocols
Will merge to 'next'.
* jc/core-checkstat (2013-05-06) 1 commit
- deprecate core.statinfo at Git 2.0 boundary
(this branch is used by jc/core-checkstat-2.0.)
Will merge to 'next'.
--------------------------------------------------
[Stalled]
* rr/rebase-autostash (2013-05-12) 7 commits
- rebase: implement --[no-]autostash and rebase.autostash
- rebase --merge: return control to caller, for housekeeping
- rebase -i: return control to caller, for housekeeping
- am: return control to caller, for housekeeping
- rebase: prepare to do generic housekeeping
- rebase -i: don't error out if $state_dir already exists
- am: tighten a conditional that checks for $dotest
This is from v3, but after a "Fixed" message in $gmane/224111 we
haven't seen a reroll yet. Also there was an attempt for a
follow-up, but it was never completed.
* rj/mingw-cygwin (2013-05-08) 2 commits
- cygwin: Remove the CYGWIN_V15_WIN32API build variable
- mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIVE
Update build for Cygwin 1.[57]. There seems to have been some
discussion but did anything concrete come out of it???
* mh/multimail (2013-04-21) 1 commit
- git-multimail: a replacement for post-receive-email
Waiting for the initial history to pull from.
$gmane/223564
* jc/format-patch (2013-04-22) 2 commits
- format-patch: --inline-single
- format-patch: rename "no_inline" field
A new option to send a single patch to the standard output to be
appended at the bottom of a message. I personally have no need for
this, but it was easy enough to cobble together. Tests, docs and
stripping out more MIMEy stuff are left as exercises to interested
parties.
Not ready for inclusion.
* jk/gitweb-utf8 (2013-04-08) 4 commits
- gitweb: Fix broken blob action parameters on blob/commitdiff pages
- gitweb: Don't append ';js=(0|1)' to external links
- gitweb: Make feed title valid utf8
- gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch
Various fixes to gitweb.
Waiting for a reroll after a review.
* jk/commit-info-slab (2013-04-19) 3 commits
- commit-slab: introduce a macro to define a slab for new type
- commit-slab: avoid large realloc
- commit: allow associating auxiliary info on-demand
(this branch is used by jc/show-branch.)
Technology demonstration to show a way we could use unbound number
of flag bits on commit objects.
--------------------------------------------------
[Cooking]
* tr/line-log (2013-04-22) 13 commits
(merged to 'next' on 2013-04-22 at 8f2c1de)
+ git-log(1): remove --full-line-diff description
(merged to 'next' on 2013-04-21 at cd92620)
+ line-log: fix documentation formatting
(merged to 'next' on 2013-04-15 at 504559e)
+ log -L: improve comments in process_all_files()
+ log -L: store the path instead of a diff_filespec
+ log -L: test merge of parallel modify/rename
+ t4211: pass -M to 'git log -M -L...' test
(merged to 'next' on 2013-04-05 at 5afb00c)
+ log -L: fix overlapping input ranges
+ log -L: check range set invariants when we look it up
(merged to 'next' on 2013-04-01 at 5be920c)
+ Speed up log -L... -M
+ log -L: :pattern:file syntax to find by funcname
+ Implement line-history search (git log -L)
+ Export rewrite_parents() for 'log -L'
+ Refactor parse_loc
Will merge to 'master'.
* jn/config-ignore-inaccessible (2013-04-15) 1 commit
(merged to 'next' on 2013-05-07 at 4f09e24)
+ config: allow inaccessible configuration under $HOME
When $HOME is misconfigured to point at an unreadable directory, we
used to complain and die. This loosens the check.
Will merge to 'master'.
* mh/reflife (2013-05-28) 25 commits
- refs: document the lifetime of the args passed to each_ref_fn
- register_ref(): make a copy of the bad reference SHA-1
- exclude_existing(): set existing_refs.strdup_strings
- string_list_add_refs_by_glob(): add a comment about memory management
- string_list_add_one_ref(): rename first parameter to "refname"
- show_head_ref(): rename first parameter to "refname"
- show_head_ref(): do not shadow name of argument
- add_existing(): do not retain a reference to sha1
- do_fetch(): clean up existing_refs before exiting
- do_fetch(): reduce scope of peer_item
- object_array_entry: fix memory handling of the name field
- find_first_merges(): remove unnecessary code
- find_first_merges(): initialize merges variable using initializer
- fsck: don't put a void*-shaped peg in a char*-shaped hole
- object_array_remove_duplicates(): rewrite to reduce copying
- revision: use object_array_filter() in implementation of gc_boundary()
- object_array: add function object_array_filter()
- revision: split some overly-long lines
- cmd_diff(): make it obvious which cases are exclusive of each other
- cmd_diff(): rename local variable "list" -> "entry"
- cmd_diff(): use an object_array for holding trees
- builtin_diff_tree(): make it obvious that function wants two entries
- add_rev_cmdline(): make a copy of the name argument
- fetch: make own copies of refnames
- describe: make own copy of refname
Define memory ownership and lifetime rules for what for-each-ref
feeds to its callbacks (in short, "you do not own it, so make a
copy if you want to keep it").
* th/bisect-skip-report-range-fix (2013-05-22) 1 commit
- bisect: Fix log output for multi-parent skip ranges
Fix for an additional bisect log comments.
Will merge to 'next'.
* mm/mediawiki-https-fail-message (2013-05-23) 1 commit
- git-remote-mediawiki: better error message when HTTP(S) access fails
Hint users when https:// connection failed to check the
certificate; it is a good hint if we assumie that it is common
error for the end users to make.
Still under discussion.
$gmane/225678
* tg/maint-zsh-svn-remote-prompt (2013-05-22) 1 commit
- prompt: fix show upstream with svn and zsh
zsh prompt script that borrowed from bash prompt script did not
work due to slight differences in array variable notation between
these two shells.
Will merge to 'next'.
* tr/push-no-verify-doc (2013-05-23) 1 commit
- Document push --no-verify
"git push --[no-]verify" was not documented.
Will merge to 'next'.
* dm/unbash-subtree (2013-05-21) 1 commit
- contrib/git-subtree: Use /bin/sh interpreter instead of /bin/bash
It turns out that git-subtree script does not have to be run with
bash.
Will merge to 'next'.
* fc/transport-helper-no-refspec (2013-05-21) 2 commits
- transport-helper: check if the dry-run is supported
- transport-helper: barf when user tries old:new
With "export" remote-helper protocol, (1) a push that tries to
update a remote ref whose name is different from the pushing side
does not work yet, and (2) the helper may not know how to do
--dry-run, so detect such problematic cases and disable them for
now.
Will merge to 'next'.
* rr/die-on-missing-upstream (2013-05-22) 2 commits
- sha1_name: fix error message for @{<N>}, @{<date>}
- sha1_name: fix error message for @{u}
When a reflog notation is used for implicit "current branch", we
did not say which branch and worse said "branch ''".
Waiting for series of rerolls to settle.
* jc/show-branch (2013-05-21) 5 commits
- show-branch: use commit slab to represent bitflags of arbitrary width
- show-branch.c: remove "all_mask"
- show-branch.c: abstract out "flags" operation
- show-branch.c: lift all_mask/all_revs to a global static
- show-branch.c: update comment style
(this branch uses jk/commit-info-slab.)
Waiting for the final step to lift the hard-limit before sending it out.
* fc/remote-bzr (2013-05-28) 8 commits
- remote-bzr: add fallback check for a partial clone
- remote-bzr: reorganize the way 'wanted' works
- remote-bzr: trivial cleanups
- remote-bzr: change global repo
- remote-bzr: delay cloning/pulling
- remote-bzr: simplify get_remote_branch()
- remote-bzr: fix for files with spaces
- remote-bzr: recover from failed clones
The ones near the tip conflicted with the hotfix for 1.8.3 so I
discarded them for now.
Will merge to 'next'?
* jx/clean-interactive (2013-05-22) 15 commits
- test: add t7301 for git-clean--interactive
- git-clean: add documentation for interactive git-clean
- git-clean: add ask each interactive action
- git-clean: add select by numbers interactive action
- git-clean: add filter by pattern interactive action
- git-clean: use a git-add-interactive compatible UI
- git-clean: add colors to interactive git-clean
- git-clean: show items of del_list in columns
- git-clean: add support for -i/--interactive
- git-clean: refactor git-clean into two phases
- Refactor write_name_quoted_relative, remove unused params
- Refactor quote_path_relative, remove unused params
- quote.c: remove path_relative, use relative_path instead
- path.c: refactor relative_path(), not only strip prefix
- test: add test cases for relative_path
Still under discussion, e.g. $gmane/225139.
* tr/test-v-and-v-subtest-only (2013-05-16) 6 commits
- test-lib: support running tests under valgrind in parallel
- test-lib: allow prefixing a custom string before "ok N" etc.
- test-lib: valgrind for only tests matching a pattern
- test-lib: verbose mode for only tests matching a pattern
- test-lib: refactor $GIT_SKIP_TESTS matching
- test-lib: enable MALLOC_* for the actual tests
Allows N instances of tests run in parallel, each running 1/N parts
of the test suite under Valgrind, to speed things up.
The tip one may be useful in practice but is a tad ugly ;-)
Will merge to 'next'.
* rh/merge-options-doc-fix (2013-05-16) 1 commit
(merged to 'next' on 2013-05-21 at f76baf3)
+ Documentation/merge-options.txt: restore `-e` option
Will merge to 'master'.
* rr/zsh-color-prompt (2013-05-17) 3 commits
- prompt: colorize ZSH prompt
- prompt: factor out gitstring coloring logic
- prompt: introduce GIT_PS1_STATESEPARATOR
Will merge to 'next'.
* an/diff-index-doc (2013-05-20) 1 commit
(merged to 'next' on 2013-05-21 at 6e1459b)
+ Documentation/diff-index: mention two modes of operation
Will merge to 'master'.
* fc/contrib-related (2013-05-20) 1 commit
- Add new git-related helper to contrib
Waiting the design review for this earliest part to settle.
* mc/describe-first-parent (2013-05-20) 1 commit
(merged to 'next' on 2013-05-21 at 2e02ffc)
+ describe: Add --first-parent option
Will merge to 'master'.
* rs/tar-tests (2013-05-20) 6 commits
(merged to 'next' on 2013-05-21 at aed12a7)
+ t5000: test long filenames
+ t5000: simplify tar-tree tests
+ t5000: use check_tar for prefix test
+ t5000: factor out check_tar
+ t5000, t5003: create directories for extracted files lazily
+ t5000: integrate export-subst tests into regular tests
Will merge to 'master'.
* da/darwin (2013-05-21) 4 commits
(merged to 'next' on 2013-05-21 at 0497edb)
+ imap-send: eliminate HMAC deprecation warnings on Mac OS X
+ cache.h: eliminate SHA-1 deprecation warnings on Mac OS X
+ Makefile: add support for Apple CommonCrypto facility
+ Makefile: fix default regex settings on Darwin
Newer MacOS X encourages the programs to compile and link with
their CommonCrypto, not with OpenSSL.
Will merge to 'master'.
* fc/macos-x-clipped-write (2013-05-17) 1 commit
(merged to 'next' on 2013-05-21 at 510b0dd)
+ compate/clipped-write.c: large write(2) fails on Mac OS X/XNU
Mac OS X does not like to write(2) more than INT_MAX number of
bytes.
Will merge to 'master'.
* fc/remote-hg (2013-05-28) 50 commits
- remote-hg: add support for --force
- remote-hg: add support for --dry-run
- remote-hg: check if a fetch is needed
- remote-hg: trivial cleanup
- remote-helpers: improve marks usage
- remote-hg: add check_push() helper
- remote-hg: add setup_big_push() helper
- remote-hg: remove files before modifications
- remote-hg: improve lightweight tag author
- remote-hg: use remote 'default' not local one
- remote-hg: improve branch listing
- remote-hg: simplify branch_tip()
- remote-hg: check diverged bookmarks
- remote-hg: pass around revision refs
- remote-hg: implement custom checkheads()
- remote-hg: implement custom push()
- remote-hg: only update necessary revisions
- remote-hg: force remote bookmark push selectively
- remote-hg: reorganize bookmark handling
- remote-hg: add test for failed double push
- remote-hg: add test for big push
- remote-hg: add test for new bookmark special
- remote-hg: add test for bookmark diverge
- remote-hg: add test for diverged push
- remote-hg: add test to push new bookmark
- remote-hg: add remote tests
- remote-hg: update bookmarks when using a remote
- remote-hg: add check_bookmark() test helper
- remote-bzr: simplify test checks
- remote-hg: add tests for 'master' bookmark
- remote-hg: always point HEAD to master
- remote-hg: improve progress calculation
- remote-hg: trivial cleanups
- remote-hg: ensure remote rebasing works
- remote-hg: upgrade version 1 marks
- remote-hg: switch from revisions to SHA-1 noteids
- remote-hg: add version checks to the marks
- remote-hg: improve node traversing
- remote-hg: shuffle some code
- remote-hg: use a shared repository store
- remote-hg: load all extensions
- remote-hg: test: simplify previous branch checkout
- remote-helpers: test: simplify remote URLs
- remote-helpers: tests: general improvements
- remote-helpers: test: cleanup style
- remote-helpers: test: cleanup white-spaces
- remote-hg: trivial reorganization
- remote-hg: test: be a little more quiet
- remote-hg: tests: fix hg merge
- remote-helpers: tests: use python directly
Will merge to 'next'.
* hv/config-from-blob (2013-05-12) 5 commits
- do not die when error in config parsing of buf occurs
- teach config --blob option to parse config from database
- config: make parsing stack struct independent from actual data source
- config: drop cf validity check in get_next_char()
- config: factor out config file stack management
Will see a resubmit.
$gmane/223964
* jc/t5551-posix-sed-bre (2013-05-12) 1 commit
(merged to 'next' on 2013-05-21 at d597ca1)
+ t5551: do not use unportable sed '\+'
POSIX fix for a test script.
Will merge to 'master'.
* jk/fetch-always-update-tracking (2013-05-28) 5 commits
(merged to 'next' on 2013-05-28 at c6abf3f)
+ fetch: don't try to update unfetched tracking refs
(merged to 'next' on 2013-05-21 at f7e4b16)
+ fetch: opportunistically update tracking refs
+ refactor "ref->merge" flag
+ fetch/pull doc: untangle meaning of bare <ref>
+ t5510: start tracking-ref tests from a known state
"git fetch origin master" unlike "git fetch origin" or "git fetch"
does not update "refs/remotes/origin/master" and it was an early
design decision to keep the update of remote tracking branches
predictable, but in practice it turns out that people find it more
convenient to opportunisticly update them whenever we have a
chance, and we have been updating them when we run "git push" which
already breaks the original "predictability" anyway.
Will merge to 'master'.
* nd/clone-connectivity-shortcut (2013-05-28) 4 commits
- clone: open a shortcut for connectivity check
- index-pack: remove dead code (it should never happen)
- fetch-pack: prepare updated shallow file before fetching the pack
- clone: let the user know when check_everything_connected is run
Will merge to 'next'.
* kb/ancestry-path-threedots (2013-05-16) 2 commits
(merged to 'next' on 2013-05-21 at 5d75bd3)
+ revision.c: treat A...B merge bases as if manually specified
+ t6019: demonstrate --ancestry-path A...B breakage
(this branch is used by kb/full-history-compute-treesame-carefully-2.)
"git log --ancestry-path A...B" did not work as expected, as it did
not pay attention to the fact that the merge base between A and B
was the bottom of the range being specified.
Will merge to 'master'.
* kb/full-history-compute-treesame-carefully-2 (2013-05-16) 15 commits
- revision.c: make default history consider bottom commits
- revision.c: don't show all merges for --parents
- revision.c: discount side branches when computing TREESAME
- revision.c: add BOTTOM flag for commits
- simplify-merges: drop merge from irrelevant side branch
- simplify-merges: never remove all TREESAME parents
- t6012: update test for tweaked full-history traversal
- revision.c: Make --full-history consider more merges
- Documentation: avoid "uninteresting"
- rev-list-options.txt: correct TREESAME for P
- t6111: add parents to tests
- t6111: allow checking the parents as well
- t6111: new TREESAME test set
- t6019: test file dropped in -s ours merge
- decorate.c: compact table when growing
(this branch uses kb/ancestry-path-threedots.)
Major update to a very core part of the system to improve culling
of irrelevant parents while traversing a mergy history.
Will not be a 1.8.3 material, but is an important topic.
Will merge to 'next'.
* jc/strbuf-branchname-fix (2013-05-16) 1 commit
(merged to 'next' on 2013-05-21 at 5db8872)
+ strbuf_branchname(): do not double-expand @{-1}~22
"git merge @{-1}~22" was rewritten to "git merge frotz@{1}~22"
incorrectly when your previous branch was "frotz" (it should be
rewritten to "git merge frotz~22" instead).
Will merge to 'master'.
* mk/combine-diff-context-horizon-fix (2013-05-15) 1 commit
(merged to 'next' on 2013-05-21 at f462c02)
+ combine-diff.c: Fix output when changes are exactly 3 lines apart
"git diff -c -p" was not showing a deleted line from a hunk when
another hunk immediately begins where the earlier one ends.
Will merge to 'master'.
* mm/color-auto-default (2013-05-15) 2 commits
- make color.ui default to 'auto'
- config: refactor management of color.ui's default value
Flip the default for color.ui to 'auto', which is what many
tutorials recommend new users to do. The updated code claims the
switch happened at Git 2.0 in the past tense, but we might want to
expedite it, as this change is not all that important to deserve a
major version bump.
I'd vote for merging this without waiting for 2.0. Comments?
Waiting for a reroll.
* tr/coverage (2013-05-13) 4 commits
(merged to 'next' on 2013-05-21 at 8480007)
+ coverage: build coverage-untested-functions by default
+ coverage: set DEFAULT_TEST_TARGET to avoid using prove
+ coverage: do not delete .gcno files before building
+ coverage: split build target into compile and test
Update the test coverage support that was left to bitrot for some
time.
Will merge to 'master'.
* mg/more-textconv (2013-05-10) 7 commits
(merged to 'next' on 2013-05-21 at 701cdb7)
+ grep: honor --textconv for the case rev:path
+ grep: allow to use textconv filters
+ t7008: demonstrate behavior of grep with textconv
+ cat-file: do not die on --textconv without textconv filters
+ show: honor --textconv for blobs
+ diff_opt: track whether flags have been set explicitly
+ t4030: demonstrate behavior of show with textconv
Make "git grep" and "git show" pay attention to --textconv when
dealing with blob objects.
I thought this was pretty well designed and executed, but it seems
there are some doubts on the list.
* jh/shorten-refname (2013-05-07) 4 commits
- t1514: refname shortening is done after dereferencing symbolic refs
- shorten_unambiguous_ref(): Fix shortening refs/remotes/origin/HEAD to origin
- t1514: Demonstrate failure to correctly shorten "refs/remotes/origin/HEAD"
- t1514: Add tests of shortening refnames in strict/loose mode
When remotes/origin/HEAD is not a symbolic ref, "rev-parse
--abbrev-ref remotes/origin/HEAD" ought to show "origin", not
"origin/HEAD", which is fixed with this series (if it is a symbolic
ref that points at remotes/origin/something, then it should show
"origin/something" and it already does).
Expecting a reroll, as an early part of a larger series.
* nd/clone-local-with-colon (2013-05-07) 1 commit
(merged to 'next' on 2013-05-21 at 3e293bd)
+ clone: allow cloning local paths with colons in them
"git clone foo/bar:baz" cannot be a request to clone from a remote
over git-over-ssh specified in the scp style. Detect this case and
clone from a local repository at "foo/bar:baz".
Will merge to 'master'.
* nd/warn-ambiguous-object-name (2013-05-07) 1 commit
- get_sha1: improve ambiguity warning regarding SHA-1 and ref names
"git cmd <name>", when <name> happens to be a 40-hex string,
directly uses the 40-hex string as an object name, even if a ref
"refs/<some hierarchy>/<name>" exists. This disambiguation order
is unlikely to change, but we should warn about the ambiguity just
like we warn when more than one refs/ hierachies share the same
name.
Will be rerolled.
$gmane/225585
* fc/zsh-leftover-bits (2013-05-28) 3 commits
(merged to 'next' on 2013-05-28 at d4a7aee)
+ completion: zsh: improve bash script loading
(merged to 'next' on 2013-05-21 at 1b84ec1)
+ completion: synchronize zsh wrapper
+ completion: cleanup zsh wrapper
Will merge to 'master'.
* rs/empty-archive (2013-05-09) 2 commits
(merged to 'next' on 2013-05-21 at 3e9e288)
+ t5004: resurrect original empty tar archive test
+ t5004: avoid using tar for checking emptiness of archive
Fixes tests added in 1.8.2 era that are broken on BSDs.
Will merge to 'master'.
* vv/help-unknown-ref (2013-05-08) 2 commits
(merged to 'next' on 2013-05-21 at 77a2941)
+ merge: use help_unknown_ref()
+ help: add help_unknown_ref()
Detect "git merge foo" that might have meant "git merge origin/foo"
and give an error message that is more specific than "foo is not
something we can merge".
Will merge to 'master'.
* fc/fast-export-persistent-marks (2013-05-07) 3 commits
(merged to 'next' on 2013-05-21 at 10b8214)
+ fast-{import,export}: use get_sha1_hex() to read from marks file
+ fast-export: don't parse commits while reading marks file
+ fast-export: do not parse non-commit objects while reading marks file
Optimization for fast-export by avoiding unnecessarily resolving
arbitrary object name and parsing object when only presence and
type information is necessary, etc.
Will merge to 'master'.
* jk/packed-refs-race (2013-05-06) 4 commits
- for_each_ref: load all loose refs before packed refs
- get_packed_refs: reload packed-refs file when it changes
- add a stat_validity struct
- resolve_ref: close race condition for packed refs
What is the status of this thing?
* fc/at-head (2013-05-08) 13 commits
- sha1_name: compare variable with constant, not constant with variable
- Add new @ shortcut for HEAD
- sha1_name: refactor reinterpret()
- sha1_name: check @{-N} errors sooner
- sha1_name: reorganize get_sha1_basic()
- sha1_name: don't waste cycles in the @-parsing loop
- sha1_name: remove unnecessary braces
- sha1_name: remove no-op
- tests: at-combinations: @{N} versus HEAD@{N}
- tests: at-combinations: increase coverage
- tests: at-combinations: improve nonsense()
- tests: at-combinations: check ref names directly
- tests: at-combinations: simplify setup
Instead of typing four capital letters "HEAD", you can say "@"
instead.
Will merge to 'next'.
* jk/lookup-object-prefer-latest (2013-05-02) 1 commit
(merged to 'next' on 2013-05-06 at cc59dcc)
+ lookup_object: prioritize recently found objects
Optimizes object lookup when the object hashtable starts to become
crowded.
Will merge to 'master'.
* jk/subtree-do-not-push-if-split-fails (2013-05-01) 1 commit
(merged to 'next' on 2013-05-06 at 81bdf37)
+ contrib/subtree: don't delete remote branches if split fails
"git subtree" (in contrib/) had one codepath with loose error
checks to lose data at the remote side.
Will merge to 'master'.
* fc/completion (2013-04-27) 9 commits
(merged to 'next' on 2013-05-21 at aba6ef1)
+ completion: remove __git_index_file_list_filter()
+ completion: add space after completed filename
+ completion: add hack to enable file mode in bash < 4
+ completion: refactor __git_complete_index_file()
+ completion: refactor diff_index wrappers
+ completion: use __gitcompadd for __gitcomp_file
+ completion; remove unuseful comments
+ completion: document tilde expansion failure in tests
+ completion: add file completion tests
Will merge to 'master'.
* jk/test-output (2013-05-06) 3 commits
(merged to 'next' on 2013-05-06 at 7c03af3)
+ t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively
(merged to 'next' on 2013-05-01 at 63827c9)
+ test output: respect $TEST_OUTPUT_DIRECTORY
+ t/Makefile: fix result handling with TEST_OUTPUT_DIRECTORY
When TEST_OUTPUT_DIRECTORY setting is used, it was handled somewhat
inconsistently between the test framework and t/Makefile, and logic
to summarize the results looked at a wrong place.
Will merge to 'master'.
* rj/sparse (2013-04-28) 10 commits
(merged to 'next' on 2013-05-01 at 649e16c)
+ sparse: Fix mingw_main() argument number/type errors
+ compat/mingw.c: Fix some sparse warnings
+ compat/win32mmap.c: Fix some sparse warnings
+ compat/poll/poll.c: Fix a sparse warning
+ compat/win32/pthread.c: Fix a sparse warning
+ compat/unsetenv.c: Fix a sparse warning
+ compat/nedmalloc: Fix compiler warnings on linux
+ compat/nedmalloc: Fix some sparse warnings
+ compat/fnmatch/fnmatch.c: Fix a sparse error
+ compat/regex/regexec.c: Fix some sparse warnings
Will merge to 'master'.
* mh/fetch-into-shallow (2013-05-02) 2 commits
(merged to 'next' on 2013-05-03 at 3fadc61)
+ t5500: add test for fetching with an unknown 'shallow'
(merged to 'next' on 2013-04-29 at a167d3e)
+ upload-pack: ignore 'shallow' lines with unknown obj-ids
Will merge to 'master'.
* jh/checkout-auto-tracking (2013-04-21) 8 commits
(merged to 'next' on 2013-04-22 at 2356700)
+ glossary: Update and rephrase the definition of a remote-tracking branch
+ branch.c: Validate tracking branches with refspecs instead of refs/remotes/*
+ t9114.2: Don't use --track option against "svn-remote"-tracking branches
+ t7201.24: Add refspec to keep --track working
+ t3200.39: tracking setup should fail if there is no matching refspec.
+ checkout: Use remote refspecs when DWIMming tracking branches
+ t2024: Show failure to use refspec when DWIMming remote branch names
+ t2024: Add tests verifying current DWIM behavior of 'git checkout <branch>'
Updates "git checkout foo" that DWIMs the intended "upstream" and
turns it into "git checkout -t -b foo remotes/origin/foo" to
correctly take existing remote definitions into account. The
remote "origin" may be what uniquely map its own branch to
remotes/some/where/foo but that some/where may not be "origin".
Will merge to 'master'.
* jc/prune-all (2013-04-25) 4 commits
(merged to 'next' on 2013-04-26 at 97a7387)
+ prune: introduce OPT_EXPIRY_DATE() and use it
(merged to 'next' on 2013-04-22 at b00ccf6)
+ api-parse-options.txt: document "no-" for non-boolean options
+ git-gc.txt, git-reflog.txt: document new expiry options
+ date.c: add parse_expiry_date()
(this branch is used by mh/packed-refs-various.)
We used the approxidate() parser for "--expire=<timestamp>" options
of various commands, but it is better to treat --expire=all and
--expire=now a bit more specially than using the current timestamp.
Update "git gc" and "git reflog" with a new parsing function for
expiry dates.
Will merge to 'master'.
* as/check-ignore (2013-04-29) 6 commits
(merged to 'next' on 2013-04-30 at 646931f)
+ t0008: use named pipe (FIFO) to test check-ignore streaming
(merged to 'next' on 2013-04-21 at 7515aa8)
+ Documentation: add caveats about I/O buffering for check-{attr,ignore}
+ check-ignore: allow incremental streaming of queries via --stdin
+ check-ignore: move setup into cmd_check_ignore()
+ check-ignore: add -n / --non-matching option
+ t0008: remove duplicated test fixture data
Enhance "check-ignore" (1.8.2 update) to work more like "check-attr"
over bidi-pipes.
Will merge to 'master'.
* mh/packed-refs-various (2013-05-01) 33 commits
(merged to 'next' on 2013-05-01 at e527153)
+ refs: handle the main ref_cache specially
+ refs: change do_for_each_*() functions to take ref_cache arguments
+ pack_one_ref(): do some cheap tests before a more expensive one
+ pack_one_ref(): use write_packed_entry() to do the writing
+ pack_one_ref(): use function peel_entry()
+ refs: inline function do_not_prune()
+ pack_refs(): change to use do_for_each_entry()
+ refs: use same lock_file object for both ref-packing functions
+ pack_one_ref(): rename "path" parameter to "refname"
+ pack-refs: merge code from pack-refs.{c,h} into refs.{c,h}
+ pack-refs: rename handle_one_ref() to pack_one_ref()
+ refs: extract a function write_packed_entry()
+ repack_without_ref(): write peeled refs in the rewritten file
+ t3211: demonstrate loss of peeled refs if a packed ref is deleted
+ refs: change how packed refs are deleted
+ search_ref_dir(): return an index rather than a pointer
+ repack_without_ref(): silence errors for dangling packed refs
+ t3210: test for spurious error messages for dangling packed refs
+ refs: change the internal reference-iteration API
+ refs: extract a function peel_entry()
+ peel_ref(): fix return value for non-peelable, not-current reference
+ peel_object(): give more specific information in return value
+ refs: extract function peel_object()
+ refs: extract a function ref_resolves_to_object()
+ repack_without_ref(): use function get_packed_ref()
+ peel_ref(): use function get_packed_ref()
+ get_packed_ref(): return a ref_entry
+ do_for_each_ref_in_dirs(): remove dead code
+ refs: define constant PEELED_LINE_LENGTH
+ refs: document how current_ref is used
+ refs: document do_for_each_ref() and do_one_ref()
+ refs: document the fields of struct ref_value
+ refs: document flags constants REF_*
(this branch uses jc/prune-all.)
Updates reading and updating packed-refs file, correcting corner
case bugs.
Will merge to 'master'.
* fc/transport-helper-error-reporting (2013-05-10) 12 commits
(merged to 'next' on 2013-05-10 at 2a9af4b)
+ transport-helper: fix remote helper namespace regression
+ test: remote-helper: add missing and
(merged to 'next' on 2013-04-25 at 3358f1a)
+ t5801: "VAR=VAL shell_func args" is forbidden
(merged to 'next' on 2013-04-22 at 5ba6467)
+ transport-helper: update remote helper namespace
+ transport-helper: trivial code shuffle
+ transport-helper: warn when refspec is not used
+ transport-helper: clarify pushing without refspecs
+ transport-helper: update refspec documentation
+ transport-helper: clarify *:* refspec
+ transport-helper: improve push messages
+ transport-helper: mention helper name when it dies
+ transport-helper: report errors properly
(this branch is tangled with js/transport-helper-error-reporting-fix.)
Update transport helper to report errors and maintain ref hierarchy
used to keep track of remote helper state better.
Will merge to 'master'.
* js/transport-helper-error-reporting-fix (2013-04-28) 13 commits
(merged to 'next' on 2013-04-29 at 8cc4bb8)
+ git-remote-testgit: build it to run under $SHELL_PATH
+ git-remote-testgit: further remove some bashisms
+ git-remote-testgit: avoid process substitution
(merged to 'next' on 2013-04-25 at 3358f1a)
+ t5801: "VAR=VAL shell_func args" is forbidden
(merged to 'next' on 2013-04-22 at 5ba6467)
+ transport-helper: update remote helper namespace
+ transport-helper: trivial code shuffle
+ transport-helper: warn when refspec is not used
+ transport-helper: clarify pushing without refspecs
+ transport-helper: update refspec documentation
+ transport-helper: clarify *:* refspec
+ transport-helper: improve push messages
+ transport-helper: mention helper name when it dies
+ transport-helper: report errors properly
(this branch is tangled with fc/transport-helper-error-reporting.)
Finishing touches to fc/transport-helper-error-reporting topic.
Will merge to 'master'.
* jk/submodule-subdirectory-ok (2013-04-24) 3 commits
(merged to 'next' on 2013-04-24 at 6306b29)
+ submodule: fix quoting in relative_path()
(merged to 'next' on 2013-04-22 at f211e25)
+ submodule: drop the top-level requirement
+ rev-parse: add --prefix option
Allow various subcommands of "git submodule" to be run not from the
top of the working tree of the superproject.
Will be commented by Jens.
* jl/submodule-mv (2013-04-23) 5 commits
(merged to 'next' on 2013-04-23 at c04f574)
+ submodule.c: duplicate real_path's return value
(merged to 'next' on 2013-04-19 at 45ae3c9)
+ rm: delete .gitmodules entry of submodules removed from the work tree
+ Teach mv to update the path entry in .gitmodules for moved submodules
+ Teach mv to move submodules using a gitfile
+ Teach mv to move submodules together with their work trees
"git mv A B" when moving a submodule A does "the right thing",
inclusing relocating its working tree and adjusting the paths in
the .gitmodules file.
Will be commented by Jens.
* jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit
- git add: -u/-A now affects the entire working tree
Will cook in 'next' until Git 2.0.
* jc/core-checkstat-2.0 (2013-05-06) 1 commit
- core.statinfo: remove as promised in Git 2.0
(this branch uses jc/core-checkstat.)
Will cook in 'next' until Git 2.0.
* jc/push-2.0-default-to-simple (2013-04-03) 1 commit
- push: switch default from "matching" to "simple"
Will cook in 'next' until Git 2.0.
* jc/add-2.0-ignore-removal (2013-04-22) 1 commit
- git add <pathspec>... defaults to "-A"
Updated endgame for "git add <pathspec>" that defaults to "--all"
aka "--no-ignore-removal".
Will cook in 'next' until Git 2.0.
--------------------------------------------------
[Discarded]
* kb/full-history-compute-treesame-carefully (2013-05-06) 11 commits
. revision.c: treat A...B merge bases as if manually specified
. revision.c: discount side branches when computing TREESAME
. simplify-merges: drop merge from irrelevant side branch
. simplify-merges: never remove all TREESAME parents
. t6012: update test for tweaked full-history traversal
. revision.c: Make --full-history consider more merges
. rev-list-options.txt: correct TREESAME for P
. t6111: allow checking the parents as well
. t6111: new TREESAME test set
. t6019: test file dropped in -s ours merge
. decorate.c: compact table when growing
Superseded by kb/full-history-compute-treesame-carefully-2
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-28 21:54 What's cooking in git.git (May 2013, #08; Tue, 28) Junio C Hamano
@ 2013-05-29 2:55 ` Felipe Contreras
2013-05-29 17:29 ` Junio C Hamano
2013-05-29 11:11 ` [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash Ramkumar Ramachandra
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Felipe Contreras @ 2013-05-29 2:55 UTC (permalink / raw)
To: Junio C Hamano, git
Junio C Hamano wrote:
> * fc/makefile (2013-05-26) 5 commits
> - build: do not install git-remote-testpy
> - build: add NO_INSTALL variable
> - build: cleanup using $<
> - build: cleanup using $^
> - build: trivial simplification
> (this branch is used by fc/remote-helpers-use-specified-python.)
No, these are independent.
> * fc/remote-helpers-use-specified-python (2013-05-28) 4 commits
> - remote-helpers: add exec-path links
> - remote-helpers: allow direct test execution
> - remote-helpers: rename tests
> - remote-helpers: generate scripts
> (this branch uses fc/makefile.)
>
> I do not particularly think the second from the bottom is a good
> change, but it takes the remainder of the series hostage.
> Will hopefully be rerolled without it.
> * fc/remote-bzr (2013-05-28) 8 commits
> - remote-bzr: add fallback check for a partial clone
> - remote-bzr: reorganize the way 'wanted' works
> - remote-bzr: trivial cleanups
> - remote-bzr: change global repo
> - remote-bzr: delay cloning/pulling
> - remote-bzr: simplify get_remote_branch()
> - remote-bzr: fix for files with spaces
> - remote-bzr: recover from failed clones
>
> The ones near the tip conflicted with the hotfix for 1.8.3 so I
> discarded them for now.
>
> Will merge to 'next'?
Didn't I resend these with the conflict fixed?
--
Felipe Contreras
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash
2013-05-28 21:54 What's cooking in git.git (May 2013, #08; Tue, 28) Junio C Hamano
2013-05-29 2:55 ` Felipe Contreras
@ 2013-05-29 11:11 ` Ramkumar Ramachandra
2013-05-29 17:32 ` Junio C Hamano
2013-05-29 11:27 ` What's cooking in git.git (May 2013, #08; Tue, 28) Ramkumar Ramachandra
2013-05-29 23:44 ` Ramsay Jones
3 siblings, 1 reply; 12+ messages in thread
From: Ramkumar Ramachandra @ 2013-05-29 11:11 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git List
For rr/rebase-autostash, which is stalled in pu. See $gmane/225689.
This is a super-minor fix anyway: if you disagree with something, change
it; there's no need to ask me.
As for the follow-up introducing a 'stash store', I will submit it in
good time: there's no hurry. I'm working on some other interesting
things in the meantime (see hot-branch and @{push}).
Thanks.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
git-rebase.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-rebase.sh b/git-rebase.sh
index 709ef6b..5906757 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -151,16 +151,16 @@ finish_rebase () {
stash_sha1=$(cat "$state_dir/autostash")
if git stash apply $stash_sha1 2>&1 >/dev/null
then
- echo "Applied autostash"
+ echo "$(gettext 'Applied autostash.')"
else
ref_stash=refs/stash &&
: >>"$GIT_DIR/logs/$ref_stash" &&
git update-ref -m "autostash" $ref_stash $stash_sha1 \
|| die "$(eval_gettext 'Cannot store $stash_sha1')"
- echo "
-$(gettext 'Applying autostash resulted in conflicts.
+ gettext 'Applying autostash resulted in conflicts.
Your changes are safe in the stash.
-You can apply or drop it at any time.')"
+You can run "git stash pop" or "git stash drop" it at any time.
+'
fi
fi
git gc --auto &&
--
1.8.3.rc3.11.geb5ebca
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-28 21:54 What's cooking in git.git (May 2013, #08; Tue, 28) Junio C Hamano
2013-05-29 2:55 ` Felipe Contreras
2013-05-29 11:11 ` [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash Ramkumar Ramachandra
@ 2013-05-29 11:27 ` Ramkumar Ramachandra
2013-05-29 17:45 ` Junio C Hamano
2013-05-29 23:44 ` Ramsay Jones
3 siblings, 1 reply; 12+ messages in thread
From: Ramkumar Ramachandra @ 2013-05-29 11:27 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano wrote:
> * rr/rebase-autostash (2013-05-12) 7 commits
> - rebase: implement --[no-]autostash and rebase.autostash
> - rebase --merge: return control to caller, for housekeeping
> - rebase -i: return control to caller, for housekeeping
> - am: return control to caller, for housekeeping
> - rebase: prepare to do generic housekeeping
> - rebase -i: don't error out if $state_dir already exists
> - am: tighten a conditional that checks for $dotest
>
> This is from v3, but after a "Fixed" message in $gmane/224111 we
> haven't seen a reroll yet. Also there was an attempt for a
> follow-up, but it was never completed.
I've sent a tiny fixup for the last part. Let me know if you're
expecting something else.
> * rr/die-on-missing-upstream (2013-05-22) 2 commits
> - sha1_name: fix error message for @{<N>}, @{<date>}
> - sha1_name: fix error message for @{u}
>
> When a reflog notation is used for implicit "current branch", we
> did not say which branch and worse said "branch ''".
>
> Waiting for series of rerolls to settle.
I'm happy with the version in pu, and I don't intend to send any
re-rolls. Is there something you're not happy with?
Quick update from my side:
* publish-rev: the @{push} thing is still in the early poc stages.
* for-each-ref-pretty: not ready; working with Duy.
* push-current-head: ready but for the commit message: in your
opinion, it doesn't "fix" anything other than the output. I'll
rewrite and submit soon.
* pickaxe-doc: you had some more comments in latest iteration, but the
returns from a re-roll are diminishing. Frankly, the work is too
boring: the first few iterations were interesting, because I was
learning; now, it's mostly differences in taste. Nevertheless, I'll
re-roll when I want to sleep next.
That's about it, I think. I've abandoned everything else.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-29 2:55 ` Felipe Contreras
@ 2013-05-29 17:29 ` Junio C Hamano
2013-05-29 18:46 ` Felipe Contreras
0 siblings, 1 reply; 12+ messages in thread
From: Junio C Hamano @ 2013-05-29 17:29 UTC (permalink / raw)
To: Felipe Contreras; +Cc: git
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Junio C Hamano wrote:
>> * fc/makefile (2013-05-26) 5 commits
>> - build: do not install git-remote-testpy
>> - build: add NO_INSTALL variable
>> - build: cleanup using $<
>> - build: cleanup using $^
>> - build: trivial simplification
>> (this branch is used by fc/remote-helpers-use-specified-python.)
>
> No, these are independent.
By the way, I dropped the order-only one and I explained my
reasoning for doing so, but I haven't heard back from you.
As I haven't used the order-only dependencies nor '|' myself so far
(primarily because I have not seen a case where it was needed), it
would have been nice if you responded with either "yes, this is not
order-only and the patch should be dropped", or "no, order-only is
correct because...".
In any case, I think the above remaining five were sensible changes,
and am thinking about having it graduating early in the cycle.
I somehow had an impression that the other series depended on this
for SCRIPT_PYTHON_* stuff, but this is about the installation step
and the other one is primarily about the build step, so in that
sense it may be independent.
>> * fc/remote-bzr (2013-05-28) 8 commits
>> - remote-bzr: add fallback check for a partial clone
>> - remote-bzr: reorganize the way 'wanted' works
>> - remote-bzr: trivial cleanups
>> - remote-bzr: change global repo
>> - remote-bzr: delay cloning/pulling
>> - remote-bzr: simplify get_remote_branch()
>> - remote-bzr: fix for files with spaces
>> - remote-bzr: recover from failed clones
>>
>> The ones near the tip conflicted with the hotfix for 1.8.3 so I
>> discarded them for now.
>>
>> Will merge to 'next'?
>
> Didn't I resend these with the conflict fixed?
As the date above (05-28) shows, it seems that I did not forget to
drop the old one to replace with the new one, but I did forget to
remove the stale comment from the previous issue. Thanks for
noticing.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash
2013-05-29 11:11 ` [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash Ramkumar Ramachandra
@ 2013-05-29 17:32 ` Junio C Hamano
2013-05-29 17:38 ` Ramkumar Ramachandra
2013-05-29 17:38 ` Matthieu Moy
0 siblings, 2 replies; 12+ messages in thread
From: Junio C Hamano @ 2013-05-29 17:32 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: Git List
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> For rr/rebase-autostash, which is stalled in pu. See $gmane/225689.
>
> This is a super-minor fix anyway: if you disagree with something, change
> it; there's no need to ask me.
As I wasn't the one who were disagreeing, that would not work
well.
Was there anybody "disagreeing" in the first place? I thought
everybody was helping the series to get better.
> git-rebase.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/git-rebase.sh b/git-rebase.sh
> index 709ef6b..5906757 100755
> --- a/git-rebase.sh
> +++ b/git-rebase.sh
> @@ -151,16 +151,16 @@ finish_rebase () {
> stash_sha1=$(cat "$state_dir/autostash")
> if git stash apply $stash_sha1 2>&1 >/dev/null
> then
> - echo "Applied autostash"
> + echo "$(gettext 'Applied autostash.')"
> else
> ref_stash=refs/stash &&
> : >>"$GIT_DIR/logs/$ref_stash" &&
> git update-ref -m "autostash" $ref_stash $stash_sha1 \
> || die "$(eval_gettext 'Cannot store $stash_sha1')"
> - echo "
> -$(gettext 'Applying autostash resulted in conflicts.
> + gettext 'Applying autostash resulted in conflicts.
> Your changes are safe in the stash.
> -You can apply or drop it at any time.')"
> +You can run "git stash pop" or "git stash drop" it at any time.
> +'
> fi
> fi
> git gc --auto &&
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash
2013-05-29 17:32 ` Junio C Hamano
@ 2013-05-29 17:38 ` Ramkumar Ramachandra
2013-05-29 17:38 ` Matthieu Moy
1 sibling, 0 replies; 12+ messages in thread
From: Ramkumar Ramachandra @ 2013-05-29 17:38 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git List
Junio C Hamano wrote:
> As I wasn't the one who were disagreeing, that would not work
> well.
I meant in the tiny details like echo + gettext versus gettext.
>From the review of v3, nobody had any disagreements; just minor
suggestions: that's what this patch is about anyway.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash
2013-05-29 17:32 ` Junio C Hamano
2013-05-29 17:38 ` Ramkumar Ramachandra
@ 2013-05-29 17:38 ` Matthieu Moy
1 sibling, 0 replies; 12+ messages in thread
From: Matthieu Moy @ 2013-05-29 17:38 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Ramkumar Ramachandra, Git List
Junio C Hamano <gitster@pobox.com> writes:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> For rr/rebase-autostash, which is stalled in pu. See $gmane/225689.
>>
>> This is a super-minor fix anyway: if you disagree with something, change
>> it; there's no need to ask me.
>
> As I wasn't the one who were disagreeing, that would not work
> well.
>
> Was there anybody "disagreeing" in the first place?
I was the one suggesting the change, but I do not disagree with
anything ;-). The fixup is right.
I think Ramkumar was just saying "feel free to edit while applying", not
that there was any disagreement actually.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-29 11:27 ` What's cooking in git.git (May 2013, #08; Tue, 28) Ramkumar Ramachandra
@ 2013-05-29 17:45 ` Junio C Hamano
2013-05-29 18:15 ` Ramkumar Ramachandra
0 siblings, 1 reply; 12+ messages in thread
From: Junio C Hamano @ 2013-05-29 17:45 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: git
Ramkumar Ramachandra <artagnon@gmail.com> writes:
>> * rr/die-on-missing-upstream (2013-05-22) 2 commits
>> - sha1_name: fix error message for @{<N>}, @{<date>}
>> - sha1_name: fix error message for @{u}
>>
>> When a reflog notation is used for implicit "current branch", we
>> did not say which branch and worse said "branch ''".
>>
>> Waiting for series of rerolls to settle.
>
> I'm happy with the version in pu, and I don't intend to send any
> re-rolls.
OK, then I'll take a final look at it (I may or may not have
comments after doing so) before merging it down.
> Is there something you're not happy with?
By the way, you probably should stop thinking in terms of "me" being
(un)happy. I am just trying to help by preventing (collectively) us
making silly mistakes.
> * publish-rev: the @{push} thing is still in the early poc stages.
I presume this is the one that may someday lay foundations for Tytso's
"do not rebase beyond this point, as I have published it already"?
> * for-each-ref-pretty: not ready; working with Duy.
I haven't been paying too much attention to it, but my impression
was a "superset" syntax is coming? That would be going in the right
direction.
> * push-current-head: ready but for the commit message: in your
> opinion, it doesn't "fix" anything other than the output. I'll
> rewrite and submit soon.
I do not recall what this one is about, but we'll see when you send
it out.
> * pickaxe-doc: you had some more comments in latest iteration, but the
> returns from a re-roll are diminishing. Frankly, the work is too
> boring: the first few iterations were interesting, because I was
> learning;...
Yeah, some parts of the project is boring and that is not a news.
Think of documentation updates as helping others to learn.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-29 17:45 ` Junio C Hamano
@ 2013-05-29 18:15 ` Ramkumar Ramachandra
0 siblings, 0 replies; 12+ messages in thread
From: Ramkumar Ramachandra @ 2013-05-29 18:15 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano wrote:
>> Is there something you're not happy with?
>
> By the way, you probably should stop thinking in terms of "me" being
> (un)happy. I am just trying to help by preventing (collectively) us
> making silly mistakes.
As a general principle, okay.
IIRC, nobody else had comments on this one.
>> * publish-rev: the @{push} thing is still in the early poc stages.
>
> I presume this is the one that may someday lay foundations for Tytso's
> "do not rebase beyond this point, as I have published it already"?
Yep. More importantly, I'll get something I've been wanting badly:
the tracking info in the prompt.
>> * for-each-ref-pretty: not ready; working with Duy.
>
> I haven't been paying too much attention to it, but my impression
> was a "superset" syntax is coming? That would be going in the right
> direction.
Yes, a superset with coming with one caveat: %ae will be interpreted
as hex. I hope to send a large'ish series that also strips out the
-v, -vv code. Duy basically did most of the work by coming up with a
brilliant way to inject into the pretty-formats machinery.
>> * pickaxe-doc: you had some more comments in latest iteration, but the
>> returns from a re-roll are diminishing. Frankly, the work is too
>> boring: the first few iterations were interesting, because I was
>> learning;...
>
> Yeah, some parts of the project is boring and that is not a news.
> Think of documentation updates as helping others to learn.
See, the problem is that I might drop the ball on patches like this
(I've done it before, when I thought the change wasn't important
enough for me to bore myself). This is definitely important, and I
will see it to completion. But I'm echoing a more general problem:
If people don't feel like working on it, how will the documentation
improve? And if the pickaxe-doc was in such bad shape, how could
anyone have been using it? Do an internet search and see for
yourself. This feature is _extremely_ useful, and it's a real shame
that it has been so poorly documented for this long.
I'm not advocating a lax review that checks in technically incorrect
documentation; that will confuse users and turn it into a huge
maintenance burden. But we can maybe go down a notch on style?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-29 17:29 ` Junio C Hamano
@ 2013-05-29 18:46 ` Felipe Contreras
0 siblings, 0 replies; 12+ messages in thread
From: Felipe Contreras @ 2013-05-29 18:46 UTC (permalink / raw)
To: Junio C Hamano, Felipe Contreras; +Cc: git
Junio C Hamano wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> > Junio C Hamano wrote:
> >> * fc/makefile (2013-05-26) 5 commits
> >> - build: do not install git-remote-testpy
> >> - build: add NO_INSTALL variable
> >> - build: cleanup using $<
> >> - build: cleanup using $^
> >> - build: trivial simplification
> >> (this branch is used by fc/remote-helpers-use-specified-python.)
> >
> > No, these are independent.
>
> By the way, I dropped the order-only one and I explained my
> reasoning for doing so, but I haven't heard back from you.
>
> As I haven't used the order-only dependencies nor '|' myself so far
> (primarily because I have not seen a case where it was needed), it
> would have been nice if you responded with either "yes, this is not
> order-only and the patch should be dropped", or "no, order-only is
> correct because...".
I'm not sure, so I think it's OK to drop it. I've used order-only to
dependencies that should not be listed when doing $^ which doesn't affect us
anyway, so I thought it was more descriptive with the patch, but I can see why
it would break the build if that file is updated and the targets that depend on
it don't.
I don't have time to investigate further, so I think it's OK.
> In any case, I think the above remaining five were sensible changes,
> and am thinking about having it graduating early in the cycle.
If you do that, please add git-remote-testgit.sh to the NO_INSTALL list. I
didn't do that at the time because I was working on the master branch, but this
changed in 'next'.
> I somehow had an impression that the other series depended on this
> for SCRIPT_PYTHON_* stuff, but this is about the installation step
> and the other one is primarily about the build step, so in that
> sense it may be independent.
They are completely independent. The improvments to the main Makefile is what I
came up while trying to understand the code.
> >> * fc/remote-bzr (2013-05-28) 8 commits
> >> - remote-bzr: add fallback check for a partial clone
> >> - remote-bzr: reorganize the way 'wanted' works
> >> - remote-bzr: trivial cleanups
> >> - remote-bzr: change global repo
> >> - remote-bzr: delay cloning/pulling
> >> - remote-bzr: simplify get_remote_branch()
> >> - remote-bzr: fix for files with spaces
> >> - remote-bzr: recover from failed clones
> >>
> >> The ones near the tip conflicted with the hotfix for 1.8.3 so I
> >> discarded them for now.
> >>
> >> Will merge to 'next'?
> >
> > Didn't I resend these with the conflict fixed?
>
> As the date above (05-28) shows, it seems that I did not forget to
> drop the old one to replace with the new one, but I did forget to
> remove the stale comment from the previous issue. Thanks for
> noticing.
Oh, I see. Cool.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: What's cooking in git.git (May 2013, #08; Tue, 28)
2013-05-28 21:54 What's cooking in git.git (May 2013, #08; Tue, 28) Junio C Hamano
` (2 preceding siblings ...)
2013-05-29 11:27 ` What's cooking in git.git (May 2013, #08; Tue, 28) Ramkumar Ramachandra
@ 2013-05-29 23:44 ` Ramsay Jones
3 siblings, 0 replies; 12+ messages in thread
From: Ramsay Jones @ 2013-05-29 23:44 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano wrote:
>
> * rj/mingw-compat-st-mode-bits (2013-05-28) 1 commit
> - path: Fix a sparse warning
>
> Will merge to 'next'.
Hmm, this breaks the build on cygwin. :(
Now, I always test my patches on Linux, cygwin and MinGW
before sending, ... except that I obviously didn't test
on cygwin this time - it doesn't even compile. *ahem*
The extern declaration for get_st_mode_bits() must come
*before* including compat/cygwin.h; otherwise it will
get mangled by the macro in that header file.
Sorry for breaking the build.
A v3 patch is on it's way. (I'm liking the v1 patch more now ;-)
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-05-29 23:59 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-28 21:54 What's cooking in git.git (May 2013, #08; Tue, 28) Junio C Hamano
2013-05-29 2:55 ` Felipe Contreras
2013-05-29 17:29 ` Junio C Hamano
2013-05-29 18:46 ` Felipe Contreras
2013-05-29 11:11 ` [PATCH] fixup! rebase: implement --[no-]autostash and rebase.autostash Ramkumar Ramachandra
2013-05-29 17:32 ` Junio C Hamano
2013-05-29 17:38 ` Ramkumar Ramachandra
2013-05-29 17:38 ` Matthieu Moy
2013-05-29 11:27 ` What's cooking in git.git (May 2013, #08; Tue, 28) Ramkumar Ramachandra
2013-05-29 17:45 ` Junio C Hamano
2013-05-29 18:15 ` Ramkumar Ramachandra
2013-05-29 23:44 ` Ramsay Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.