Re: [PATCH 2/2] config: add include directive

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] config: add include directive
Date: Mon, 06 Feb 2012 14:39:41 -0800	[thread overview]
Message-ID: <7v62fj60ya.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120206095404.GB4300@sigill.intra.peff.net> (Jeff King's message of "Mon, 6 Feb 2012 04:54:04 -0500")

Jeff King <peff@peff.net> writes:

> +Includes
> +~~~~~~~~
> +
> +You can include one config file from another by setting the special
> +`include.path` variable to the name of the file to be included. The
> +included file is expanded immediately, as if its contents had been
> +found at the location of the include directive. If the value of the
> +`include.path` variable is a relative path, the path is considered to be
> +relative to the configuration file in which the include directive was
> +found. See below for examples.

If the file referenced by this directive does not exist, what should
happen?  Should it be signalled as an error?  Should it stop the whole
calling process with die()?

I think "die() when we are honoring the include, ignore when we are not"
would be a good way to handle this, as it allows us to catch mistakes
while allowing the user to fix broken configuration files using "git
config --unset include.path", but I may be overlooking something.