From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] docs: add a basic description of the config API
Date: Wed, 8 Feb 2012 11:01:10 +0700 [thread overview]
Message-ID: <CACsJy8AU3ZA1=Q3vahhP6Nr=FZNKd7oRJ04mtKVs+uvNqJeVaw@mail.gmail.com> (raw)
In-Reply-To: <7vlioe1o1g.fsf@alter.siamese.dyndns.org>
2012/2/8 Junio C Hamano <gitster@pobox.com>:
> Jeff King <peff@peff.net> writes:
>
>>> > +A config callback should return 0 for success, or -1 if the variable
>>> > +could not be parsed properly.
>>>
>>> This matches what I have always thought, but I think I recently saw a
>>> series that adds callbacks that return 1 to mean "I have understood this
>>> variable, so callers should not look at it any more". It felt wrong, but
>>> I did not find anything in the config.c API framework to prvent such a
>>> local calling convention.
>>
>> ...
>> The "1 means I understood this" convention is used by userdiff_config. I
>> don't like that it is unlike every other config callback,...
>> Looking at the code again, though, ...
>> Hmm. Yeah. The userdiff calling convention dates back to late 2008....
>> So I think we could go back and simplify the userdiff_config code now.
>
> I remembered where I saw the new "offender"; it was nd/columns
> topic (Cc'ing Nguyễn).
nd/columns does use "1" convention in git_column_config(), but the
direct config callback function does not return 1 to config machinery.
All call sites follow this pattern:
int ret = git_column_config(key, var, "command", &colopts);
if (ret <= 0) return ret;
I think it's ok.
--
Duy
next prev parent reply other threads:[~2012-02-08 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 9:53 [PATCH 0/2] config includes 3: revenge of the killer includes Jeff King
2012-02-06 9:53 ` [PATCH 1/2] docs: add a basic description of the config API Jeff King
2012-02-06 22:31 ` Junio C Hamano
2012-02-07 18:06 ` Jeff King
2012-02-07 18:23 ` Jeff King
2012-02-07 18:45 ` Junio C Hamano
2012-02-07 18:44 ` Junio C Hamano
2012-02-08 4:01 ` Nguyen Thai Ngoc Duy [this message]
2012-02-08 6:40 ` Junio C Hamano
2012-02-08 6:55 ` Nguyen Thai Ngoc Duy
2012-02-08 15:59 ` Jeff King
2012-02-08 15:48 ` Jeff King
2012-02-07 19:46 ` Jeff King
2012-02-06 9:54 ` [PATCH 2/2] config: add include directive Jeff King
2012-02-06 22:39 ` Junio C Hamano
2012-02-07 18:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8AU3ZA1=Q3vahhP6Nr=FZNKd7oRJ04mtKVs+uvNqJeVaw@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.