Re: [PATCH 4/4] fetch-pack: mention server version with verbose output

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH 4/4] fetch-pack: mention server version with verbose output
Date: Mon, 13 Aug 2012 21:56:57 -0700	[thread overview]
Message-ID: <7v8vdiax5y.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120814020210.GB7891@sigill.intra.peff.net> (Jeff King's message of "Mon, 13 Aug 2012 22:02:10 -0400")

Jeff King <peff@peff.net> writes:

> +	if ((agent_feature = server_feature_value("agent", &agent_len))) {
>  		agent_supported = 1;
> +		if (args.verbose && agent_len) {
> +			fprintf(stderr, "Server version is %.*s\n",
> +				agent_len, agent_feature);
> +		}
> +	}

OK.  The one I queued in 'pu' said "Server version not disclosed"
when length was 0, but I think I like this one better.

Also I like the the update to the parsing code in the previous
patch.  It makes the logic clearer.

Thanks.