Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support

From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support
Date: Thu, 07 Apr 2011 11:28:10 -0700	[thread overview]
Message-ID: <7v8vvlgblx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BANLkTinkXVSFYqqZ+pHK0w8ij5YtPMfKEA@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Thu, 7 Apr 2011 20:09:43 +0700")

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> 2011/4/7 Junio C Hamano <gitster@pobox.com>:
>> +                       if (('a' <= ch && ch <= 'z') ||
>> +                           ('A' <= ch && ch <= 'Z')) {
>> +                               strbuf_addf(&sb, "[%c%c]",
>> +                                           tolower(ch), toupper(ch));
>
> Nice try. You know you are going to pay a high performance price for
> that, don't you ;) Maybe also worth mentioning in document that this
> applies to ASCII charset only (as opposed to Unicode).

You know this is a throw-away patch, just to illustrate that some things
are doable with a hack to add more code to get_pathspec(), while others
would need a bigger restructuring, don't you?

Besides, _if_ the user wants to do something costly, as long as the
implementation does not harm common cases, it _still_ is better to make
the code do the work, no?