From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support
Date: Thu, 07 Apr 2011 09:18:08 -0700 [thread overview]
Message-ID: <7vd3kyf327.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BANLkTint7sGCg7_seu1-SWJC=_sKF-FKYw@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Thu, 7 Apr 2011 20:23:21 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
> Also the patch does not catch this (ie. not die() on unrecognized signature).
Of course it doesn't.
I didn't say "everything that is not alphanumeric is magic". I only said
"all the magic are not alphanumeric". Notice the difference.
This is so that you can say ":/.gitignore" and do not have to say
":/:.gitignore".
I am also tempted to special case a ':' followed by a zero magic as if it
specifies the top magic, e.g. ":Makefile" is the same as ":(top)Makefile",
aka ":/Makefile". It is not in the published code, but the short-cut
would help ":.gitignore".
You don't require, nor allowed to have, a colon after ')' when writing a
long hand, by the way. There is no reason to require one for disambiguation.
next prev parent reply other threads:[~2011-04-07 16:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 1:16 [PATCH 0/4] Redoing the "add -u" migration plan Junio C Hamano
2011-04-07 1:16 ` [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support Junio C Hamano
2011-04-07 1:40 ` Junio C Hamano
2011-04-07 13:09 ` Nguyen Thai Ngoc Duy
2011-04-07 18:28 ` Junio C Hamano
2011-04-08 11:39 ` Nguyen Thai Ngoc Duy
2011-04-07 13:23 ` Nguyen Thai Ngoc Duy
2011-04-07 16:18 ` Junio C Hamano [this message]
2011-04-08 12:00 ` Nguyen Thai Ngoc Duy
2011-04-08 15:05 ` Junio C Hamano
2011-04-08 15:39 ` Nguyen Thai Ngoc Duy
2011-04-08 16:37 ` Junio C Hamano
2011-04-08 17:02 ` Nguyen Thai Ngoc Duy
2011-04-07 1:16 ` [PATCH 2/4] add -u: get rid of "treewideupdate" configuration Junio C Hamano
2011-04-08 17:54 ` Jeff King
2011-04-08 19:27 ` Junio C Hamano
2011-04-08 20:24 ` Jeff King
2011-04-08 22:22 ` Junio C Hamano
2011-04-08 22:32 ` Jeff King
2011-04-08 22:37 ` Junio C Hamano
2011-04-08 23:18 ` Junio C Hamano
2011-04-09 4:38 ` Nguyen Thai Ngoc Duy
2011-04-09 4:56 ` Junio C Hamano
2011-04-09 5:05 ` Nguyen Thai Ngoc Duy
2011-04-09 21:34 ` Junio C Hamano
2011-04-09 4:58 ` Nguyen Thai Ngoc Duy
2011-04-09 5:20 ` Junio C Hamano
2011-04-09 10:15 ` Nguyen Thai Ngoc Duy
2011-04-09 11:24 ` Nguyen Thai Ngoc Duy
2011-04-09 21:38 ` Junio C Hamano
2011-05-03 7:52 ` Nguyen Thai Ngoc Duy
2011-05-03 15:01 ` Junio C Hamano
2011-05-03 16:17 ` Nguyen Thai Ngoc Duy
2011-04-07 1:16 ` [PATCH 3/4] add: make "add -u/-A" update full tree without pathspec (step 2) Junio C Hamano
2011-04-07 1:16 ` [PATCH 4/4] add: make "add -u/-A" update full tree without pathspec (step 3) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3kyf327.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.