[PATCH] Add semicolon to curly brace group in main Makefile

[PATCH] Add semicolon to curly brace group in main Makefile

[Mark Drago]

This semicolon is technically required by bash and indeed caused a syntax error
on a system that I came across running, an admittedly very old, bash-2.04.0.

http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping

Signed-off-by: Mark Drago <markdrago@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 5c8e83a..f006d2c 100644
--- a/Makefile
+++ b/Makefile
@@ -1557,7 +1557,7 @@ endif
 		ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \
 		ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \
 		cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \
-	  done } && \
+	  done; } && \
 	./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
 
 install-doc:
-- 
1.5.6.3

Re: [PATCH] Add semicolon to curly brace group in main Makefile

[Junio C Hamano]

Mark Drago <markdrago@gmail.com> writes:

> This semicolon is technically required by bash and indeed caused a syntax error
> on a system that I came across running, an admittedly very old, bash-2.04.0.
>
> http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping
>
> Signed-off-by: Mark Drago <markdrago@gmail.com>

Thanks; it is not specific to bash.  At the end of compound_list before
the Rbrace at the end of brace_group, a separator is required.