Re: Memory overrun in http-push.c

From: Junio C Hamano <junkio@cox.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Andy Parkins <andyparkins@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Eygene Ryabinkin <rea-git@codelabs.ru>,
	Alex Riesen <raa.lkml@gmail.com>
Subject: Re: Memory overrun in http-push.c
Date: Sun, 04 Mar 2007 00:31:58 -0800	[thread overview]
Message-ID: <7virdh76kh.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0703040234510.6485@iabervon.org> (Daniel Barkalow's message of "Sun, 4 Mar 2007 03:17:31 -0500 (EST)")

Daniel Barkalow <barkalow@iabervon.org> writes:

> Actually, how about doing keyword expansion just like the new CRLF
> handling?

That part is true, but practically speaking the only thing you
can honestly replace is $Id$ with blob object name, and nothing
else.  Trying to put anything that is available via commit would
at best telling a lie and at worst ending up denying the index
(and denying the index is denying git as somebody said).  You
could fake the values for $Author$ and $Date$ from HEAD commit,
but your index may or may not match HEAD commit when you check
out path from it.