From: Daniel Barkalow <barkalow@iabervon.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Andy Parkins <andyparkins@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Eygene Ryabinkin <rea-git@codelabs.ru>,
Alex Riesen <raa.lkml@gmail.com>
Subject: Re: Memory overrun in http-push.c
Date: Sun, 4 Mar 2007 04:18:52 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0703040335110.6485@iabervon.org> (raw)
In-Reply-To: <7virdh76kh.fsf@assigned-by-dhcp.cox.net>
On Sun, 4 Mar 2007, Junio C Hamano wrote:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
> > Actually, how about doing keyword expansion just like the new CRLF
> > handling?
>
> That part is true, but practically speaking the only thing you
> can honestly replace is $Id$ with blob object name, and nothing
> else. Trying to put anything that is available via commit would
> at best telling a lie and at worst ending up denying the index
> (and denying the index is denying git as somebody said). You
> could fake the values for $Author$ and $Date$ from HEAD commit,
> but your index may or may not match HEAD commit when you check
> out path from it.
I was somehow expecting the index to be on the "working directory" side of
conversions, but that obviously doesn't work very well (since you'd get a
ton of unreachable blobs all the time that way). Even so, I think the
useful thing would the the "git-describe" for HEAD, if the index entry is
actually from HEAD (otherwise, it's a state that nobody else has seen,
right? No point in trying to specify further...). I don't think Author and
Date from a commit really works, because they wouldn't actually reflect
the last change to anything near the tag, necessarily. The commit hash, on
the other hand, tends you what to run blame on.
But, in any case, $Id <blob hash>$ would put into the working directory
file (and suitable installed derivates thereof) something that would lead
people with the repository to the actual blob, with at least a possible
context. $Id <commit hash>:<path>$, for <commit hash>=HEAD, if HEAD:<path>
is <blob hash>, should be just right.
Is it common to check out files from the index which don't match HEAD? The
only case I can think of is resetting to a state stored in the index with
update-index. I think my personal workflow is always HEAD->index->working
directory->index->new HEAD.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2007-03-04 9:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 15:15 Memory overrun in http-push.c Eygene Ryabinkin
2007-02-28 15:41 ` Andy Parkins
2007-02-28 15:42 ` Johannes Schindelin
2007-03-01 5:13 ` Eygene Ryabinkin
2007-03-01 8:15 ` Alex Riesen
2007-03-01 9:11 ` Eygene Ryabinkin
2007-03-01 9:21 ` Alex Riesen
2007-03-01 11:26 ` Eygene Ryabinkin
2007-03-01 9:32 ` Junio C Hamano
2007-03-01 10:04 ` Alex Riesen
2007-03-01 10:40 ` Andy Parkins
2007-03-01 12:00 ` Eygene Ryabinkin
2007-03-01 12:08 ` Junio C Hamano
2007-03-01 13:20 ` Eygene Ryabinkin
2007-03-01 17:11 ` Johannes Schindelin
2007-03-01 18:31 ` Andy Parkins
2007-03-01 18:41 ` Johannes Schindelin
2007-03-01 19:31 ` Andy Parkins
2007-03-01 20:43 ` Johannes Schindelin
2007-03-02 10:05 ` Andy Parkins
2007-03-02 14:46 ` Jakub Narebski
2007-03-02 15:22 ` Andy Parkins
2007-03-02 19:16 ` Johannes Schindelin
2007-03-02 19:42 ` Andy Parkins
2007-03-04 8:17 ` Daniel Barkalow
2007-03-04 8:31 ` Junio C Hamano
2007-03-04 9:18 ` Daniel Barkalow [this message]
2007-03-01 21:43 ` Alex Riesen
2007-03-01 21:54 ` Shawn O. Pearce
2007-03-01 17:52 ` Uwe Kleine-König
2007-03-02 14:38 ` Jakub Narebski
2007-03-02 15:17 ` Johannes Schindelin
2007-03-02 22:52 ` identifying blobs (was Re: Memory overrun in http-push.c) Junio C Hamano
2007-03-02 23:10 ` Linus Torvalds
2007-03-02 15:23 ` Memory overrun in http-push.c Andy Parkins
2007-03-02 15:30 ` Matthieu Moy
2007-03-02 15:48 ` Andy Parkins
2007-02-28 16:36 ` Florian Weimer
2007-03-01 5:19 ` Eygene Ryabinkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703040335110.6485@iabervon.org \
--to=barkalow@iabervon.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
--cc=rea-git@codelabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.