[PATCH 0/2] Trivial cleanups in the post-receive-email script

[PATCH 0/2] Trivial cleanups in the post-receive-email script

[mhagger]

From: Michael Haggerty <mhagger@alum.mit.edu>

Should be self-explanatory.

Michael Haggerty (2):
  post-receive-email: remove unused variable
  post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly

 contrib/hooks/post-receive-email |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

-- 
1.7.9

[PATCH 1/2] post-receive-email: remove unused variable

[mhagger]

From: Michael Haggerty <mhagger@alum.mit.edu>

prep_for_email neither is passed a fourth argument nor uses it.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 contrib/hooks/post-receive-email |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ba077c1..ac2e0ed 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -85,7 +85,6 @@ prep_for_email()
 	oldrev=$(git rev-parse $1)
 	newrev=$(git rev-parse $2)
 	refname="$3"
-	maxlines=$4
 
 	# --- Interpret
 	# 0000->1234 (create)
-- 
1.7.9

[PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly

[mhagger]

From: Michael Haggerty <mhagger@alum.mit.edu>


Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 contrib/hooks/post-receive-email |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ac2e0ed..01af9df 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -460,7 +460,7 @@ generate_delete_branch_email()
 {
 	echo "       was  $oldrev"
 	echo ""
-	echo $LOGEND
+	echo $LOGBEGIN
 	git show -s --pretty=oneline $oldrev
 	echo $LOGEND
 }
@@ -560,7 +560,7 @@ generate_delete_atag_email()
 {
 	echo "       was  $oldrev"
 	echo ""
-	echo $LOGEND
+	echo $LOGBEGIN
 	git show -s --pretty=oneline $oldrev
 	echo $LOGEND
 }
@@ -625,7 +625,7 @@ generate_delete_general_email()
 {
 	echo "       was  $oldrev"
 	echo ""
-	echo $LOGEND
+	echo $LOGBEGIN
 	git show -s --pretty=oneline $oldrev
 	echo $LOGEND
 }
-- 
1.7.9

Re: [PATCH 0/2] Trivial cleanups in the post-receive-email script

[Junio C Hamano]

Shows that nobody uses these sample script.

Will apply.  I wish all the patches were this easy ;-).

Thanks.