All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alexander Strasser <eclipse7@gmx.net>
Cc: git@vger.kernel.org, "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Subject: Re: [PATCH 6/6] t4012: Make --shortstat more robust
Date: Wed, 11 Jul 2012 15:35:44 -0700	[thread overview]
Message-ID: <7vr4sic4e7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120711221327.GA21382@akuma> (Alexander Strasser's message of "Thu, 12 Jul 2012 00:13:27 +0200")

Alexander Strasser <eclipse7@gmx.net> writes:

> The --shortstat test depends on the same scenario as the --stat
> test. Use the part of the same expected result for the --stat test
> to avoid duplicating it manually.

> diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
> index 81a9e8c..a3f6030 100755
> --- a/t/t4012-diff-binary.sh
> +++ b/t/t4012-diff-binary.sh
> @@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '
>  '
>  
>  test_expect_success 'diff --shortstat output for binary file change' '
> -	echo " 4 files changed, 2 insertions(+), 2 deletions(-)" >expected &&
> +	tail -1 expected >expect &&

"(tail|head) -n 1" is preferred.  There are the same POSIX.1
violations in a handful of other scripts, 5526, 7502, 7800 and
9146.

>  	git diff --shortstat >current &&
> -	test_i18ncmp expected current
> +	test_i18ncmp expect current
>  '
>  
>  test_expect_success 'diff --shortstat output for binary file change only' '

Other than that, the series looked good.  Thanks.

  reply	other threads:[~2012-07-11 22:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 22:13 [PATCH 6/6] t4012: Make --shortstat more robust Alexander Strasser
2012-07-11 22:35 ` Junio C Hamano [this message]
2012-07-12  4:44   ` Alexander Strasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4sic4e7.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=eclipse7@gmx.net \
    --cc=git@vger.kernel.org \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.