* [PATCH 6/6] t4012: Make --shortstat more robust
@ 2012-07-11 22:13 Alexander Strasser
2012-07-11 22:35 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Strasser @ 2012-07-11 22:13 UTC (permalink / raw)
To: git; +Cc: Zbigniew Jędrzejewski-Szmek, Junio C Hamano
The --shortstat test depends on the same scenario as the
--stat test. Use the part of the same expected result for
the --stat test to avoid duplicating it manually.
Signed-off-by: Alexander Strasser <eclipse7@gmx.net>
---
t/t4012-diff-binary.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index 81a9e8c..a3f6030 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '
'
test_expect_success 'diff --shortstat output for binary file change' '
- echo " 4 files changed, 2 insertions(+), 2 deletions(-)" >expected &&
+ tail -1 expected >expect &&
git diff --shortstat >current &&
- test_i18ncmp expected current
+ test_i18ncmp expect current
'
test_expect_success 'diff --shortstat output for binary file change only' '
--
1.7.10.2.552.gaa3bb87
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 6/6] t4012: Make --shortstat more robust
2012-07-11 22:13 [PATCH 6/6] t4012: Make --shortstat more robust Alexander Strasser
@ 2012-07-11 22:35 ` Junio C Hamano
2012-07-12 4:44 ` Alexander Strasser
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2012-07-11 22:35 UTC (permalink / raw)
To: Alexander Strasser; +Cc: git, Zbigniew Jędrzejewski-Szmek
Alexander Strasser <eclipse7@gmx.net> writes:
> The --shortstat test depends on the same scenario as the --stat
> test. Use the part of the same expected result for the --stat test
> to avoid duplicating it manually.
> diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
> index 81a9e8c..a3f6030 100755
> --- a/t/t4012-diff-binary.sh
> +++ b/t/t4012-diff-binary.sh
> @@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '
> '
>
> test_expect_success 'diff --shortstat output for binary file change' '
> - echo " 4 files changed, 2 insertions(+), 2 deletions(-)" >expected &&
> + tail -1 expected >expect &&
"(tail|head) -n 1" is preferred. There are the same POSIX.1
violations in a handful of other scripts, 5526, 7502, 7800 and
9146.
> git diff --shortstat >current &&
> - test_i18ncmp expected current
> + test_i18ncmp expect current
> '
>
> test_expect_success 'diff --shortstat output for binary file change only' '
Other than that, the series looked good. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/6] t4012: Make --shortstat more robust
2012-07-11 22:35 ` Junio C Hamano
@ 2012-07-12 4:44 ` Alexander Strasser
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Strasser @ 2012-07-12 4:44 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Zbigniew Jędrzejewski-Szmek
Hi,
seems I managed to omit a word in the short log message:
t4012: Make --shortstat *test* more robust
Junio C Hamano wrote:
> Alexander Strasser <eclipse7@gmx.net> writes:
>
> > The --shortstat test depends on the same scenario as the --stat
> > test. Use the part of the same expected result for the --stat test
> > to avoid duplicating it manually.
>
> > diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
> > index 81a9e8c..a3f6030 100755
> > --- a/t/t4012-diff-binary.sh
> > +++ b/t/t4012-diff-binary.sh
> > @@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '
> > '
> >
> > test_expect_success 'diff --shortstat output for binary file change' '
> > - echo " 4 files changed, 2 insertions(+), 2 deletions(-)" >expected &&
> > + tail -1 expected >expect &&
>
> "(tail|head) -n 1" is preferred. There are the same POSIX.1
> violations in a handful of other scripts, 5526, 7502, 7800 and
> 9146.
OK, got it.
> > git diff --shortstat >current &&
> > - test_i18ncmp expected current
> > + test_i18ncmp expect current
> > '
> >
> > test_expect_success 'diff --shortstat output for binary file change only' '
>
> Other than that, the series looked good. Thanks.
I will wait a bit longer for comments and then resend a corrected
version. Thanks for the quick reply.
Alexander
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-12 4:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-11 22:13 [PATCH 6/6] t4012: Make --shortstat more robust Alexander Strasser
2012-07-11 22:35 ` Junio C Hamano
2012-07-12 4:44 ` Alexander Strasser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.