All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: kernel test robot <lkp@intel.com>, Junaid Shahid <junaids@google.com>
Cc: kbuild-all@lists.01.org,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm'
Date: Sat, 12 Sep 2020 08:52:16 +0200	[thread overview]
Message-ID: <8012684b-145a-3355-abdd-0cf281887b41@redhat.com> (raw)
In-Reply-To: <202009111950.BkbYSqxt%lkp@intel.com>

On 11/09/20 13:43, kernel test robot wrote:
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' [-Werror=missing-prototypes]
>      633 | int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>          |            ^~~~~~~~~~~~~~~~~~~~~
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:642:13: error: no previous prototype for 'kvm_arch_pre_destroy_vm' [-Werror=missing-prototypes]
>      642 | void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>          |             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors

This makes little sense, the prototypes are in include/linux/kvm_host.h
Also this code is not architecture-dependent...

kvm-ppc guys, can you reproduce it?

Paolo

> 
> 
> Hi Junaid,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e5bd0d2afe7061562c483d301e4aabb51b13fcfa
> commit: 1aa9b9572b10529c2e64e2b8f44025d86e124308 kvm: x86: mmu: Recovery of shattered NX large pages
> date:   10 months ago
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 1aa9b9572b10529c2e64e2b8f44025d86e124308
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' [-Werror=missing-prototypes]
>      633 | int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>          |            ^~~~~~~~~~~~~~~~~~~~~
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:642:13: error: no previous prototype for 'kvm_arch_pre_destroy_vm' [-Werror=missing-prototypes]
>      642 | void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>          |             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1aa9b9572b10529c2e64e2b8f44025d86e124308
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus xlnx/master
> git checkout 1aa9b9572b10529c2e64e2b8f44025d86e124308
> vim +/kvm_arch_post_init_vm +633 arch/powerpc/kvm/../../../virt/kvm/kvm_main.c
> 
>    628	
>    629	/*
>    630	 * Called after the VM is otherwise initialized, but just before adding it to
>    631	 * the vm_list.
>    632	 */
>  > 633	int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>    634	{
>    635		return 0;
>    636	}
>    637	
>    638	/*
>    639	 * Called just after removing the VM from the vm_list, but before doing any
>    640	 * other destruction.
>    641	 */
>  > 642	void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>    643	{
>    644	}
>    645	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm'
Date: Sat, 12 Sep 2020 08:52:16 +0200	[thread overview]
Message-ID: <8012684b-145a-3355-abdd-0cf281887b41@redhat.com> (raw)
In-Reply-To: <202009111950.BkbYSqxt%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3396 bytes --]

On 11/09/20 13:43, kernel test robot wrote:
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' [-Werror=missing-prototypes]
>      633 | int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>          |            ^~~~~~~~~~~~~~~~~~~~~
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:642:13: error: no previous prototype for 'kvm_arch_pre_destroy_vm' [-Werror=missing-prototypes]
>      642 | void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>          |             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors

This makes little sense, the prototypes are in include/linux/kvm_host.h
Also this code is not architecture-dependent...

kvm-ppc guys, can you reproduce it?

Paolo

> 
> 
> Hi Junaid,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e5bd0d2afe7061562c483d301e4aabb51b13fcfa
> commit: 1aa9b9572b10529c2e64e2b8f44025d86e124308 kvm: x86: mmu: Recovery of shattered NX large pages
> date:   10 months ago
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 1aa9b9572b10529c2e64e2b8f44025d86e124308
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' [-Werror=missing-prototypes]
>      633 | int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>          |            ^~~~~~~~~~~~~~~~~~~~~
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:642:13: error: no previous prototype for 'kvm_arch_pre_destroy_vm' [-Werror=missing-prototypes]
>      642 | void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>          |             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1aa9b9572b10529c2e64e2b8f44025d86e124308
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus xlnx/master
> git checkout 1aa9b9572b10529c2e64e2b8f44025d86e124308
> vim +/kvm_arch_post_init_vm +633 arch/powerpc/kvm/../../../virt/kvm/kvm_main.c
> 
>    628	
>    629	/*
>    630	 * Called after the VM is otherwise initialized, but just before adding it to
>    631	 * the vm_list.
>    632	 */
>  > 633	int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>    634	{
>    635		return 0;
>    636	}
>    637	
>    638	/*
>    639	 * Called just after removing the VM from the vm_list, but before doing any
>    640	 * other destruction.
>    641	 */
>  > 642	void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>    643	{
>    644	}
>    645	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> 

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: kernel test robot <lkp@intel.com>, Junaid Shahid <junaids@google.com>
Cc: kbuild-all@lists.01.org,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch
Date: Sat, 12 Sep 2020 06:52:16 +0000	[thread overview]
Message-ID: <8012684b-145a-3355-abdd-0cf281887b41@redhat.com> (raw)
In-Reply-To: <202009111950.BkbYSqxt%lkp@intel.com>

On 11/09/20 13:43, kernel test robot wrote:
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' [-Werror=missing-prototypes]
>      633 | int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>          |            ^~~~~~~~~~~~~~~~~~~~~
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:642:13: error: no previous prototype for 'kvm_arch_pre_destroy_vm' [-Werror=missing-prototypes]
>      642 | void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>          |             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors

This makes little sense, the prototypes are in include/linux/kvm_host.h
Also this code is not architecture-dependent...

kvm-ppc guys, can you reproduce it?

Paolo

> 
> 
> Hi Junaid,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e5bd0d2afe7061562c483d301e4aabb51b13fcfa
> commit: 1aa9b9572b10529c2e64e2b8f44025d86e124308 kvm: x86: mmu: Recovery of shattered NX large pages
> date:   10 months ago
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 1aa9b9572b10529c2e64e2b8f44025d86e124308
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' [-Werror=missing-prototypes]
>      633 | int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>          |            ^~~~~~~~~~~~~~~~~~~~~
>>> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:642:13: error: no previous prototype for 'kvm_arch_pre_destroy_vm' [-Werror=missing-prototypes]
>      642 | void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>          |             ^~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id\x1aa9b9572b10529c2e64e2b8f44025d86e124308
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus xlnx/master
> git checkout 1aa9b9572b10529c2e64e2b8f44025d86e124308
> vim +/kvm_arch_post_init_vm +633 arch/powerpc/kvm/../../../virt/kvm/kvm_main.c
> 
>    628	
>    629	/*
>    630	 * Called after the VM is otherwise initialized, but just before adding it to
>    631	 * the vm_list.
>    632	 */
>  > 633	int __weak kvm_arch_post_init_vm(struct kvm *kvm)
>    634	{
>    635		return 0;
>    636	}
>    637	
>    638	/*
>    639	 * Called just after removing the VM from the vm_list, but before doing any
>    640	 * other destruction.
>    641	 */
>  > 642	void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
>    643	{
>    644	}
>    645	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 

  reply	other threads:[~2020-09-12  6:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 11:43 arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' kernel test robot
2020-09-11 11:43 ` kernel test robot
2020-09-12  6:52 ` Paolo Bonzini [this message]
2020-09-12  6:52   ` arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch Paolo Bonzini
2020-09-12  6:52   ` arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' Paolo Bonzini
2020-09-18  5:46   ` [kbuild-all] " Rong Chen
2020-09-18  5:46     ` [kbuild-all] Re: arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous Rong Chen
2020-09-18  5:46     ` arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:633:12: error: no previous prototype for 'kvm_arch_post_init_vm' Rong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8012684b-145a-3355-abdd-0cf281887b41@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=junaids@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.