All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Wu <david.wu@rock-chips.com>,
	davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net,
	linux@armlinux.org.uk, arnd@arndb.de, f.fainelli@gmail.com,
	peppe.cavallaro@st.com, alexandre.torgue@st.com,
	huangtao@rock-chips.com, hwg@rock-chips.com,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] net: phy: Add rockchip phy driver support
Date: Sat, 24 Jun 2017 18:05:35 +0200	[thread overview]
Message-ID: <8013275.fit4cPZyaE@phil> (raw)
In-Reply-To: <20170624140406.GL4875@lunn.ch>

Am Samstag, 24. Juni 2017, 16:04:06 CEST schrieb Andrew Lunn:
> > hmm, we do have quite a number of non-net phys in the phy subsystem
> > (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY
> > in a global sense, sounds like it could make things confusing.
> > 
> > So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so?
> 
> I follow you reasoning, but generic phy is the new kid on the
> block. It is well established that Ethernet PHYs are called
> <MANUFACTURER>_PHY.

Ok, then without further bikeshedding, let's just go with your
naming then (ROCKCHIP_PHY) :-) .


Heiko

> If you do want to consider generic phy, the logical name would be
> ROCKCHIP_PHY_PHY, since generic phy postfixes with _SATA, _USB, _PCIE,
> etc. But that does leave an issues when we have an Ethernet PHY which
> needs a generic PHY. In some sense, SERDES could be considered as
> something supported by a generic PHY...
> 
> 	Andrew
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: David Wu <david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
	alexandre.torgue-qxv4g6HH51o@public.gmane.org,
	huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	hwg-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 01/11] net: phy: Add rockchip phy driver support
Date: Sat, 24 Jun 2017 18:05:35 +0200	[thread overview]
Message-ID: <8013275.fit4cPZyaE@phil> (raw)
In-Reply-To: <20170624140406.GL4875-g2DYL2Zd6BY@public.gmane.org>

Am Samstag, 24. Juni 2017, 16:04:06 CEST schrieb Andrew Lunn:
> > hmm, we do have quite a number of non-net phys in the phy subsystem
> > (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY
> > in a global sense, sounds like it could make things confusing.
> > 
> > So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so?
> 
> I follow you reasoning, but generic phy is the new kid on the
> block. It is well established that Ethernet PHYs are called
> <MANUFACTURER>_PHY.

Ok, then without further bikeshedding, let's just go with your
naming then (ROCKCHIP_PHY) :-) .


Heiko

> If you do want to consider generic phy, the logical name would be
> ROCKCHIP_PHY_PHY, since generic phy postfixes with _SATA, _USB, _PCIE,
> etc. But that does leave an issues when we have an Ethernet PHY which
> needs a generic PHY. In some sense, SERDES could be considered as
> something supported by a generic PHY...
> 
> 	Andrew
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] net: phy: Add rockchip phy driver support
Date: Sat, 24 Jun 2017 18:05:35 +0200	[thread overview]
Message-ID: <8013275.fit4cPZyaE@phil> (raw)
In-Reply-To: <20170624140406.GL4875@lunn.ch>

Am Samstag, 24. Juni 2017, 16:04:06 CEST schrieb Andrew Lunn:
> > hmm, we do have quite a number of non-net phys in the phy subsystem
> > (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY
> > in a global sense, sounds like it could make things confusing.
> > 
> > So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so?
> 
> I follow you reasoning, but generic phy is the new kid on the
> block. It is well established that Ethernet PHYs are called
> <MANUFACTURER>_PHY.

Ok, then without further bikeshedding, let's just go with your
naming then (ROCKCHIP_PHY) :-) .


Heiko

> If you do want to consider generic phy, the logical name would be
> ROCKCHIP_PHY_PHY, since generic phy postfixes with _SATA, _USB, _PCIE,
> etc. But that does leave an issues when we have an Ethernet PHY which
> needs a generic PHY. In some sense, SERDES could be considered as
> something supported by a generic PHY...
> 
> 	Andrew
> 
> 

  reply	other threads:[~2017-06-24 16:06 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23  4:41 [PATCH 00/11] Add the mac internal ephy support David Wu
2017-06-23  4:41 ` David Wu
2017-06-23  4:41 ` David Wu
2017-06-23  4:41 ` [PATCH 01/11] net: phy: Add rockchip phy driver support David Wu
2017-06-23  4:41   ` David Wu
2017-06-23 13:55   ` Andrew Lunn
2017-06-23 13:55     ` Andrew Lunn
2017-06-23 16:18   ` Florian Fainelli
2017-06-23 16:18     ` Florian Fainelli
2017-06-24  2:10   ` Andrew Lunn
2017-06-24  2:10     ` Andrew Lunn
2017-06-24  2:19   ` Andrew Lunn
2017-06-24  2:19     ` Andrew Lunn
2017-06-24  2:19     ` Andrew Lunn
2017-06-24  8:38     ` Heiko Stuebner
2017-06-24  8:38       ` Heiko Stuebner
2017-06-24  8:38       ` Heiko Stuebner
2017-06-24 14:04       ` Andrew Lunn
2017-06-24 14:04         ` Andrew Lunn
2017-06-24 14:04         ` Andrew Lunn
2017-06-24 16:05         ` Heiko Stuebner [this message]
2017-06-24 16:05           ` Heiko Stuebner
2017-06-24 16:05           ` Heiko Stuebner
2017-06-27 14:44     ` David.Wu
2017-06-27 14:44       ` David.Wu
2017-06-27 14:46       ` Andrew Lunn
2017-06-27 14:46         ` Andrew Lunn
2017-06-27 15:07         ` David.Wu
2017-06-27 15:07           ` David.Wu
2017-06-23  4:42 ` [PATCH 02/11] multi_v7_defconfig: Make rockchip mac phy built-in David Wu
2017-06-23  4:42   ` David Wu
2017-06-23  4:42 ` [PATCH 03/11] arm64: defconfig: Enable CONFIG_ROCKCHIP_MAC_PHY David Wu
2017-06-23  4:42   ` David Wu
2017-06-23  4:42 ` [PATCH 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii() David Wu
2017-06-23  4:42   ` David Wu
2017-06-23  4:42   ` David Wu
2017-06-24  2:22   ` Andrew Lunn
2017-06-24  2:22     ` Andrew Lunn
2017-06-24  2:22     ` Andrew Lunn
2017-06-23  4:59 ` [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support David Wu
2017-06-23  4:59   ` David Wu
2017-06-23  4:59   ` David Wu
2017-06-23 16:22   ` Florian Fainelli
2017-06-23 16:22     ` Florian Fainelli
2017-06-23 16:22     ` Florian Fainelli
2017-06-27 14:21     ` David.Wu
2017-06-27 14:52       ` Andrew Lunn
2017-06-27 14:52         ` Andrew Lunn
2017-06-23 17:19   ` Heiko Stuebner
2017-06-23 17:19     ` Heiko Stuebner
2017-06-27 14:33     ` David.Wu
2017-06-27 14:33       ` David.Wu
2017-06-27 14:33       ` David.Wu
2017-06-27 15:40       ` Heiko Stuebner
2017-06-27 15:40         ` Heiko Stuebner
2017-06-27 15:40         ` Heiko Stuebner
2017-06-24  2:29   ` Andrew Lunn
2017-06-24  2:29     ` Andrew Lunn
2017-06-24  2:29     ` Andrew Lunn
2017-07-27 12:44     ` David.Wu
2017-07-27 12:44       ` David.Wu
2017-06-23  4:59 ` [PATCH 06/11] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu
2017-06-23  4:59   ` David Wu
2017-06-23  4:59   ` David Wu
2017-06-23  5:01 ` [PATCH 07/11] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu
2017-06-23  5:01   ` David Wu
2017-06-23  5:01   ` David Wu
2017-06-23  5:02 ` [PATCH 08/11] ARM: dts: rk322x: Add support internal phy for gmac David Wu
2017-06-23  5:02   ` David Wu
2017-06-23  5:02 ` [PATCH 09/11] ARM: dts: rk3228-evb: Enable the " David Wu
2017-06-23  5:02   ` David Wu
2017-06-23  5:02   ` David Wu
2017-06-23  5:03 ` [PATCH 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu
2017-06-23  5:03   ` David Wu
2017-06-23  5:04 ` [PATCH 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu
2017-06-23  5:04   ` David Wu
2017-06-23  5:04   ` David Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8013275.fit4cPZyaE@phil \
    --to=heiko@sntech.de \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=david.wu@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=huangtao@rock-chips.com \
    --cc=hwg@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=peppe.cavallaro@st.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.