* [PATCH] cpufreq: Kconfig.arm: Do not select GENERIC_CPUFREQ_CPU0
@ 2014-02-17 18:35 Fabio Estevam
2014-02-17 21:54 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2014-02-17 18:35 UTC (permalink / raw)
To: rjw; +Cc: viresh.kumar, festevam, linux-pm, Fabio Estevam
Currently the following warnings are generated when building multi_v7_defconfig:
$ make multi_v7_defconfig
warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL)
# configuration written to .config
ARM_HIGHBANK_CPUFREQ can be built with GENERIC_CPUFREQ_CPU0=n, so remove this
selection.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/cpufreq/Kconfig.arm | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 3129749..bdd3ff9 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -84,7 +84,6 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
config ARM_HIGHBANK_CPUFREQ
tristate "Calxeda Highbank-based"
depends on ARCH_HIGHBANK
- select GENERIC_CPUFREQ_CPU0
select PM_OPP
select REGULATOR
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: Kconfig.arm: Do not select GENERIC_CPUFREQ_CPU0
2014-02-17 18:35 [PATCH] cpufreq: Kconfig.arm: Do not select GENERIC_CPUFREQ_CPU0 Fabio Estevam
@ 2014-02-17 21:54 ` Rafael J. Wysocki
2014-02-18 2:26 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-02-17 21:54 UTC (permalink / raw)
To: Fabio Estevam, viresh.kumar, Shawn Guo; +Cc: festevam, linux-pm
On Monday, February 17, 2014 03:35:27 PM Fabio Estevam wrote:
> Currently the following warnings are generated when building multi_v7_defconfig:
>
> $ make multi_v7_defconfig
> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL)
> # configuration written to .config
>
> ARM_HIGHBANK_CPUFREQ can be built with GENERIC_CPUFREQ_CPU0=n, so remove this
> selection.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Viresh, Shawn, I need to know if this breaks anything.
> ---
> drivers/cpufreq/Kconfig.arm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 3129749..bdd3ff9 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -84,7 +84,6 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
> config ARM_HIGHBANK_CPUFREQ
> tristate "Calxeda Highbank-based"
> depends on ARCH_HIGHBANK
> - select GENERIC_CPUFREQ_CPU0
> select PM_OPP
> select REGULATOR
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: Kconfig.arm: Do not select GENERIC_CPUFREQ_CPU0
2014-02-17 21:54 ` Rafael J. Wysocki
@ 2014-02-18 2:26 ` Shawn Guo
2014-02-18 5:37 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2014-02-18 2:26 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Fabio Estevam, viresh.kumar, festevam, linux-pm
On Mon, Feb 17, 2014 at 10:54:08PM +0100, Rafael J. Wysocki wrote:
> On Monday, February 17, 2014 03:35:27 PM Fabio Estevam wrote:
> > Currently the following warnings are generated when building multi_v7_defconfig:
> >
> > $ make multi_v7_defconfig
> > warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL)
> > # configuration written to .config
> >
> > ARM_HIGHBANK_CPUFREQ can be built with GENERIC_CPUFREQ_CPU0=n, so remove this
> > selection.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Viresh, Shawn, I need to know if this breaks anything.
>
> > ---
> > drivers/cpufreq/Kconfig.arm | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > index 3129749..bdd3ff9 100644
> > --- a/drivers/cpufreq/Kconfig.arm
> > +++ b/drivers/cpufreq/Kconfig.arm
> > @@ -84,7 +84,6 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
> > config ARM_HIGHBANK_CPUFREQ
> > tristate "Calxeda Highbank-based"
> > depends on ARCH_HIGHBANK
> > - select GENERIC_CPUFREQ_CPU0
Dropping this selection does not break build of highbank cpufreq driver,
but will result in a non-functional driver. So maybe we need
depends on GENERIC_CPUFREQ_CPU0
Shawn
> > select PM_OPP
> > select REGULATOR
> >
> >
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: Kconfig.arm: Do not select GENERIC_CPUFREQ_CPU0
2014-02-18 2:26 ` Shawn Guo
@ 2014-02-18 5:37 ` Viresh Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2014-02-18 5:37 UTC (permalink / raw)
To: Shawn Guo; +Cc: Rafael J. Wysocki, Fabio Estevam, festevam, linux-pm
On 18 February 2014 07:56, Shawn Guo <shawn.guo@linaro.org> wrote:
> Dropping this selection does not break build of highbank cpufreq driver,
> but will result in a non-functional driver. So maybe we need
>
> depends on GENERIC_CPUFREQ_CPU0
+1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-18 5:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-17 18:35 [PATCH] cpufreq: Kconfig.arm: Do not select GENERIC_CPUFREQ_CPU0 Fabio Estevam
2014-02-17 21:54 ` Rafael J. Wysocki
2014-02-18 2:26 ` Shawn Guo
2014-02-18 5:37 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.