All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Assemble: apply sysfs rules
@ 2021-10-12 10:16 Kinga Tanska
  2021-10-19  6:50 ` Jes Sorensen
  0 siblings, 1 reply; 2+ messages in thread
From: Kinga Tanska @ 2021-10-12 10:16 UTC (permalink / raw)
  To: linux-raid; +Cc: jes

During assemblation container with quiet flag, sysfs rules are not applied.
This commit makes sysfs_rules_apply() independent from verbose condition.

Signed-off-by: Kinga Tanska <kinga.tanska@intel.com>
---
 Assemble.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Assemble.c b/Assemble.c
index 0df46244..20fd97b5 100644
--- a/Assemble.c
+++ b/Assemble.c
@@ -1125,6 +1125,7 @@ static int start_array(int mdfd,
 	}
 
 	if (content->array.level == LEVEL_CONTAINER) {
+		sysfs_rules_apply(mddev, content);
 		if (c->verbose >= 0) {
 			pr_err("Container %s has been assembled with %d drive%s",
 			       mddev, okcnt + sparecnt + journalcnt,
@@ -1132,10 +1133,8 @@ static int start_array(int mdfd,
 			if (okcnt < (unsigned)content->array.raid_disks)
 				fprintf(stderr, " (out of %d)\n",
 					content->array.raid_disks);
-			else {
+			else
 				fprintf(stderr, "\n");
-				sysfs_rules_apply(mddev, content);
-			}
 		}
 
 		if (st->ss->validate_container) {
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Assemble: apply sysfs rules
  2021-10-12 10:16 [PATCH] Assemble: apply sysfs rules Kinga Tanska
@ 2021-10-19  6:50 ` Jes Sorensen
  0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2021-10-19  6:50 UTC (permalink / raw)
  To: Kinga Tanska, linux-raid

On 10/12/21 6:16 AM, Kinga Tanska wrote:
> During assemblation container with quiet flag, sysfs rules are not applied.
> This commit makes sysfs_rules_apply() independent from verbose condition.
> 
> Signed-off-by: Kinga Tanska <kinga.tanska@intel.com>
> ---
>  Assemble.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied!

Thanks,
Jes


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-19  6:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 10:16 [PATCH] Assemble: apply sysfs rules Kinga Tanska
2021-10-19  6:50 ` Jes Sorensen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.