* [PATCH for-4.18] iommu: fix quarantine mode command line documentation
@ 2023-10-19 10:45 Roger Pau Monne
2023-10-19 10:50 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monne @ 2023-10-19 10:45 UTC (permalink / raw)
To: xen-devel
Cc: Henry Wang, Roger Pau Monne, Andrew Cooper, George Dunlap,
Jan Beulich, Julien Grall, Stefano Stabellini, Wei Liu
With the addition of per-device quarantine page tables the sink page is now
exclusive for each device, and thus writable. Update the documentation to
reflect the current implementation.
Fixes: 14dd241aad8a ('IOMMU/x86: use per-device page tables for quarantining')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
docs/misc/xen-command-line.pandoc | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 604650aaeeef..9121d8a29404 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1520,15 +1520,14 @@ boolean (e.g. `iommu=no`) can override this and leave the IOMMUs disabled.
should be enabled. Quarantining can be done in two ways: In its basic
form, all in-flight DMA will simply be forced to encounter IOMMU
faults. Since there are systems where doing so can cause host lockup,
- an alternative form is available where writes to memory will be made
- fault, but reads will be directed to a scratch page. The implication
- here is that such reads will go unnoticed, i.e. an admin may not
- become aware of the underlying problem.
+ an alternative form is available where accesses to memory will be directed
+ to a scratch page. The implication here is that such accesses will go
+ unnoticed, i.e. an admin may not become aware of the underlying problem.
Therefore, if this option is set to true (the default), Xen always
quarantines such devices; they must be explicitly assigned back to Dom0
before they can be used there again. If set to "scratch-page", still
- active DMA reads will additionally be directed to a "scratch" page. If
+ active DMA operations will additionally be directed to a "scratch" page. If
set to false, Xen will only quarantine devices the toolstack has arranged
for getting quarantined, and only in the "basic" form.
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.18] iommu: fix quarantine mode command line documentation
2023-10-19 10:45 [PATCH for-4.18] iommu: fix quarantine mode command line documentation Roger Pau Monne
@ 2023-10-19 10:50 ` Jan Beulich
2023-10-19 11:31 ` Henry Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2023-10-19 10:50 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Henry Wang, Andrew Cooper, George Dunlap, Julien Grall,
Stefano Stabellini, Wei Liu, xen-devel
On 19.10.2023 12:45, Roger Pau Monne wrote:
> With the addition of per-device quarantine page tables the sink page is now
> exclusive for each device, and thus writable. Update the documentation to
> reflect the current implementation.
>
> Fixes: 14dd241aad8a ('IOMMU/x86: use per-device page tables for quarantining')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.18] iommu: fix quarantine mode command line documentation
2023-10-19 10:50 ` Jan Beulich
@ 2023-10-19 11:31 ` Henry Wang
0 siblings, 0 replies; 3+ messages in thread
From: Henry Wang @ 2023-10-19 11:31 UTC (permalink / raw)
To: Jan Beulich, Roger Pau Monne
Cc: Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini,
Wei Liu, Xen-devel
Hi Jan, Roger,
> On Oct 19, 2023, at 18:50, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 19.10.2023 12:45, Roger Pau Monne wrote:
>> With the addition of per-device quarantine page tables the sink page is now
>> exclusive for each device, and thus writable. Update the documentation to
>> reflect the current implementation.
>>
>> Fixes: 14dd241aad8a ('IOMMU/x86: use per-device page tables for quarantining')
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
Kind regards,
Henry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-19 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-19 10:45 [PATCH for-4.18] iommu: fix quarantine mode command line documentation Roger Pau Monne
2023-10-19 10:50 ` Jan Beulich
2023-10-19 11:31 ` Henry Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.