All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
@ 2021-11-28 16:28 Philip Rinn
  2021-12-28 20:28 ` Philip Rinn
  2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
  0 siblings, 2 replies; 21+ messages in thread
From: Philip Rinn @ 2021-11-28 16:28 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
	linux-sunxi

Enable the audio hardware on the Olimex A64-OLinuXino board family.
Tested on the A64-OLinuXino-2Ge8G-IND variant.

Signed-off-by: Philip Rinn <rinni@inventati.org>

---



Changes in v2: added missing &sound {...} part

Changes in v3: removed HDMI audio part as requested by Jernej Škrabec



  .../dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++

  1 file changed, 30 insertions(+)



diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts 
b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

index ec7e2c0e82c1..6f2674bb1b7f 100644

--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

@@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {

  	};

  };



+&codec {

+	status = "okay";

+};

+

+&codec_analog {

+	cpvdd-supply = <&reg_eldo1>;

+	status = "okay";

+};

+

  &cpu0 {

  	cpu-supply = <&reg_dcdc2>;

  };

@@ -74,6 +83,10 @@ &cpu3 {

  	cpu-supply = <&reg_dcdc2>;

  };



+&dai {

+	status = "okay";

+};

+

  &de {

  	status = "okay";

  };

@@ -328,6 +341,23 @@ &simplefb_hdmi {

  	vcc-hdmi-supply = <&reg_dldo1>;

  };



+&sound {

+	simple-audio-card,aux-devs = <&codec_analog>;

+	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",

+		    "Microphone", "Microphone Jack Right",

+		    "Headphone", "Headphone Jack";

+	simple-audio-card,routing = "Left DAC", "DACL",

+		    "Right DAC", "DACR",

+		    "Headphone Jack", "HP",

+		    "ADCL", "Left ADC",

+		    "ADCR", "Right ADC",

+		    "Microphone Jack Left", "MBIAS",

+		    "MIC1", "Microphone Jack Left",

+		    "Microphone Jack Left", "HBIAS",

+		    "MIC2", "Microphone Jack Right";

+	status = "okay";

+};

+

  &uart0 {

  	pinctrl-names = "default";

  	pinctrl-0 = <&uart0_pb_pins>;

-- 

2.33.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2021-11-28 16:28 [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio Philip Rinn
@ 2021-12-28 20:28 ` Philip Rinn
  2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
  1 sibling, 0 replies; 21+ messages in thread
From: Philip Rinn @ 2021-12-28 20:28 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
	linux-sunxi

Hi all,

have I forgotten anything to get this patch applied, or have I just become too impatient waiting for an reply? 

Thanks,
Philip

On 2021-11-28 at 17:28, Philip Rinn wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>
> ---
>  .../dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index ec7e2c0e82c1..6f2674bb1b7f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
>  	};
>  };
>  
> +&codec {
> +	status = "okay";
> +};
> +
> +&codec_analog {
> +	cpvdd-supply = <&reg_eldo1>;
> +	status = "okay";
> +};
> +
>  &cpu0 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
> @@ -74,6 +83,10 @@ &cpu3 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
>  
> +&dai {
> +	status = "okay";
> +};
> +
>  &de {
>  	status = "okay";
>  };
> @@ -328,6 +341,23 @@ &simplefb_hdmi {
>  	vcc-hdmi-supply = <&reg_dldo1>;
>  };
>  
> +&sound {
> +	simple-audio-card,aux-devs = <&codec_analog>;
> +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> +		    "Microphone", "Microphone Jack Right",
> +		    "Headphone", "Headphone Jack";
> +	simple-audio-card,routing = "Left DAC", "DACL",
> +		    "Right DAC", "DACR",
> +		    "Headphone Jack", "HP",
> +		    "ADCL", "Left ADC",
> +		    "ADCR", "Right ADC",
> +		    "Microphone Jack Left", "MBIAS",
> +		    "MIC1", "Microphone Jack Left",
> +		    "Microphone Jack Left", "HBIAS",
> +		    "MIC2", "Microphone Jack Right";
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pb_pins>;
> -- 
> 2.33.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2021-11-28 16:28 [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio Philip Rinn
  2021-12-28 20:28 ` Philip Rinn
@ 2022-01-11 20:08 ` Philip Rinn
  2022-01-12  8:48   ` Maxime Ripard
  2022-01-12  9:09   ` [linux-sunxi] [PATCH RESEND v3] " Priit Laes
  1 sibling, 2 replies; 21+ messages in thread
From: Philip Rinn @ 2022-01-11 20:08 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
	linux-sunxi


[-- Attachment #1.1.1: Type: text/plain, Size: 1960 bytes --]

Enable the audio hardware on the Olimex A64-OLinuXino board family.
Tested on the A64-OLinuXino-2Ge8G-IND variant.

Signed-off-by: Philip Rinn <rinni@inventati.org>

---


Changes in v2: added missing &sound {...} part
Changes in v3: removed HDMI audio part as requested by Jernej Škrabec

  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++

  1 file changed, 30 insertions(+)



diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

index ec7e2c0e82c1..6f2674bb1b7f 100644

--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

@@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {

  	};

  };

  

+&codec {

+	status = "okay";

+};

+

+&codec_analog {

+	cpvdd-supply = <&reg_eldo1>;

+	status = "okay";

+};

+

  &cpu0 {

  	cpu-supply = <&reg_dcdc2>;

  };

@@ -74,6 +83,10 @@ &cpu3 {

  	cpu-supply = <&reg_dcdc2>;

  };

  

+&dai {

+	status = "okay";

+};

+

  &de {

  	status = "okay";

  };

@@ -328,6 +341,23 @@ &simplefb_hdmi {

  	vcc-hdmi-supply = <&reg_dldo1>;

  };

  

+&sound {

+	simple-audio-card,aux-devs = <&codec_analog>;

+	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",

+		    "Microphone", "Microphone Jack Right",

+		    "Headphone", "Headphone Jack";

+	simple-audio-card,routing = "Left DAC", "DACL",

+		    "Right DAC", "DACR",

+		    "Headphone Jack", "HP",

+		    "ADCL", "Left ADC",

+		    "ADCR", "Right ADC",

+		    "Microphone Jack Left", "MBIAS",

+		    "MIC1", "Microphone Jack Left",

+		    "Microphone Jack Left", "HBIAS",

+		    "MIC2", "Microphone Jack Right";

+	status = "okay";

+};

+

  &uart0 {

  	pinctrl-names = "default";

  	pinctrl-0 = <&uart0_pb_pins>;

-- 

2.34.1



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
@ 2022-01-12  8:48   ` Maxime Ripard
  2022-01-12 15:49     ` Philip Rinn
  2022-01-12  9:09   ` [linux-sunxi] [PATCH RESEND v3] " Priit Laes
  1 sibling, 1 reply; 21+ messages in thread
From: Maxime Ripard @ 2022-01-12  8:48 UTC (permalink / raw)
  To: Philip Rinn; +Cc: Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel, linux-sunxi


[-- Attachment #1.1: Type: text/plain, Size: 927 bytes --]

Hi,

On Tue, Jan 11, 2022 at 09:08:23PM +0100, Philip Rinn wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>
> 
> ---
> 
> 
> Changes in v2: added missing &sound {...} part
> Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
> 
>  1 file changed, 30 insertions(+)
> 
> 
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> index ec7e2c0e82c1..6f2674bb1b7f 100644
> 
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts

Your mailer scrambled the patch completely, please use git send-email

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
  2022-01-12  8:48   ` Maxime Ripard
@ 2022-01-12  9:09   ` Priit Laes
  2022-01-12 15:29     ` Philip Rinn
  1 sibling, 1 reply; 21+ messages in thread
From: Priit Laes @ 2022-01-12  9:09 UTC (permalink / raw)
  To: rinni
  Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
	linux-sunxi

On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.

I have similar patch in one of my "long forgotten branches", but I'm not 100%
sure whether the cpvdd-supply is required for codec_analog. IIRC, sound worked
for me without the issues on A64-Olinuxino board (Rev D).

'cpvdd-supply = <&reg_eldo1>' for codec_analog

And we also need to enable these configuration options in the defconfig:

+CONFIG_SND_SUN8I_CODEC=m
+CONFIG_SND_SUN50I_CODEC_ANALOG=m


> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>
> 
> ---
> 
> 
> Changes in v2: added missing &sound {...} part
> Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
> 
>  1 file changed, 30 insertions(+)
> 
> 
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> index ec7e2c0e82c1..6f2674bb1b7f 100644
> 
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
> 
>  	};
> 
>  };
> 
> 
> +&codec {
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
> +&codec_analog {
> 
> +	cpvdd-supply = <&reg_eldo1>;
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
>  &cpu0 {
> 
>  	cpu-supply = <&reg_dcdc2>;
> 
>  };
> 
> @@ -74,6 +83,10 @@ &cpu3 {
> 
>  	cpu-supply = <&reg_dcdc2>;
> 
>  };
> 
> 
> +&dai {
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
>  &de {
> 
>  	status = "okay";
> 
>  };
> 
> @@ -328,6 +341,23 @@ &simplefb_hdmi {
> 
>  	vcc-hdmi-supply = <&reg_dldo1>;
> 
>  };
> 
> 
> +&sound {
> 
> +	simple-audio-card,aux-devs = <&codec_analog>;
> 
> +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> 
> +		    "Microphone", "Microphone Jack Right",
> 
> +		    "Headphone", "Headphone Jack";
> 
> +	simple-audio-card,routing = "Left DAC", "DACL",
> 
> +		    "Right DAC", "DACR",
> 
> +		    "Headphone Jack", "HP",
> 
> +		    "ADCL", "Left ADC",
> 
> +		    "ADCR", "Right ADC",
> 
> +		    "Microphone Jack Left", "MBIAS",
> 
> +		    "MIC1", "Microphone Jack Left",
> 
> +		    "Microphone Jack Left", "HBIAS",
> 
> +		    "MIC2", "Microphone Jack Right";
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
>  &uart0 {
> 
>  	pinctrl-names = "default";
> 
>  	pinctrl-0 = <&uart0_pb_pins>;
> 
> -- 
> 
> 2.34.1
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/87654fd3-6007-6067-1851-7bc4b6de2f05%40inventati.org.




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-12  9:09   ` [linux-sunxi] [PATCH RESEND v3] " Priit Laes
@ 2022-01-12 15:29     ` Philip Rinn
  2022-01-13  6:59       ` Jernej Škrabec
  0 siblings, 1 reply; 21+ messages in thread
From: Philip Rinn @ 2022-01-12 15:29 UTC (permalink / raw)
  To: plaes
  Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
	linux-sunxi


[-- Attachment #1.1.1: Type: text/plain, Size: 977 bytes --]

Hi,

On 12.01.22 at 10:09, Priit Laes wrote:
> On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi wrote:
>> Enable the audio hardware on the Olimex A64-OLinuXino board family.
>> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> I have similar patch in one of my "long forgotten branches", but I'm not 100%
> sure whether the cpvdd-supply is required for codec_analog. IIRC, sound worked
> for me without the issues on A64-Olinuxino board (Rev D).
> 
> 'cpvdd-supply = <&reg_eldo1>' for codec_analog

I didn't test it without but as it is present for all other a64 board with audio and also in Olimex' tree I think it is needed.

> And we also need to enable these configuration options in the defconfig:
> 
> +CONFIG_SND_SUN8I_CODEC=m
> +CONFIG_SND_SUN50I_CODEC_ANALOG=m

Hm, probably, but why wasn't it added when audio was added for the other a64 boards? Or are we talking about different defconfigs here?

Best regards
Philip

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-12  8:48   ` Maxime Ripard
@ 2022-01-12 15:49     ` Philip Rinn
  2022-03-24 16:28       ` [linux-sunxi] " Philip Rinn
  2022-04-07  2:49       ` Samuel Holland
  0 siblings, 2 replies; 21+ messages in thread
From: Philip Rinn @ 2022-01-12 15:49 UTC (permalink / raw)
  To: maxime; +Cc: jernej.skrabec, linux-arm-kernel, linux-sunxi, rinni, wens

Enable the audio hardware on the Olimex A64-OLinuXino board family.
Tested on the A64-OLinuXino-2Ge8G-IND variant.

Signed-off-by: Philip Rinn <rinni@inventati.org>
---

Changes in v2: added missing &sound {...} part
Changes in v3: removed HDMI audio part as requested by Jernej Škrabec

 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index ec7e2c0e82c1..6f2674bb1b7f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
 	};
 };
 
+&codec {
+	status = "okay";
+};
+
+&codec_analog {
+	cpvdd-supply = <&reg_eldo1>;
+	status = "okay";
+};
+
 &cpu0 {
 	cpu-supply = <&reg_dcdc2>;
 };
@@ -74,6 +83,10 @@ &cpu3 {
 	cpu-supply = <&reg_dcdc2>;
 };
 
+&dai {
+	status = "okay";
+};
+
 &de {
 	status = "okay";
 };
@@ -328,6 +341,23 @@ &simplefb_hdmi {
 	vcc-hdmi-supply = <&reg_dldo1>;
 };
 
+&sound {
+	simple-audio-card,aux-devs = <&codec_analog>;
+	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
+		    "Microphone", "Microphone Jack Right",
+		    "Headphone", "Headphone Jack";
+	simple-audio-card,routing = "Left DAC", "DACL",
+		    "Right DAC", "DACR",
+		    "Headphone Jack", "HP",
+		    "ADCL", "Left ADC",
+		    "ADCR", "Right ADC",
+		    "Microphone Jack Left", "MBIAS",
+		    "MIC1", "Microphone Jack Left",
+		    "Microphone Jack Left", "HBIAS",
+		    "MIC2", "Microphone Jack Right";
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pb_pins>;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-12 15:29     ` Philip Rinn
@ 2022-01-13  6:59       ` Jernej Škrabec
  2022-01-13 16:37         ` Philip Rinn
  0 siblings, 1 reply; 21+ messages in thread
From: Jernej Škrabec @ 2022-01-13  6:59 UTC (permalink / raw)
  To: plaes, Philip Rinn
  Cc: Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel, linux-sunxi

Hi,

Dne sreda, 12. januar 2022 ob 16:29:51 CET je Philip Rinn napisal(a):
> Hi,
> 
> On 12.01.22 at 10:09, Priit Laes wrote:
> 
> > On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi
> > wrote:
> 
> >> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> >> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> > 
> > 
> > I have similar patch in one of my "long forgotten branches", but I'm not
> > 100%
 sure whether the cpvdd-supply is required for codec_analog. IIRC,
> > sound worked for me without the issues on A64-Olinuxino board (Rev D).
> > 
> > 'cpvdd-supply = <&reg_eldo1>' for codec_analog
> 
> 
> I didn't test it without but as it is present for all other a64 board with
> audio and also in Olimex' tree I think it is needed.

It's not question if it works with or without it, nor if other boards have it 
or not. Only deciding factor is board design. On schematic it can be seen that 
cpvdd is connected to eldo1, so having this property is correct, mandatory 
even.

Best regards,
Jernej
 
> 
> > And we also need to enable these configuration options in the defconfig:
> > 
> > +CONFIG_SND_SUN8I_CODEC=m
> > +CONFIG_SND_SUN50I_CODEC_ANALOG=m
> 
> 
> Hm, probably, but why wasn't it added when audio was added for the other a64
> boards? Or are we talking about different defconfigs here?
 
> Best regards
> Philip





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-13  6:59       ` Jernej Škrabec
@ 2022-01-13 16:37         ` Philip Rinn
  0 siblings, 0 replies; 21+ messages in thread
From: Philip Rinn @ 2022-01-13 16:37 UTC (permalink / raw)
  To: Jernej Škrabec, plaes
  Cc: Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel, linux-sunxi


[-- Attachment #1.1.1: Type: text/plain, Size: 1819 bytes --]

Hi,

On 13.01.22 at 07:59, Jernej Škrabec wrote:
> Hi,
> 
> Dne sreda, 12. januar 2022 ob 16:29:51 CET je Philip Rinn napisal(a):
>> Hi,
>>
>> On 12.01.22 at 10:09, Priit Laes wrote:
>>
>>> On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi
>>> wrote:
>>
>>>> Enable the audio hardware on the Olimex A64-OLinuXino board family.
>>>> Tested on the A64-OLinuXino-2Ge8G-IND variant.
>>>
>>>
>>> I have similar patch in one of my "long forgotten branches", but I'm not
>>> 100%
>>> sure whether the cpvdd-supply is required for codec_analog. IIRC,
>>> sound worked for me without the issues on A64-Olinuxino board (Rev D).
>>>
>>> 'cpvdd-supply = <&reg_eldo1>' for codec_analog
>>
>>
>> I didn't test it without but as it is present for all other a64 board with
>> audio and also in Olimex' tree I think it is needed.
> 
> It's not question if it works with or without it, nor if other boards have it
> or not. Only deciding factor is board design. On schematic it can be seen that
> cpvdd is connected to eldo1, so having this property is correct, mandatory
> even.

Very true and it's easy to verify with the schematic available: https://raw.githubusercontent.com/OLIMEX/OLINUXINO/master/HARDWARE/A64-OLinuXino/1.%20Latest%20hardware%20revision/A64-OLinuXino%20hardware%20revision%20E/A64-OlinuXino_Rev_E.pdf

So from my point of view the patch is correct.

Best regards
Philip

> 
> Best regards,
> Jernej
>   
>>
>>> And we also need to enable these configuration options in the defconfig:
>>>
>>> +CONFIG_SND_SUN8I_CODEC=m
>>> +CONFIG_SND_SUN50I_CODEC_ANALOG=m
>>
>>
>> Hm, probably, but why wasn't it added when audio was added for the other a64
>> boards? Or are we talking about different defconfigs here?
>   
>> Best regards
>> Philip

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [linux-sunxi] Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-12 15:49     ` Philip Rinn
@ 2022-03-24 16:28       ` Philip Rinn
  2022-03-26  6:45         ` Jernej Škrabec
  2022-04-07  2:49       ` Samuel Holland
  1 sibling, 1 reply; 21+ messages in thread
From: Philip Rinn @ 2022-03-24 16:28 UTC (permalink / raw)
  To: maxime, jernej.skrabec, linux-arm-kernel, linux-sunxi, wens

Hi,

any chance this patch get applied? It seems it will not make it into 
5.18 ... what did I miss?

Best regards
Philip

On 12.01.2022 at 16:49:27, Philip Rinn wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>
> ---
> 
> Changes in v2: added missing &sound {...} part
> Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 
> +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index ec7e2c0e82c1..6f2674bb1b7f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
>  	};
>  };
> 
> +&codec {
> +	status = "okay";
> +};
> +
> +&codec_analog {
> +	cpvdd-supply = <&reg_eldo1>;
> +	status = "okay";
> +};
> +
>  &cpu0 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
> @@ -74,6 +83,10 @@ &cpu3 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
> 
> +&dai {
> +	status = "okay";
> +};
> +
>  &de {
>  	status = "okay";
>  };
> @@ -328,6 +341,23 @@ &simplefb_hdmi {
>  	vcc-hdmi-supply = <&reg_dldo1>;
>  };
> 
> +&sound {
> +	simple-audio-card,aux-devs = <&codec_analog>;
> +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> +		    "Microphone", "Microphone Jack Right",
> +		    "Headphone", "Headphone Jack";
> +	simple-audio-card,routing = "Left DAC", "DACL",
> +		    "Right DAC", "DACR",
> +		    "Headphone Jack", "HP",
> +		    "ADCL", "Left ADC",
> +		    "ADCR", "Right ADC",
> +		    "Microphone Jack Left", "MBIAS",
> +		    "MIC1", "Microphone Jack Left",
> +		    "Microphone Jack Left", "HBIAS",
> +		    "MIC2", "Microphone Jack Right";
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pb_pins>;
> --
> 2.34.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: Re: [linux-sunxi] Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-03-24 16:28       ` [linux-sunxi] " Philip Rinn
@ 2022-03-26  6:45         ` Jernej Škrabec
  0 siblings, 0 replies; 21+ messages in thread
From: Jernej Škrabec @ 2022-03-26  6:45 UTC (permalink / raw)
  To: maxime, linux-arm-kernel, linux-sunxi, wens, Philip Rinn

Hi,

Dne četrtek, 24. marec 2022 ob 17:28:50 CET je Philip Rinn napisal(a):
> Hi,
> 
> any chance this patch get applied? It seems it will not make it into 
> 5.18 ... what did I miss?

Not much, sometimes patches are overlooked. I'll review it again, and if 
everthing is fine, it will be applied for 5.19 once 5.18-rc1 is out.

Sorry for taking it so long.

Best regards,
Jernej

> 
> Best regards
> Philip
> 
> On 12.01.2022 at 16:49:27, Philip Rinn wrote:
> > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > Tested on the A64-OLinuXino-2Ge8G-IND variant.
> > 
> > Signed-off-by: Philip Rinn <rinni@inventati.org>
> > ---
> > 
> > Changes in v2: added missing &sound {...} part
> > Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> > 
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 
> > +++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts 
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > index ec7e2c0e82c1..6f2674bb1b7f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
> >  	};
> >  };
> > 
> > +&codec {
> > +	status = "okay";
> > +};
> > +
> > +&codec_analog {
> > +	cpvdd-supply = <&reg_eldo1>;
> > +	status = "okay";
> > +};
> > +
> >  &cpu0 {
> >  	cpu-supply = <&reg_dcdc2>;
> >  };
> > @@ -74,6 +83,10 @@ &cpu3 {
> >  	cpu-supply = <&reg_dcdc2>;
> >  };
> > 
> > +&dai {
> > +	status = "okay";
> > +};
> > +
> >  &de {
> >  	status = "okay";
> >  };
> > @@ -328,6 +341,23 @@ &simplefb_hdmi {
> >  	vcc-hdmi-supply = <&reg_dldo1>;
> >  };
> > 
> > +&sound {
> > +	simple-audio-card,aux-devs = <&codec_analog>;
> > +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> > +		    "Microphone", "Microphone Jack Right",
> > +		    "Headphone", "Headphone Jack";
> > +	simple-audio-card,routing = "Left DAC", "DACL",
> > +		    "Right DAC", "DACR",
> > +		    "Headphone Jack", "HP",
> > +		    "ADCL", "Left ADC",
> > +		    "ADCR", "Right ADC",
> > +		    "Microphone Jack Left", "MBIAS",
> > +		    "MIC1", "Microphone Jack Left",
> > +		    "Microphone Jack Left", "HBIAS",
> > +		    "MIC2", "Microphone Jack Right";
> > +	status = "okay";
> > +};
> > +
> >  &uart0 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&uart0_pb_pins>;
> > --
> > 2.34.1
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-01-12 15:49     ` Philip Rinn
  2022-03-24 16:28       ` [linux-sunxi] " Philip Rinn
@ 2022-04-07  2:49       ` Samuel Holland
  2022-04-07  5:02         ` Jernej Škrabec
  2022-04-07 15:51           ` Philip Rinn
  1 sibling, 2 replies; 21+ messages in thread
From: Samuel Holland @ 2022-04-07  2:49 UTC (permalink / raw)
  To: Philip Rinn, jernej.skrabec; +Cc: maxime, linux-arm-kernel, linux-sunxi, wens

On 1/12/22 9:49 AM, Philip Rinn wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>
> ---
> 
> Changes in v2: added missing &sound {...} part
> Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index ec7e2c0e82c1..6f2674bb1b7f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
>  	};
>  };
>  
> +&codec {
> +	status = "okay";
> +};
> +
> +&codec_analog {
> +	cpvdd-supply = <&reg_eldo1>;
> +	status = "okay";
> +};
> +
>  &cpu0 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
> @@ -74,6 +83,10 @@ &cpu3 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
>  
> +&dai {
> +	status = "okay";
> +};
> +
>  &de {
>  	status = "okay";
>  };
> @@ -328,6 +341,23 @@ &simplefb_hdmi {
>  	vcc-hdmi-supply = <&reg_dldo1>;
>  };
>  
> +&sound {
> +	simple-audio-card,aux-devs = <&codec_analog>;
> +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> +		    "Microphone", "Microphone Jack Right",
> +		    "Headphone", "Headphone Jack";
> +	simple-audio-card,routing = "Left DAC", "DACL",
> +		    "Right DAC", "DACR",
> +		    "Headphone Jack", "HP",
> +		    "ADCL", "Left ADC",
> +		    "ADCR", "Right ADC",
> +		    "Microphone Jack Left", "MBIAS",
> +		    "MIC1", "Microphone Jack Left",
> +		    "Microphone Jack Left", "HBIAS",

According to the schematic, both sides of the microphone jack are biased to
MBIAS. Otherwise, this patch looks good to me.

Regards,
Samuel

> +		    "MIC2", "Microphone Jack Right";
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pb_pins>;
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-04-07  2:49       ` Samuel Holland
@ 2022-04-07  5:02         ` Jernej Škrabec
  2022-04-07 15:51           ` Philip Rinn
  1 sibling, 0 replies; 21+ messages in thread
From: Jernej Škrabec @ 2022-04-07  5:02 UTC (permalink / raw)
  To: Philip Rinn, Samuel Holland; +Cc: maxime, linux-arm-kernel, linux-sunxi, wens

Dne četrtek, 07. april 2022 ob 04:49:03 CEST je Samuel Holland napisal(a):
> On 1/12/22 9:49 AM, Philip Rinn wrote:
> > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > Tested on the A64-OLinuXino-2Ge8G-IND variant.

Please also update recipients, there were some maintainer changes recently and 
you're missing official linux-sunxi ML (not google groups). scripts/
get_maintainer.pl is your friend here.

Best regards,
Jernej

> > 
> > Signed-off-by: Philip Rinn <rinni@inventati.org>
> > ---
> > 
> > Changes in v2: added missing &sound {...} part
> > Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> > 
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30
> >  +++++++++++++++++++ 1 file changed, 30 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts index
> > ec7e2c0e82c1..6f2674bb1b7f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
> > 
> >  	};
> >  
> >  };
> > 
> > +&codec {
> > +	status = "okay";
> > +};
> > +
> > +&codec_analog {
> > +	cpvdd-supply = <&reg_eldo1>;
> > +	status = "okay";
> > +};
> > +
> > 
> >  &cpu0 {
> >  
> >  	cpu-supply = <&reg_dcdc2>;
> >  
> >  };
> > 
> > @@ -74,6 +83,10 @@ &cpu3 {
> > 
> >  	cpu-supply = <&reg_dcdc2>;
> >  
> >  };
> > 
> > +&dai {
> > +	status = "okay";
> > +};
> > +
> > 
> >  &de {
> >  
> >  	status = "okay";
> >  
> >  };
> > 
> > @@ -328,6 +341,23 @@ &simplefb_hdmi {
> > 
> >  	vcc-hdmi-supply = <&reg_dldo1>;
> >  
> >  };
> > 
> > +&sound {
> > +	simple-audio-card,aux-devs = <&codec_analog>;
> > +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> > +		    "Microphone", "Microphone Jack Right",
> > +		    "Headphone", "Headphone Jack";
> > +	simple-audio-card,routing = "Left DAC", "DACL",
> > +		    "Right DAC", "DACR",
> > +		    "Headphone Jack", "HP",
> > +		    "ADCL", "Left ADC",
> > +		    "ADCR", "Right ADC",
> > +		    "Microphone Jack Left", "MBIAS",
> > +		    "MIC1", "Microphone Jack Left",
> > +		    "Microphone Jack Left", "HBIAS",
> 
> According to the schematic, both sides of the microphone jack are biased to
> MBIAS. Otherwise, this patch looks good to me.
> 
> Regards,
> Samuel
> 
> > +		    "MIC2", "Microphone Jack Right";
> > +	status = "okay";
> > +};
> > +
> > 
> >  &uart0 {
> >  
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&uart0_pb_pins>;





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-04-07  2:49       ` Samuel Holland
@ 2022-04-07 15:51           ` Philip Rinn
  2022-04-07 15:51           ` Philip Rinn
  1 sibling, 0 replies; 21+ messages in thread
From: Philip Rinn @ 2022-04-07 15:51 UTC (permalink / raw)
  To: robh+dt, krzk+dt, wens, jernej.skrabec, samuel, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: Philip Rinn

Enable the audio hardware on the Olimex A64-OLinuXino board family.
Tested on the A64-OLinuXino-2Ge8G-IND variant.

Signed-off-by: Philip Rinn <rinni@inventati.org>
---

Changes in v2: added missing &sound {...} part
Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
Changes in v4: right microphone jack is also biased on MBIAS

 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index ec7e2c0e82c1..6f2674bb1b7f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
 	};
 };
 
+&codec {
+	status = "okay";
+};
+
+&codec_analog {
+	cpvdd-supply = <&reg_eldo1>;
+	status = "okay";
+};
+
 &cpu0 {
 	cpu-supply = <&reg_dcdc2>;
 };
@@ -74,6 +83,10 @@ &cpu3 {
 	cpu-supply = <&reg_dcdc2>;
 };
 
+&dai {
+	status = "okay";
+};
+
 &de {
 	status = "okay";
 };
@@ -328,6 +341,23 @@ &simplefb_hdmi {
 	vcc-hdmi-supply = <&reg_dldo1>;
 };
 
+&sound {
+	simple-audio-card,aux-devs = <&codec_analog>;
+	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
+		    "Microphone", "Microphone Jack Right",
+		    "Headphone", "Headphone Jack";
+	simple-audio-card,routing = "Left DAC", "DACL",
+		    "Right DAC", "DACR",
+		    "Headphone Jack", "HP",
+		    "ADCL", "Left ADC",
+		    "ADCR", "Right ADC",
+		    "Microphone Jack Left", "MBIAS",
+		    "MIC1", "Microphone Jack Left",
+		    "Microphone Jack Right", "MBIAS",
+		    "MIC2", "Microphone Jack Right";
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pb_pins>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 21+ messages in thread
* [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
@ 2022-04-07 15:51           ` Philip Rinn
  0 siblings, 0 replies; 21+ messages in thread
From: Philip Rinn @ 2022-04-07 15:51 UTC (permalink / raw)
  To: robh+dt, krzk+dt, wens, jernej.skrabec, samuel, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: Philip Rinn

Enable the audio hardware on the Olimex A64-OLinuXino board family.
Tested on the A64-OLinuXino-2Ge8G-IND variant.

Signed-off-by: Philip Rinn <rinni@inventati.org>
---

Changes in v2: added missing &sound {...} part
Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
Changes in v4: right microphone jack is also biased on MBIAS

 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index ec7e2c0e82c1..6f2674bb1b7f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
 	};
 };
 
+&codec {
+	status = "okay";
+};
+
+&codec_analog {
+	cpvdd-supply = <&reg_eldo1>;
+	status = "okay";
+};
+
 &cpu0 {
 	cpu-supply = <&reg_dcdc2>;
 };
@@ -74,6 +83,10 @@ &cpu3 {
 	cpu-supply = <&reg_dcdc2>;
 };
 
+&dai {
+	status = "okay";
+};
+
 &de {
 	status = "okay";
 };
@@ -328,6 +341,23 @@ &simplefb_hdmi {
 	vcc-hdmi-supply = <&reg_dldo1>;
 };
 
+&sound {
+	simple-audio-card,aux-devs = <&codec_analog>;
+	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
+		    "Microphone", "Microphone Jack Right",
+		    "Headphone", "Headphone Jack";
+	simple-audio-card,routing = "Left DAC", "DACL",
+		    "Right DAC", "DACR",
+		    "Headphone Jack", "HP",
+		    "ADCL", "Left ADC",
+		    "ADCR", "Right ADC",
+		    "Microphone Jack Left", "MBIAS",
+		    "MIC1", "Microphone Jack Left",
+		    "Microphone Jack Right", "MBIAS",
+		    "MIC2", "Microphone Jack Right";
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pb_pins>;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 21+ messages in thread
* Re: [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-04-07 15:51           ` Philip Rinn
@ 2022-04-07 22:06             ` Samuel Holland
  -1 siblings, 0 replies; 21+ messages in thread
From: Samuel Holland @ 2022-04-07 22:06 UTC (permalink / raw)
  To: Philip Rinn, wens, jernej.skrabec
  Cc: robh+dt, krzk+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel

On 4/7/22 10:51 AM, Philip Rinn wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>

Acked-by: Samuel Holland <samuel@sholland.org>

Thanks!

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
@ 2022-04-07 22:06             ` Samuel Holland
  0 siblings, 0 replies; 21+ messages in thread
From: Samuel Holland @ 2022-04-07 22:06 UTC (permalink / raw)
  To: Philip Rinn, wens, jernej.skrabec
  Cc: robh+dt, krzk+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel

On 4/7/22 10:51 AM, Philip Rinn wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.
> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>

Acked-by: Samuel Holland <samuel@sholland.org>

Thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: Re: [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-04-07 22:06             ` Samuel Holland
@ 2022-04-10 18:23               ` Jernej Škrabec
  -1 siblings, 0 replies; 21+ messages in thread
From: Jernej Škrabec @ 2022-04-10 18:23 UTC (permalink / raw)
  To: Philip Rinn, wens, Samuel Holland
  Cc: robh+dt, krzk+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel

Dne petek, 08. april 2022 ob 00:06:01 CEST je Samuel Holland napisal(a):
> On 4/7/22 10:51 AM, Philip Rinn wrote:
> > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > Tested on the A64-OLinuXino-2Ge8G-IND variant.
> > 
> > Signed-off-by: Philip Rinn <rinni@inventati.org>
> 
> Acked-by: Samuel Holland <samuel@sholland.org>

Applied to sunxi/dt-for-5.19. Thanks!

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: Re: [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
@ 2022-04-10 18:23               ` Jernej Škrabec
  0 siblings, 0 replies; 21+ messages in thread
From: Jernej Škrabec @ 2022-04-10 18:23 UTC (permalink / raw)
  To: Philip Rinn, wens, Samuel Holland
  Cc: robh+dt, krzk+dt, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel

Dne petek, 08. april 2022 ob 00:06:01 CEST je Samuel Holland napisal(a):
> On 4/7/22 10:51 AM, Philip Rinn wrote:
> > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > Tested on the A64-OLinuXino-2Ge8G-IND variant.
> > 
> > Signed-off-by: Philip Rinn <rinni@inventati.org>
> 
> Acked-by: Samuel Holland <samuel@sholland.org>

Applied to sunxi/dt-for-5.19. Thanks!

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
  2022-04-10 18:23               ` Jernej Škrabec
@ 2022-05-08 17:38                 ` Milan P. Stanić
  -1 siblings, 0 replies; 21+ messages in thread
From: Milan P. Stanić @ 2022-05-08 17:38 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Philip Rinn, wens, Samuel Holland, robh+dt, krzk+dt, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

On Sun, 2022-04-10 at 20:23, Jernej Škrabec wrote:
> Dne petek, 08. april 2022 ob 00:06:01 CEST je Samuel Holland napisal(a):
> > On 4/7/22 10:51 AM, Philip Rinn wrote:
> > > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > > Tested on the A64-OLinuXino-2Ge8G-IND variant.
> > > 
> > > Signed-off-by: Philip Rinn <rinni@inventati.org>
> > 
> > Acked-by: Samuel Holland <samuel@sholland.org>
> 
> Applied to sunxi/dt-for-5.19. Thanks!

About week ago I made nearly same patch but Jernej pointed me to this
one. I applied this patch and it works like one I made.

Audio output works fine, but recording doesn't work at all in my tests.
I can hear myself from microphone on headphones quite fine but 'arecord'
records only some kind of white noise. Tried all alsamixer widget
combinations but didn't managed to record anything.

Kind regards

^ permalink raw reply	[flat|nested] 21+ messages in thread
* Re: [PATCH v4] arm64: dts: allwinner: a64: olinuxino: Enable audio
@ 2022-05-08 17:38                 ` Milan P. Stanić
  0 siblings, 0 replies; 21+ messages in thread
From: Milan P. Stanić @ 2022-05-08 17:38 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Philip Rinn, wens, Samuel Holland, robh+dt, krzk+dt, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

On Sun, 2022-04-10 at 20:23, Jernej Škrabec wrote:
> Dne petek, 08. april 2022 ob 00:06:01 CEST je Samuel Holland napisal(a):
> > On 4/7/22 10:51 AM, Philip Rinn wrote:
> > > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > > Tested on the A64-OLinuXino-2Ge8G-IND variant.
> > > 
> > > Signed-off-by: Philip Rinn <rinni@inventati.org>
> > 
> > Acked-by: Samuel Holland <samuel@sholland.org>
> 
> Applied to sunxi/dt-for-5.19. Thanks!

About week ago I made nearly same patch but Jernej pointed me to this
one. I applied this patch and it works like one I made.

Audio output works fine, but recording doesn't work at all in my tests.
I can hear myself from microphone on headphones quite fine but 'arecord'
records only some kind of white noise. Tried all alsamixer widget
combinations but didn't managed to record anything.

Kind regards

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread
end of thread, other threads:[~2022-05-08 17:45 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-28 16:28 [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio Philip Rinn
2021-12-28 20:28 ` Philip Rinn
2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
2022-01-12  8:48   ` Maxime Ripard
2022-01-12 15:49     ` Philip Rinn
2022-03-24 16:28       ` [linux-sunxi] " Philip Rinn
2022-03-26  6:45         ` Jernej Škrabec
2022-04-07  2:49       ` Samuel Holland
2022-04-07  5:02         ` Jernej Škrabec
2022-04-07 15:51         ` [PATCH v4] " Philip Rinn
2022-04-07 15:51           ` Philip Rinn
2022-04-07 22:06           ` Samuel Holland
2022-04-07 22:06             ` Samuel Holland
2022-04-10 18:23             ` Jernej Škrabec
2022-04-10 18:23               ` Jernej Škrabec
2022-05-08 17:38               ` Milan P. Stanić
2022-05-08 17:38                 ` Milan P. Stanić
2022-01-12  9:09   ` [linux-sunxi] [PATCH RESEND v3] " Priit Laes
2022-01-12 15:29     ` Philip Rinn
2022-01-13  6:59       ` Jernej Škrabec
2022-01-13 16:37         ` Philip Rinn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.