* Re: Adding iTCO_wdt fixes into 4.9-stable?
[not found] ` <20181119103125.GM4179@lahna.fi.intel.com>
@ 2018-11-19 16:32 ` Krzysztof Olędzki
2018-11-23 19:26 ` Sasha Levin
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Olędzki @ 2018-11-19 16:32 UTC (permalink / raw)
To: Mika Westerberg; +Cc: gregkh, rafael.j.wysocki, stable
+cc stable@vger.kernel.org
W dniu 2018-11-19 o 02:31, Mika Westerberg pisze:
> On Sun, Nov 18, 2018 at 07:13:18PM -0800, Krzysztof Olędzki wrote:
>> Hello Mika, Rafael, Greg,
>
> Hi,
>
>> Would it be possible to include the following two patches in 4.9-stable:
>> - "ACPI / watchdog: Prefer iTCO_wdt on Lenovo Z50-70"
>> - "ACPI / watchdog: Prefer iTCO_wdt always when WDAT table uses RTC SRAM"
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=a0a37862a4e1844793d39aca9ccb8fecbdcb8659
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=5a802a7a285c8877ca872e44eeb0f06afcb5212f
>>
>> Context: I just upgrade one of my servers from 4.4.161 to 4.9.137 and
>> run into a problem of not working RTC and watchdog. Adding these two
>> patches fixed the issue. No changes were necessary for them to be applied.
>
> I think the best way to get these included in stable trees is to send
> the commit ids with the above explanation to stable@vger.kernel.org.
Thank you Mika! I forgot how the process works. :/
The commits are:
a0a37862a4e1844793d39aca9ccb8fecbdcb8659
5a802a7a285c8877ca872e44eeb0f06afcb5212f
It also looks like the first patch is already in 4.14-stable, just not
in 4.9.
- a0a37862a4e1844793d39aca9ccb8fecbdcb8659 was included in 4.14.51:
https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.14.51
However, it does not look like the 2nd one has been included in 4.14
yet. Would it be then possible to add
5a802a7a285c8877ca872e44eeb0f06afcb5212f to both 4.9-stable and 4.14-stable?
The impacted system is:
Dell Inc. PowerEdge T110 II/0PM2CW, BIOS 2.10.0 05/24/2018
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adding iTCO_wdt fixes into 4.9-stable?
2018-11-19 16:32 ` Adding iTCO_wdt fixes into 4.9-stable? Krzysztof Olędzki
@ 2018-11-23 19:26 ` Sasha Levin
2018-11-25 6:01 ` Krzysztof Olędzki
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2018-11-23 19:26 UTC (permalink / raw)
To: Krzysztof Olędzki; +Cc: Mika Westerberg, gregkh, rafael.j.wysocki, stable
On Mon, Nov 19, 2018 at 08:32:03AM -0800, Krzysztof Olędzki wrote:
>+cc stable@vger.kernel.org
>
>W dniu 2018-11-19 o 02:31, Mika Westerberg pisze:
>>On Sun, Nov 18, 2018 at 07:13:18PM -0800, Krzysztof Olędzki wrote:
>>>Hello Mika, Rafael, Greg,
>>
>>Hi,
>>
>>>Would it be possible to include the following two patches in 4.9-stable:
>>> - "ACPI / watchdog: Prefer iTCO_wdt on Lenovo Z50-70"
>>> - "ACPI / watchdog: Prefer iTCO_wdt always when WDAT table uses RTC SRAM"
>>>
>>>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=a0a37862a4e1844793d39aca9ccb8fecbdcb8659
>>>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=5a802a7a285c8877ca872e44eeb0f06afcb5212f
>>>
>>>Context: I just upgrade one of my servers from 4.4.161 to 4.9.137 and
>>>run into a problem of not working RTC and watchdog. Adding these two
>>>patches fixed the issue. No changes were necessary for them to be applied.
>>
>>I think the best way to get these included in stable trees is to send
>>the commit ids with the above explanation to stable@vger.kernel.org.
>
>Thank you Mika! I forgot how the process works. :/
>
>The commits are:
> a0a37862a4e1844793d39aca9ccb8fecbdcb8659
> 5a802a7a285c8877ca872e44eeb0f06afcb5212f
>
>It also looks like the first patch is already in 4.14-stable, just not
>in 4.9.
> - a0a37862a4e1844793d39aca9ccb8fecbdcb8659 was included in 4.14.51:
>https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.14.51
>
>However, it does not look like the 2nd one has been included in 4.14
>yet. Would it be then possible to add
>5a802a7a285c8877ca872e44eeb0f06afcb5212f to both 4.9-stable and
>4.14-stable?
>
>The impacted system is:
> Dell Inc. PowerEdge T110 II/0PM2CW, BIOS 2.10.0 05/24/2018
>
>Krzysztof
Okay, I've queued the second commit to 4.14, and both to 4.9.
What about older stable kernels?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adding iTCO_wdt fixes into 4.9-stable?
2018-11-23 19:26 ` Sasha Levin
@ 2018-11-25 6:01 ` Krzysztof Olędzki
2018-11-26 9:24 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Olędzki @ 2018-11-25 6:01 UTC (permalink / raw)
To: Sasha Levin; +Cc: Mika Westerberg, gregkh, rafael.j.wysocki, stable
Hi,
W dniu 2018-11-23 o 11:26, Sasha Levin pisze:
> On Mon, Nov 19, 2018 at 08:32:03AM -0800, Krzysztof Olędzki wrote:
>> +cc stable@vger.kernel.org
>>
>> W dniu 2018-11-19 o 02:31, Mika Westerberg pisze:
>>> On Sun, Nov 18, 2018 at 07:13:18PM -0800, Krzysztof Olędzki wrote:
>>>> Hello Mika, Rafael, Greg,
>>>
>>> Hi,
>>>
>>>> Would it be possible to include the following two patches in
>>>> 4.9-stable:
>>>> - "ACPI / watchdog: Prefer iTCO_wdt on Lenovo Z50-70"
>>>> - "ACPI / watchdog: Prefer iTCO_wdt always when WDAT table uses RTC
>>>> SRAM"
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=a0a37862a4e1844793d39aca9ccb8fecbdcb8659
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=5a802a7a285c8877ca872e44eeb0f06afcb5212f
>>>>
>>>>
>>>> Context: I just upgrade one of my servers from 4.4.161 to 4.9.137 and
>>>> run into a problem of not working RTC and watchdog. Adding these two
>>>> patches fixed the issue. No changes were necessary for them to be
>>>> applied.
>>>
>>> I think the best way to get these included in stable trees is to send
>>> the commit ids with the above explanation to stable@vger.kernel.org.
>>
>> Thank you Mika! I forgot how the process works. :/
>>
>> The commits are:
>> a0a37862a4e1844793d39aca9ccb8fecbdcb8659
>> 5a802a7a285c8877ca872e44eeb0f06afcb5212f
>>
>> It also looks like the first patch is already in 4.14-stable, just not
>> in 4.9.
>> - a0a37862a4e1844793d39aca9ccb8fecbdcb8659 was included in 4.14.51:
>> https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.14.51
>>
>> However, it does not look like the 2nd one has been included in 4.14
>> yet. Would it be then possible to add
>> 5a802a7a285c8877ca872e44eeb0f06afcb5212f to both 4.9-stable and
>> 4.14-stable?
>>
>> The impacted system is:
>> Dell Inc. PowerEdge T110 II/0PM2CW, BIOS 2.10.0 05/24/2018
>>
>> Krzysztof
>
> Okay, I've queued the second commit to 4.14, and both to 4.9.
>
> What about older stable kernels?
Perfect, thank you so much!
I think older kernels should be fine, like I said - everything worked
under 4.4-stable. I suspect this is because of some ACPI / WDAT
improvements in 4.9, or between 4.5 - 4.8 for which we no longer support
-stable. Mika, do you know which change exactly introduce this side effect?
Thanks,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adding iTCO_wdt fixes into 4.9-stable?
2018-11-25 6:01 ` Krzysztof Olędzki
@ 2018-11-26 9:24 ` Mika Westerberg
2018-11-26 10:00 ` Sasha Levin
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2018-11-26 9:24 UTC (permalink / raw)
To: Krzysztof Olędzki; +Cc: Sasha Levin, gregkh, rafael.j.wysocki, stable
On Sat, Nov 24, 2018 at 10:01:48PM -0800, Krzysztof Olędzki wrote:
> I think older kernels should be fine, like I said - everything worked under
> 4.4-stable. I suspect this is because of some ACPI / WDAT improvements in
> 4.9, or between 4.5 - 4.8 for which we no longer support -stable. Mika, do
> you know which change exactly introduce this side effect?
IIRC it was the introduction of WDAT driver itself in commit
058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware
watchdog"). The driver went into v4.9 so I don't think older stable
kernels need this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adding iTCO_wdt fixes into 4.9-stable?
2018-11-26 9:24 ` Mika Westerberg
@ 2018-11-26 10:00 ` Sasha Levin
2018-11-27 7:56 ` Krzysztof Olędzki
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2018-11-26 10:00 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Krzysztof Olędzki, gregkh, rafael.j.wysocki, stable
On Mon, Nov 26, 2018 at 11:24:18AM +0200, Mika Westerberg wrote:
>On Sat, Nov 24, 2018 at 10:01:48PM -0800, Krzysztof Olędzki wrote:
>> I think older kernels should be fine, like I said - everything worked under
>> 4.4-stable. I suspect this is because of some ACPI / WDAT improvements in
>> 4.9, or between 4.5 - 4.8 for which we no longer support -stable. Mika, do
>> you know which change exactly introduce this side effect?
>
>IIRC it was the introduction of WDAT driver itself in commit
>058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware
>watchdog"). The driver went into v4.9 so I don't think older stable
>kernels need this.
Great, thanks all!
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Adding iTCO_wdt fixes into 4.9-stable?
2018-11-26 10:00 ` Sasha Levin
@ 2018-11-27 7:56 ` Krzysztof Olędzki
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Olędzki @ 2018-11-27 7:56 UTC (permalink / raw)
To: Sasha Levin, Mika Westerberg; +Cc: gregkh, rafael.j.wysocki, stable
W dniu 2018-11-26 o 02:00, Sasha Levin pisze:
> On Mon, Nov 26, 2018 at 11:24:18AM +0200, Mika Westerberg wrote:
>> On Sat, Nov 24, 2018 at 10:01:48PM -0800, Krzysztof Olędzki wrote:
>>> I think older kernels should be fine, like I said - everything worked
>>> under
>>> 4.4-stable. I suspect this is because of some ACPI / WDAT
>>> improvements in
>>> 4.9, or between 4.5 - 4.8 for which we no longer support -stable.
>>> Mika, do
>>> you know which change exactly introduce this side effect?
>>
>> IIRC it was the introduction of WDAT driver itself in commit
>> 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware
>> watchdog"). The driver went into v4.9 so I don't think older stable
>> kernels need this.
>
> Great, thanks all!
Hi.
I tested 4.9.141-rc1 and everything seems to work correctly. Thank you
for adding the patches!
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-27 7:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <34c83ce4-b3ec-1cbf-db96-ad25ceabddd6@ans.pl>
[not found] ` <20181119103125.GM4179@lahna.fi.intel.com>
2018-11-19 16:32 ` Adding iTCO_wdt fixes into 4.9-stable? Krzysztof Olędzki
2018-11-23 19:26 ` Sasha Levin
2018-11-25 6:01 ` Krzysztof Olędzki
2018-11-26 9:24 ` Mika Westerberg
2018-11-26 10:00 ` Sasha Levin
2018-11-27 7:56 ` Krzysztof Olędzki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.