* [LTP] Travis failures
@ 2019-03-18 17:55 Petr Vorel
2019-03-18 19:53 ` Jan Stancek
2019-03-18 20:12 ` Petr Vorel
0 siblings, 2 replies; 5+ messages in thread
From: Petr Vorel @ 2019-03-18 17:55 UTC (permalink / raw)
To: ltp
Hi Cyril,
quite often I see in my travis builds liblitpnuma.a related failures [1] (one
random out-of-tree build), which gets fixed by restarting it. Any idea why?
Kind regards,
Petr
make[4]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls/splice'
make[4]: Entering directory '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy'
make -C "/usr/src/ltp-build/libs/libltpnuma" -f "/usr/src/ltp-build/libs/libltpnuma/Makefile" all
make[5]: Entering directory '/usr/src/ltp-build/libs/libltpnuma'
make[5]: /usr/src/ltp-build/libs/libltpnuma/Makefile: No such file or directory
make[5]: *** No rule to make target '/usr/src/ltp-build/libs/libltpnuma/Makefile'. Stop.
make[5]: Leaving directory '/usr/src/ltp-build/libs/libltpnuma'
/usr/src/ltp/include/mk/testcases.mk:52: recipe for target '/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a' failed
make[4]: *** [/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2
make[4]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy'
/usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls'
/usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/usr/src/ltp-build/testcases/kernel'
/usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/usr/src/ltp-build/testcases'
/usr/src/ltp/Makefile:119: recipe for target 'testcases-all' failed
make: *** [testcases-all] Error 2
make: Leaving directory '/usr/src/ltp-build'
[1] https://api.travis-ci.org/v3/job/507981762/log.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] Travis failures
2019-03-18 17:55 [LTP] Travis failures Petr Vorel
@ 2019-03-18 19:53 ` Jan Stancek
2019-03-19 14:49 ` Cyril Hrubis
2019-03-18 20:12 ` Petr Vorel
1 sibling, 1 reply; 5+ messages in thread
From: Jan Stancek @ 2019-03-18 19:53 UTC (permalink / raw)
To: ltp
----- Original Message -----
> Hi Cyril,
>
> quite often I see in my travis builds liblitpnuma.a related failures [1] (one
> random out-of-tree build), which gets fixed by restarting it. Any idea why?
Looks like when it gets built via ./libs it works, but if it's pulled
as dependency first, it fails:
# make -C $(pwd)/../ltp-build/testcases/kernel/syscalls/set_mempolicy/ -f $(pwd)/testcases/kernel/syscalls/set_mempolicy/Makefile top_srcdir=$(pwd) top_builddir=$(pwd)/../ltp-build
make: Entering directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
make -C "/root/ltp-build/libs/libltpnuma" -f "/root/ltp-build/libs/libltpnuma/Makefile" all
make[1]: Entering directory `/root/ltp-build/libs/libltpnuma'
make[1]: /root/ltp-build/libs/libltpnuma/Makefile: No such file or directory
make[1]: *** No rule to make target `/root/ltp-build/libs/libltpnuma/Makefile'. Stop.
make[1]: Leaving directory `/root/ltp-build/libs/libltpnuma'
make: *** [/root/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2
make: Leaving directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
Maybe something like this to fix it?
diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk
index 131854e..55cf4da 100644
--- a/include/mk/testcases.mk
+++ b/include/mk/testcases.mk
@@ -43,13 +43,13 @@ LDLIBS += -lltp
ifdef LTPLIBS
-LTPLIBS_DIRS = $(addprefix $(abs_top_builddir)/libs/lib, $(LTPLIBS))
+LTPLIBS_DIRS = $(LTPLIBS)
LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach LIB,$(LTPLIBS),lib$(LIB)/lib$(LIB))))
MAKE_DEPS += $(LTPLIBS_FILES)
$(LTPLIBS_FILES): $(LTPLIBS_DIRS)
- $(MAKE) -C "$^" -f "$^/Makefile" all
+ $(MAKE) -C "$(addprefix $(abs_top_builddir)/libs/lib, $^)" -f "$(addprefix $(abs_top_srcdir)/libs/lib, $^)/Makefile" all
LDFLAGS += $(addprefix -L$(top_builddir)/libs/lib, $(LTPLIBS))
>
> Kind regards,
> Petr
>
> make[4]: Leaving directory
> '/usr/src/ltp-build/testcases/kernel/syscalls/splice'
> make[4]: Entering directory
> '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy'
> make -C "/usr/src/ltp-build/libs/libltpnuma" -f
> "/usr/src/ltp-build/libs/libltpnuma/Makefile" all
> make[5]: Entering directory '/usr/src/ltp-build/libs/libltpnuma'
> make[5]: /usr/src/ltp-build/libs/libltpnuma/Makefile: No such file or
> directory
> make[5]: *** No rule to make target
> '/usr/src/ltp-build/libs/libltpnuma/Makefile'. Stop.
> make[5]: Leaving directory '/usr/src/ltp-build/libs/libltpnuma'
> /usr/src/ltp/include/mk/testcases.mk:52: recipe for target
> '/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a' failed
> make[4]: *** [/usr/src/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2
> make[4]: Leaving directory
> '/usr/src/ltp-build/testcases/kernel/syscalls/set_mempolicy'
> /usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all'
> failed
> make[3]: *** [all] Error 2
> make[3]: Leaving directory '/usr/src/ltp-build/testcases/kernel/syscalls'
> /usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all'
> failed
> make[2]: *** [all] Error 2
> make[2]: Leaving directory '/usr/src/ltp-build/testcases/kernel'
> /usr/src/ltp/include/mk/generic_trunk_target.inc:93: recipe for target 'all'
> failed
> make[1]: *** [all] Error 2
> make[1]: Leaving directory '/usr/src/ltp-build/testcases'
> /usr/src/ltp/Makefile:119: recipe for target 'testcases-all' failed
> make: *** [testcases-all] Error 2
> make: Leaving directory '/usr/src/ltp-build'
>
> [1] https://api.travis-ci.org/v3/job/507981762/log.txt
>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [LTP] Travis failures
2019-03-18 19:53 ` Jan Stancek
@ 2019-03-19 14:49 ` Cyril Hrubis
2019-03-20 9:22 ` Jan Stancek
0 siblings, 1 reply; 5+ messages in thread
From: Cyril Hrubis @ 2019-03-19 14:49 UTC (permalink / raw)
To: ltp
Hi!
> > quite often I see in my travis builds liblitpnuma.a related failures [1] (one
> > random out-of-tree build), which gets fixed by restarting it. Any idea why?
>
> Looks like when it gets built via ./libs it works, but if it's pulled
> as dependency first, it fails:
Which is bug itself, we have to build it via libs otherwise this will
break if more than one of these directories will pull it as dependency
at the same time.
> # make -C $(pwd)/../ltp-build/testcases/kernel/syscalls/set_mempolicy/ -f $(pwd)/testcases/kernel/syscalls/set_mempolicy/Makefile top_srcdir=$(pwd) top_builddir=$(pwd)/../ltp-build
> make: Entering directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
> make -C "/root/ltp-build/libs/libltpnuma" -f "/root/ltp-build/libs/libltpnuma/Makefile" all
> make[1]: Entering directory `/root/ltp-build/libs/libltpnuma'
> make[1]: /root/ltp-build/libs/libltpnuma/Makefile: No such file or directory
> make[1]: *** No rule to make target `/root/ltp-build/libs/libltpnuma/Makefile'. Stop.
> make[1]: Leaving directory `/root/ltp-build/libs/libltpnuma'
> make: *** [/root/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2
> make: Leaving directory `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
>
> Maybe something like this to fix it?
>
> diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk
> index 131854e..55cf4da 100644
> --- a/include/mk/testcases.mk
> +++ b/include/mk/testcases.mk
> @@ -43,13 +43,13 @@ LDLIBS += -lltp
>
> ifdef LTPLIBS
>
> -LTPLIBS_DIRS = $(addprefix $(abs_top_builddir)/libs/lib, $(LTPLIBS))
> +LTPLIBS_DIRS = $(LTPLIBS)
> LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach LIB,$(LTPLIBS),lib$(LIB)/lib$(LIB))))
>
> MAKE_DEPS += $(LTPLIBS_FILES)
>
> $(LTPLIBS_FILES): $(LTPLIBS_DIRS)
> - $(MAKE) -C "$^" -f "$^/Makefile" all
> + $(MAKE) -C "$(addprefix $(abs_top_builddir)/libs/lib, $^)" -f "$(addprefix $(abs_top_srcdir)/libs/lib, $^)/Makefile" all
Well we can use LTPLIBS directly here, and there is no need to use
addprefix if we are not applying the change to a set, so I guess that
following will work as well:
$(MAKE) -C "$(abs_top_builddir)/libs/lib)$^" -f "$(abs_top_srcdir)/libs/lib)$^/Makefile" all
Otherwise this is a good catch, acked.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] Travis failures
2019-03-19 14:49 ` Cyril Hrubis
@ 2019-03-20 9:22 ` Jan Stancek
0 siblings, 0 replies; 5+ messages in thread
From: Jan Stancek @ 2019-03-20 9:22 UTC (permalink / raw)
To: ltp
----- Original Message -----
> Hi!
> > > quite often I see in my travis builds liblitpnuma.a related failures [1]
> > > (one
> > > random out-of-tree build), which gets fixed by restarting it. Any idea
> > > why?
> >
> > Looks like when it gets built via ./libs it works, but if it's pulled
> > as dependency first, it fails:
>
> Which is bug itself, we have to build it via libs otherwise this will
> break if more than one of these directories will pull it as dependency
> at the same time.
>
> > # make -C $(pwd)/../ltp-build/testcases/kernel/syscalls/set_mempolicy/ -f
> > $(pwd)/testcases/kernel/syscalls/set_mempolicy/Makefile top_srcdir=$(pwd)
> > top_builddir=$(pwd)/../ltp-build
> > make: Entering directory
> > `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
> > make -C "/root/ltp-build/libs/libltpnuma" -f
> > "/root/ltp-build/libs/libltpnuma/Makefile" all
> > make[1]: Entering directory `/root/ltp-build/libs/libltpnuma'
> > make[1]: /root/ltp-build/libs/libltpnuma/Makefile: No such file or
> > directory
> > make[1]: *** No rule to make target
> > `/root/ltp-build/libs/libltpnuma/Makefile'. Stop.
> > make[1]: Leaving directory `/root/ltp-build/libs/libltpnuma'
> > make: *** [/root/ltp-build/libs/libltpnuma/libltpnuma.a] Error 2
> > make: Leaving directory
> > `/root/ltp-build/testcases/kernel/syscalls/set_mempolicy'
> >
> > Maybe something like this to fix it?
> >
> > diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk
> > index 131854e..55cf4da 100644
> > --- a/include/mk/testcases.mk
> > +++ b/include/mk/testcases.mk
> > @@ -43,13 +43,13 @@ LDLIBS += -lltp
> >
> > ifdef LTPLIBS
> >
> > -LTPLIBS_DIRS = $(addprefix $(abs_top_builddir)/libs/lib, $(LTPLIBS))
> > +LTPLIBS_DIRS = $(LTPLIBS)
This part is wrong, LTPLIBS_DIRS is also used for "mkdir" rule below.
I'll post v2 properly.
> > LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/,
> > $(foreach LIB,$(LTPLIBS),lib$(LIB)/lib$(LIB))))
> >
> > MAKE_DEPS += $(LTPLIBS_FILES)
> >
> > $(LTPLIBS_FILES): $(LTPLIBS_DIRS)
> > - $(MAKE) -C "$^" -f "$^/Makefile" all
> > + $(MAKE) -C "$(addprefix $(abs_top_builddir)/libs/lib, $^)" -f
> > "$(addprefix $(abs_top_srcdir)/libs/lib, $^)/Makefile" all
>
> Well we can use LTPLIBS directly here, and there is no need to use
> addprefix if we are not applying the change to a set, so I guess that
> following will work as well:
>
> $(MAKE) -C "$(abs_top_builddir)/libs/lib)$^" -f
> "$(abs_top_srcdir)/libs/lib)$^/Makefile" all
>
> Otherwise this is a good catch, acked.
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] Travis failures
2019-03-18 17:55 [LTP] Travis failures Petr Vorel
2019-03-18 19:53 ` Jan Stancek
@ 2019-03-18 20:12 ` Petr Vorel
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2019-03-18 20:12 UTC (permalink / raw)
To: ltp
Hi Cyril, Jan,
> quite often I see in my travis builds liblitpnuma.a related failures [1] (one
> random out-of-tree build), which gets fixed by restarting it. Any idea why?
Happen on master as well :( [1]. I've just restarted it so it should be ok,
but a bit inconvenient :(.
[1] https://api.travis-ci.org/v3/job/507884079/log.txt
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-20 9:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 17:55 [LTP] Travis failures Petr Vorel
2019-03-18 19:53 ` Jan Stancek
2019-03-19 14:49 ` Cyril Hrubis
2019-03-20 9:22 ` Jan Stancek
2019-03-18 20:12 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.