* [B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function
@ 2016-09-25 0:46 Antonio Quartulli
2016-09-25 4:54 ` Sven Eckelmann
2016-10-18 11:32 ` [B.A.T.M.A.N.] " Sven Eckelmann
0 siblings, 2 replies; 3+ messages in thread
From: Antonio Quartulli @ 2016-09-25 0:46 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
The argument "type" passed to the batadv_dbg_arp() function is
never used. Remove it.
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
net/batman-adv/distributed-arp-table.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index e257efd..cbb4f32 100644
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -369,12 +369,11 @@ out:
* batadv_dbg_arp - print a debug message containing all the ARP packet details
* @bat_priv: the bat priv with all the soft interface information
* @skb: ARP packet
- * @type: ARP type
* @hdr_size: size of the possible header before the ARP packet
* @msg: message to print together with the debugging information
*/
static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb,
- u16 type, int hdr_size, char *msg)
+ int hdr_size, char *msg)
{
struct batadv_unicast_4addr_packet *unicast_4addr_packet;
struct batadv_bcast_packet *bcast_pkt;
@@ -441,7 +440,7 @@ static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb,
#else
static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb,
- u16 type, int hdr_size, char *msg)
+ int hdr_size, char *msg)
{
}
@@ -983,8 +982,7 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv,
if (type != ARPOP_REQUEST)
goto out;
- batadv_dbg_arp(bat_priv, skb, type, hdr_size,
- "Parsing outgoing ARP REQUEST");
+ batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing outgoing ARP REQUEST");
ip_src = batadv_arp_ip_src(skb, hdr_size);
hw_src = batadv_arp_hw_src(skb, hdr_size);
@@ -1075,8 +1073,7 @@ bool batadv_dat_snoop_incoming_arp_request(struct batadv_priv *bat_priv,
ip_src = batadv_arp_ip_src(skb, hdr_size);
ip_dst = batadv_arp_ip_dst(skb, hdr_size);
- batadv_dbg_arp(bat_priv, skb, type, hdr_size,
- "Parsing incoming ARP REQUEST");
+ batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing incoming ARP REQUEST");
batadv_dat_entry_add(bat_priv, ip_src, hw_src, vid);
@@ -1149,8 +1146,7 @@ void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv,
if (type != ARPOP_REPLY)
return;
- batadv_dbg_arp(bat_priv, skb, type, hdr_size,
- "Parsing outgoing ARP REPLY");
+ batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing outgoing ARP REPLY");
hw_src = batadv_arp_hw_src(skb, hdr_size);
ip_src = batadv_arp_ip_src(skb, hdr_size);
@@ -1195,8 +1191,7 @@ bool batadv_dat_snoop_incoming_arp_reply(struct batadv_priv *bat_priv,
if (type != ARPOP_REPLY)
goto out;
- batadv_dbg_arp(bat_priv, skb, type, hdr_size,
- "Parsing incoming ARP REPLY");
+ batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing incoming ARP REPLY");
hw_src = batadv_arp_hw_src(skb, hdr_size);
ip_src = batadv_arp_ip_src(skb, hdr_size);
--
2.10.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function
2016-09-25 0:46 [B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function Antonio Quartulli
@ 2016-09-25 4:54 ` Sven Eckelmann
2016-10-18 11:32 ` [B.A.T.M.A.N.] " Sven Eckelmann
1 sibling, 0 replies; 3+ messages in thread
From: Sven Eckelmann @ 2016-09-25 4:54 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
On Sonntag, 25. September 2016 08:46:36 CEST Antonio Quartulli wrote:
> The argument "type" passed to the batadv_dbg_arp() function is
> never used. Remove it.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] batman-adv: remove unsed argument from batadv_dbg_arp() function
2016-09-25 0:46 [B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function Antonio Quartulli
2016-09-25 4:54 ` Sven Eckelmann
@ 2016-10-18 11:32 ` Sven Eckelmann
1 sibling, 0 replies; 3+ messages in thread
From: Sven Eckelmann @ 2016-10-18 11:32 UTC (permalink / raw)
To: Antonio Quartulli; +Cc: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Sonntag, 25. September 2016 08:46:36 CEST Antonio Quartulli wrote:
> The argument "type" passed to the batadv_dbg_arp() function is
> never used. Remove it.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
> ---
> net/batman-adv/distributed-arp-table.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
Applied in 917539ed1ca1b7e6046b44adc35d8264f33e20fb [1].
Kind regards,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/917539ed1ca1b7e6046b44adc35d8264f33e20fb
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-18 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-25 0:46 [B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function Antonio Quartulli
2016-09-25 4:54 ` Sven Eckelmann
2016-10-18 11:32 ` [B.A.T.M.A.N.] " Sven Eckelmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.