* [f2fs:dev-test 54/55] fs/f2fs/data.c:520:6: sparse: symbol 'f2fs_submit_ipu_bio' was not declared. Should it be static?
@ 2019-03-13 23:53 kbuild test robot
2019-03-13 23:53 ` [RFC PATCH f2fs] f2fs: f2fs_submit_ipu_bio() can be static kbuild test robot
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2019-03-13 23:53 UTC (permalink / raw)
To: Chao Yu, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
head: 9487ae9b5821c0fa47c53b7ced0ee3256d4c5117
commit: 60686faa1e20c6f221aad9f93a6f263faaf8cd76 [54/55] f2fs: add bio cache for IPU
reproduce:
# apt-get install sparse
git checkout 60686faa1e20c6f221aad9f93a6f263faaf8cd76
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
fs/f2fs/data.c:423:47: sparse: Using plain integer as NULL pointer
>> fs/f2fs/data.c:520:6: sparse: symbol 'f2fs_submit_ipu_bio' was not declared. Should it be static?
fs/f2fs/data.c:618:35: sparse: expression using sizeof(void)
fs/f2fs/data.c:1099:30: sparse: expression using sizeof(void)
fs/f2fs/data.c:1099:30: sparse: expression using sizeof(void)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC PATCH f2fs] f2fs: f2fs_submit_ipu_bio() can be static
2019-03-13 23:53 [f2fs:dev-test 54/55] fs/f2fs/data.c:520:6: sparse: symbol 'f2fs_submit_ipu_bio' was not declared. Should it be static? kbuild test robot
@ 2019-03-13 23:53 ` kbuild test robot
2019-03-14 14:35 ` Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2019-03-13 23:53 UTC (permalink / raw)
To: Chao Yu, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
Fixes: 60686faa1e20 ("f2fs: add bio cache for IPU")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 6908469..9381f76 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -517,7 +517,7 @@ int f2fs_merge_page_bio(struct f2fs_io_info *fio)
return 0;
}
-void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio,
+static void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio,
struct page *page)
{
if (!bio)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH f2fs] f2fs: f2fs_submit_ipu_bio() can be static
2019-03-13 23:53 ` [RFC PATCH f2fs] f2fs: f2fs_submit_ipu_bio() can be static kbuild test robot
@ 2019-03-14 14:35 ` Chao Yu
2019-03-14 17:48 ` Jaegeuk Kim
0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2019-03-14 14:35 UTC (permalink / raw)
To: kbuild test robot, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
Hi Jaegeuk,
Could you merge this into ("f2fs: add bio cache for IPU")?
Thanks,
On 2019-3-14 7:53, kbuild test robot wrote:
>
> Fixes: 60686faa1e20 ("f2fs: add bio cache for IPU")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
> data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 6908469..9381f76 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -517,7 +517,7 @@ int f2fs_merge_page_bio(struct f2fs_io_info *fio)
> return 0;
> }
>
> -void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio,
> +static void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio,
> struct page *page)
> {
> if (!bio)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH f2fs] f2fs: f2fs_submit_ipu_bio() can be static
2019-03-14 14:35 ` Chao Yu
@ 2019-03-14 17:48 ` Jaegeuk Kim
0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2019-03-14 17:48 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, kbuild test robot, kbuild-all
On 03/14, Chao Yu wrote:
> Hi Jaegeuk,
>
> Could you merge this into ("f2fs: add bio cache for IPU")?
Done.
>
> Thanks,
>
> On 2019-3-14 7:53, kbuild test robot wrote:
> >
> > Fixes: 60686faa1e20 ("f2fs: add bio cache for IPU")
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > ---
> > data.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> > index 6908469..9381f76 100644
> > --- a/fs/f2fs/data.c
> > +++ b/fs/f2fs/data.c
> > @@ -517,7 +517,7 @@ int f2fs_merge_page_bio(struct f2fs_io_info *fio)
> > return 0;
> > }
> >
> > -void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio,
> > +static void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio,
> > struct page *page)
> > {
> > if (!bio)
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-14 17:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 23:53 [f2fs:dev-test 54/55] fs/f2fs/data.c:520:6: sparse: symbol 'f2fs_submit_ipu_bio' was not declared. Should it be static? kbuild test robot
2019-03-13 23:53 ` [RFC PATCH f2fs] f2fs: f2fs_submit_ipu_bio() can be static kbuild test robot
2019-03-14 14:35 ` Chao Yu
2019-03-14 17:48 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.