From: Philipp Zabel <p.zabel@pengutronix.de>
To: Greentime Hu <greentime.hu@sifive.com>,
paul.walmsley@sifive.com, hes@sifive.com, erik.danie@sifive.com,
zong.li@sifive.com, bhelgaas@google.com, robh+dt@kernel.org,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
mturquette@baylibre.com, sboyd@kernel.org,
lorenzo.pieralisi@arm.com, alex.dewar90@gmail.com,
khilman@baylibre.com, hayashi.kunihiko@socionext.com,
vidyas@nvidia.com, jh80.chung@samsung.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH 5/6] PCI: designware: Add SiFive FU740 PCIe host controller driver
Date: Thu, 04 Mar 2021 13:00:17 +0100 [thread overview]
Message-ID: <807b832828d95bc003e7caed63ff86b4f9ff6eaa.camel@pengutronix.de> (raw)
In-Reply-To: <34c2c3985443b23a75ce89c605c4b833bbafd134.1614681831.git.greentime.hu@sifive.com>
On Tue, 2021-03-02 at 18:59 +0800, Greentime Hu wrote:
[...]
> +static int fu740_pcie_probe(struct platform_device *pdev)
> +{
[...]
> + /* Fetch reset */
> + afp->rst = devm_reset_control_get(dev, NULL);
Please use
afp->rst = devm_reset_control_get_exclusive(dev, NULL);
regards
Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Greentime Hu <greentime.hu@sifive.com>,
paul.walmsley@sifive.com, hes@sifive.com, erik.danie@sifive.com,
zong.li@sifive.com, bhelgaas@google.com, robh+dt@kernel.org,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
mturquette@baylibre.com, sboyd@kernel.org,
lorenzo.pieralisi@arm.com, alex.dewar90@gmail.com,
khilman@baylibre.com, hayashi.kunihiko@socionext.com,
vidyas@nvidia.com, jh80.chung@samsung.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH 5/6] PCI: designware: Add SiFive FU740 PCIe host controller driver
Date: Thu, 04 Mar 2021 13:00:17 +0100 [thread overview]
Message-ID: <807b832828d95bc003e7caed63ff86b4f9ff6eaa.camel@pengutronix.de> (raw)
In-Reply-To: <34c2c3985443b23a75ce89c605c4b833bbafd134.1614681831.git.greentime.hu@sifive.com>
On Tue, 2021-03-02 at 18:59 +0800, Greentime Hu wrote:
[...]
> +static int fu740_pcie_probe(struct platform_device *pdev)
> +{
[...]
> + /* Fetch reset */
> + afp->rst = devm_reset_control_get(dev, NULL);
Please use
afp->rst = devm_reset_control_get_exclusive(dev, NULL);
regards
Philipp
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-03-04 12:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 10:59 [RFC PATCH 0/6] Add SiFive FU740 PCIe host controller driver support Greentime Hu
2021-03-02 10:59 ` Greentime Hu
2021-03-02 10:59 ` [RFC PATCH 1/6] clk: sifive: Add pcie_aux clock in prci driver for PCIe driver Greentime Hu
2021-03-02 10:59 ` Greentime Hu
2021-03-02 10:59 ` [RFC PATCH 2/6] clk: sifive: Use reset-simple " Greentime Hu
2021-03-02 10:59 ` Greentime Hu
2021-03-04 11:58 ` Philipp Zabel
2021-03-04 11:58 ` Philipp Zabel
2021-03-09 7:23 ` Greentime Hu
2021-03-09 7:23 ` Greentime Hu
2021-03-02 10:59 ` [RFC PATCH 3/6] MAINTAINERS: Add maintainers for SiFive FU740 " Greentime Hu
2021-03-02 10:59 ` Greentime Hu
2021-03-02 10:59 ` [RFC PATCH 4/6] dt-bindings: PCI: Add SiFive FU740 PCIe host controller Greentime Hu
2021-03-02 10:59 ` Greentime Hu
2021-03-03 23:14 ` Rob Herring
2021-03-03 23:14 ` Rob Herring
2021-03-02 10:59 ` [RFC PATCH 5/6] PCI: designware: Add SiFive FU740 PCIe host controller driver Greentime Hu
2021-03-02 10:59 ` Greentime Hu
2021-03-03 23:30 ` Rob Herring
2021-03-03 23:30 ` Rob Herring
2021-03-04 12:00 ` Philipp Zabel [this message]
2021-03-04 12:00 ` Philipp Zabel
2021-03-04 15:45 ` Bjorn Helgaas
2021-03-04 15:45 ` Bjorn Helgaas
2021-03-02 10:59 ` [RFC PATCH 6/6] riscv: dts: Add PCIe support for the SiFive FU740-C000 SoC Greentime Hu
2021-03-02 10:59 ` Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=807b832828d95bc003e7caed63ff86b4f9ff6eaa.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alex.dewar90@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=erik.danie@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hes@sifive.com \
--cc=jh80.chung@samsung.com \
--cc=khilman@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vidyas@nvidia.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.