All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 3/5] drivers: phy: Set phy->dev to NULL when generic_phy_get_by_index() fails
Date: Thu, 1 Jun 2017 10:59:39 +0200	[thread overview]
Message-ID: <809df087-8517-f426-5e10-d3e1cdf36f7f@ti.com> (raw)
In-Reply-To: <1496304865-23909-4-git-send-email-patrice.chotard@st.com>

Hi Patrice,


On 01/06/2017 10:14, patrice.chotard at st.com wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> phy->dev need to be set to NULL in case of generic_phy_get_by_index()
> fails. Then phy->dev can be used to check if the phy is valid
>
> Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> v5:	_ none
> v4:     _ ensure that phy->dev is set to NULL in case of
>            generic_phy_get_by_index() fails
>
>   drivers/phy/phy-uclass.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c
> index d8b8d58..68e518f 100644
> --- a/drivers/phy/phy-uclass.c
> +++ b/drivers/phy/phy-uclass.c
> @@ -45,6 +45,7 @@ int generic_phy_get_by_index(struct udevice *dev, int index,
>   	debug("%s(dev=%p, index=%d, phy=%p)\n", __func__, dev, index, phy);
>   
>   	assert(phy);
> +	phy->dev = NULL;
>   	ret = dev_read_phandle_with_args(dev, "phys", "#phy-cells", 0, index,
>   					 &args);
>   	if (ret) {

Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com>

  reply	other threads:[~2017-06-01  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01  8:14 [U-Boot] [PATCH v5 0/5] Extend xhci-dwc3 patrice.chotard at st.com
2017-06-01  8:14 ` [U-Boot] [PATCH v5 1/5] usb: host: xhci-dwc3: Convert driver to DM patrice.chotard at st.com
2017-06-02  2:55   ` Simon Glass
2017-06-01  8:14 ` [U-Boot] [PATCH v5 2/5] usb: host: xhci-dwc3: Add dual role mode support from DT patrice.chotard at st.com
2017-06-01  8:14 ` [U-Boot] [PATCH v5 3/5] drivers: phy: Set phy->dev to NULL when generic_phy_get_by_index() fails patrice.chotard at st.com
2017-06-01  8:59   ` Jean-Jacques Hiblot [this message]
2017-06-01  8:14 ` [U-Boot] [PATCH v5 4/5] drivers: phy: add generic_phy_valid() method patrice.chotard at st.com
2017-06-01  8:14 ` [U-Boot] [PATCH v5 5/5] usb: host: xhci-dwc3: Add generic PHY support patrice.chotard at st.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=809df087-8517-f426-5e10-d3e1cdf36f7f@ti.com \
    --to=jjhiblot@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.