[PATCH] pass-through: provide two !HVM stubs

[PATCH] pass-through: provide two !HVM stubs

[Jan Beulich]

Older gcc, despite eliminating pci_clean_dpci_irqs() when !HVM, does
not manage to also eliminate pci_clean_dpci_irq(). Cope with this.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/asm-x86/hvm/irq.h
+++ b/xen/include/asm-x86/hvm/irq.h
@@ -180,7 +180,15 @@ int pt_pirq_iterate(struct domain *d,
                               struct hvm_pirq_dpci *, void *arg),
                     void *arg);
 
+#ifdef CONFIG_HVM
 bool pt_pirq_softirq_active(struct hvm_pirq_dpci *);
+#else
+static inline bool pt_pirq_softirq_active(struct hvm_pirq_dpci *dpci)
+{
+    return false;
+}
+#endif
+
 /* Modify state of a PCI INTx wire. */
 void hvm_pci_intx_assert(struct domain *d, unsigned int device,
                          unsigned int intx);
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -104,7 +104,11 @@ int pt_irq_destroy_bind(struct domain *,
 void hvm_dpci_isairq_eoi(struct domain *d, unsigned int isairq);
 struct hvm_irq_dpci *domain_get_irq_dpci(const struct domain *);
 void free_hvm_irq_dpci(struct hvm_irq_dpci *dpci);
-bool_t pt_irq_need_timer(uint32_t flags);
+#ifdef CONFIG_HVM
+bool pt_irq_need_timer(uint32_t flags);
+#else
+static inline bool pt_irq_need_timer(unsigned int flags) { return false; }
+#endif
 
 struct msi_desc;
 struct msi_msg;





_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] pass-through: provide two !HVM stubs

[Wei Liu]

On Fri, Oct 05, 2018 at 05:11:55AM -0600, Jan Beulich wrote:
> Older gcc, despite eliminating pci_clean_dpci_irqs() when !HVM, does
> not manage to also eliminate pci_clean_dpci_irq(). Cope with this.

Would be helpful to call out the version of gcc is the commit message.

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] pass-through: provide two !HVM stubs

[Jan Beulich]

>>> On 05.10.18 at 13:14, <wei.liu2@citrix.com> wrote:
> On Fri, Oct 05, 2018 at 05:11:55AM -0600, Jan Beulich wrote:
>> Older gcc, despite eliminating pci_clean_dpci_irqs() when !HVM, does
>> not manage to also eliminate pci_clean_dpci_irq(). Cope with this.
> 
> Would be helpful to call out the version of gcc is the commit message.

It was 4.3 in this case, but I didn't think it was overly important.
Since you ask, I've added it.

> Reviewed-by: Wei Liu <wei.liu2@citrix.com>

Thanks.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] pass-through: provide two !HVM stubs

[Andrew Cooper]

On 05/10/18 12:26, Jan Beulich wrote:
>>>> On 05.10.18 at 13:14, <wei.liu2@citrix.com> wrote:
>> On Fri, Oct 05, 2018 at 05:11:55AM -0600, Jan Beulich wrote:
>>> Older gcc, despite eliminating pci_clean_dpci_irqs() when !HVM, does
>>> not manage to also eliminate pci_clean_dpci_irq(). Cope with this.
>> Would be helpful to call out the version of gcc is the commit message.
> It was 4.3 in this case, but I didn't think it was overly important.
> Since you ask, I've added it.
>
>> Reviewed-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel