From: John Hubbard <jhubbard@nvidia.com> To: <jglisse@redhat.com>, <linux-mm@kvack.org> Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>, Evgeny Baskakov <ebaskakov@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Mark Hairgrove <mhairgrove@nvidia.com> Subject: Re: [PATCH 11/14] mm/hmm: move hmm_pfns_clear() closer to where it is use Date: Mon, 19 Mar 2018 16:12:10 -0700 [thread overview] Message-ID: <80d6ed4e-3e7a-ef22-c931-79491eeedbe7@nvidia.com> (raw) In-Reply-To: <20180316203552.4155-2-jglisse@redhat.com> On 03/16/2018 01:35 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > > Move hmm_pfns_clear() closer to where it is use to make it clear it > is not use by page table walkers. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > mm/hmm.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: John Hubbard <jhubbard@nvidia.com> > > diff --git a/mm/hmm.c b/mm/hmm.c > index 857eec622c98..3a708f500b80 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -297,14 +297,6 @@ static int hmm_pfns_bad(unsigned long addr, > return 0; > } > > -static void hmm_pfns_clear(uint64_t *pfns, > - unsigned long addr, > - unsigned long end) > -{ > - for (; addr < end; addr += PAGE_SIZE, pfns++) > - *pfns = 0; > -} > - > /* > * hmm_vma_walk_hole() - handle a range back by no pmd or no pte > * @start: range virtual start address (inclusive) > @@ -463,6 +455,14 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > return 0; > } > > +static void hmm_pfns_clear(uint64_t *pfns, > + unsigned long addr, > + unsigned long end) > +{ > + for (; addr < end; addr += PAGE_SIZE, pfns++) > + *pfns = 0; > +} > + Yep, identical, so no functional changes. > static void hmm_pfns_special(struct hmm_range *range) > { > unsigned long addr = range->start, i = 0; thanks, -- John Hubbard NVIDIA
WARNING: multiple messages have this Message-ID (diff)
From: John Hubbard <jhubbard@nvidia.com> To: jglisse@redhat.com, linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Evgeny Baskakov <ebaskakov@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Mark Hairgrove <mhairgrove@nvidia.com> Subject: Re: [PATCH 11/14] mm/hmm: move hmm_pfns_clear() closer to where it is use Date: Mon, 19 Mar 2018 16:12:10 -0700 [thread overview] Message-ID: <80d6ed4e-3e7a-ef22-c931-79491eeedbe7@nvidia.com> (raw) In-Reply-To: <20180316203552.4155-2-jglisse@redhat.com> On 03/16/2018 01:35 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > > Move hmm_pfns_clear() closer to where it is use to make it clear it > is not use by page table walkers. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > mm/hmm.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: John Hubbard <jhubbard@nvidia.com> > > diff --git a/mm/hmm.c b/mm/hmm.c > index 857eec622c98..3a708f500b80 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -297,14 +297,6 @@ static int hmm_pfns_bad(unsigned long addr, > return 0; > } > > -static void hmm_pfns_clear(uint64_t *pfns, > - unsigned long addr, > - unsigned long end) > -{ > - for (; addr < end; addr += PAGE_SIZE, pfns++) > - *pfns = 0; > -} > - > /* > * hmm_vma_walk_hole() - handle a range back by no pmd or no pte > * @start: range virtual start address (inclusive) > @@ -463,6 +455,14 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > return 0; > } > > +static void hmm_pfns_clear(uint64_t *pfns, > + unsigned long addr, > + unsigned long end) > +{ > + for (; addr < end; addr += PAGE_SIZE, pfns++) > + *pfns = 0; > +} > + Yep, identical, so no functional changes. > static void hmm_pfns_special(struct hmm_range *range) > { > unsigned long addr = range->start, i = 0; thanks, -- John Hubbard NVIDIA
next prev parent reply other threads:[~2018-03-19 23:12 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-16 20:35 [PATCH 10/14] mm/hmm: rename HMM_PFN_DEVICE_UNADDRESSABLE to HMM_PFN_DEVICE_PRIVATE jglisse 2018-03-16 20:35 ` jglisse 2018-03-16 20:35 ` [PATCH 11/14] mm/hmm: move hmm_pfns_clear() closer to where it is use jglisse 2018-03-16 20:35 ` jglisse 2018-03-19 23:12 ` John Hubbard [this message] 2018-03-19 23:12 ` John Hubbard 2018-03-16 20:35 ` [PATCH 12/14] mm/hmm: factor out pte and pmd handling to simplify hmm_vma_walk_pmd() jglisse 2018-03-16 20:35 ` jglisse 2018-03-16 20:35 ` [PATCH 13/14] mm/hmm: change hmm_vma_fault() to allow write fault on page basis jglisse 2018-03-16 20:35 ` jglisse 2018-03-16 20:35 ` [PATCH 14/14] mm/hmm: use device driver encoding for HMM pfn jglisse 2018-03-16 20:35 ` jglisse 2018-03-19 23:20 ` John Hubbard 2018-03-19 23:20 ` John Hubbard 2018-03-19 23:09 ` [PATCH 10/14] mm/hmm: rename HMM_PFN_DEVICE_UNADDRESSABLE to HMM_PFN_DEVICE_PRIVATE John Hubbard 2018-03-19 23:09 ` John Hubbard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=80d6ed4e-3e7a-ef22-c931-79491eeedbe7@nvidia.com \ --to=jhubbard@nvidia.com \ --cc=akpm@linux-foundation.org \ --cc=ebaskakov@nvidia.com \ --cc=jglisse@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhairgrove@nvidia.com \ --cc=rcampbell@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.