All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
	Avri Altman <Avri.Altman@wdc.com>,
	linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com,
	asutoshd@codeaurora.org, matthias.bgg@gmail.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com,
	peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
	andy.teng@mediatek.com, chaotian.jing@mediatek.com,
	cc.chou@mediatek.com
Subject: Re: [PATCH v4] scsi: ufs: Cleanup completed request without interrupt notification
Date: Sun, 2 Aug 2020 20:12:03 -0700	[thread overview]
Message-ID: <80f5e213-502b-3532-e782-6f26a778274e@acm.org> (raw)
In-Reply-To: <548b602daa1e15415625cb8d1f81a208@codeaurora.org>

On 2020-07-31 16:17, Can Guo wrote:
> For scsi_dma_unmap() part, that is true - we should make it serialized with
> any other completion paths. I've found it during my fault injection test, so
> I've made a patch to fix it, but it only comes in my next error recovery
> enhancement patch series. Please check the attachment.

Hi Can,

It is not clear to me how that patch serializes scsi_dma_unmap() against
other completion paths? Doesn't the regular completion path call
__ufshcd_transfer_req_compl() without holding the host lock?

Thanks,

Bart.


WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	andy.teng@mediatek.com, jejb@linux.ibm.com,
	chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
	linux-kernel@vger.kernel.org, asutoshd@codeaurora.org,
	Avri Altman <Avri.Altman@wdc.com>,
	linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
	alim.akhtar@samsung.com, matthias.bgg@gmail.com,
	Stanley Chu <stanley.chu@mediatek.com>,
	chaotian.jing@mediatek.com, cc.chou@mediatek.com,
	linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v4] scsi: ufs: Cleanup completed request without interrupt notification
Date: Sun, 2 Aug 2020 20:12:03 -0700	[thread overview]
Message-ID: <80f5e213-502b-3532-e782-6f26a778274e@acm.org> (raw)
In-Reply-To: <548b602daa1e15415625cb8d1f81a208@codeaurora.org>

On 2020-07-31 16:17, Can Guo wrote:
> For scsi_dma_unmap() part, that is true - we should make it serialized with
> any other completion paths. I've found it during my fault injection test, so
> I've made a patch to fix it, but it only comes in my next error recovery
> enhancement patch series. Please check the attachment.

Hi Can,

It is not clear to me how that patch serializes scsi_dma_unmap() against
other completion paths? Doesn't the regular completion path call
__ufshcd_transfer_req_compl() without holding the host lock?

Thanks,

Bart.


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	andy.teng@mediatek.com, jejb@linux.ibm.com,
	chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
	linux-kernel@vger.kernel.org, asutoshd@codeaurora.org,
	Avri Altman <Avri.Altman@wdc.com>,
	linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
	alim.akhtar@samsung.com, matthias.bgg@gmail.com,
	Stanley Chu <stanley.chu@mediatek.com>,
	chaotian.jing@mediatek.com, cc.chou@mediatek.com,
	linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v4] scsi: ufs: Cleanup completed request without interrupt notification
Date: Sun, 2 Aug 2020 20:12:03 -0700	[thread overview]
Message-ID: <80f5e213-502b-3532-e782-6f26a778274e@acm.org> (raw)
In-Reply-To: <548b602daa1e15415625cb8d1f81a208@codeaurora.org>

On 2020-07-31 16:17, Can Guo wrote:
> For scsi_dma_unmap() part, that is true - we should make it serialized with
> any other completion paths. I've found it during my fault injection test, so
> I've made a patch to fix it, but it only comes in my next error recovery
> enhancement patch series. Please check the attachment.

Hi Can,

It is not clear to me how that patch serializes scsi_dma_unmap() against
other completion paths? Doesn't the regular completion path call
__ufshcd_transfer_req_compl() without holding the host lock?

Thanks,

Bart.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-08-03  3:12 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 14:02 [PATCH v4] scsi: ufs: Cleanup completed request without interrupt notification Stanley Chu
2020-07-24 14:02 ` Stanley Chu
2020-07-24 14:02 ` Stanley Chu
2020-07-27 11:18 ` Avri Altman
2020-07-27 11:18   ` Avri Altman
2020-07-27 11:18   ` Avri Altman
2020-07-31  1:30   ` Stanley Chu
2020-07-31  1:30     ` Stanley Chu
2020-07-31  1:30     ` Stanley Chu
2020-07-31  4:06     ` Bart Van Assche
2020-07-31  4:06       ` Bart Van Assche
2020-07-31  4:06       ` Bart Van Assche
2020-07-31  8:00       ` Can Guo
2020-07-31  8:00         ` Can Guo
2020-07-31  8:00         ` Can Guo
2020-07-31 16:51         ` Bart Van Assche
2020-07-31 16:51           ` Bart Van Assche
2020-07-31 16:51           ` Bart Van Assche
2020-07-31 23:17           ` Can Guo
2020-07-31 23:17             ` Can Guo
2020-07-31 23:17             ` Can Guo
2020-08-03  3:00             ` Stanley Chu
2020-08-03  3:00               ` Stanley Chu
2020-08-03  3:00               ` Stanley Chu
2020-08-03  5:14               ` Can Guo
2020-08-03  5:14                 ` Can Guo
2020-08-03  5:14                 ` Can Guo
2020-08-03  5:27                 ` Stanley Chu
2020-08-03  5:27                   ` Stanley Chu
2020-08-03  5:27                   ` Stanley Chu
2020-08-03  3:12             ` Bart Van Assche [this message]
2020-08-03  3:12               ` Bart Van Assche
2020-08-03  3:12               ` Bart Van Assche
2020-08-03  5:07               ` Can Guo
2020-08-03  5:07                 ` Can Guo
2020-08-03  5:07                 ` Can Guo
2020-08-04 10:01 ` Can Guo
2020-08-04 10:01   ` Can Guo
2020-08-04 10:01   ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80f5e213-502b-3532-e782-6f26a778274e@acm.org \
    --to=bvanassche@acm.org \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andy.teng@mediatek.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=cc.chou@mediatek.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=jejb@linux.ibm.com \
    --cc=kuohong.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.