All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: freescale: sl28: correct MMC order
@ 2020-11-24 21:21 ` Michael Walle
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-24 21:21 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree, linux-kernel
  Cc: Shawn Guo, Li Yang, Rob Herring, Yangbo Lu, Vladimir Oltean,
	Michael Walle

Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
layerscape") hardcoded the order of the MMC devices. This doesn't fit
the sl28 boards, which come with an onboard eMMC. Thus use the more
natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
and /dev/mmcblk1 for the SD card which is removable by the user.

Please note, that the images for this board already use root=UUID=,
therefore the actual device number doesn't matter for booting.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index fbaecf285d05..6da4a28c4d19 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -18,6 +18,8 @@
 
 	aliases {
 		crypto = &crypto;
+		mmc0 = &esdhc1;
+		mmc1 = &esdhc;
 		serial0 = &duart0;
 		serial1 = &duart1;
 		serial2 = &lpuart1;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: freescale: sl28: correct MMC order
@ 2020-11-24 21:21 ` Michael Walle
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-24 21:21 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree, linux-kernel
  Cc: Vladimir Oltean, Li Yang, Michael Walle, Rob Herring, Yangbo Lu,
	Shawn Guo

Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
layerscape") hardcoded the order of the MMC devices. This doesn't fit
the sl28 boards, which come with an onboard eMMC. Thus use the more
natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
and /dev/mmcblk1 for the SD card which is removable by the user.

Please note, that the images for this board already use root=UUID=,
therefore the actual device number doesn't matter for booting.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index fbaecf285d05..6da4a28c4d19 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -18,6 +18,8 @@
 
 	aliases {
 		crypto = &crypto;
+		mmc0 = &esdhc1;
+		mmc1 = &esdhc;
 		serial0 = &duart0;
 		serial1 = &duart1;
 		serial2 = &lpuart1;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: freescale: sl28: correct MMC order
  2020-11-24 21:21 ` Michael Walle
@ 2020-11-25  3:03   ` Y.b. Lu
  -1 siblings, 0 replies; 6+ messages in thread
From: Y.b. Lu @ 2020-11-25  3:03 UTC (permalink / raw)
  To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel
  Cc: Shawn Guo, Leo Li, Rob Herring, Vladimir Oltean

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Wednesday, November 25, 2020 5:21 AM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Y.b. Lu <yangbo.lu@nxp.com>; Vladimir
> Oltean <vladimir.oltean@nxp.com>; Michael Walle <michael@walle.cc>
> Subject: [PATCH] arm64: dts: freescale: sl28: correct MMC order
> 
> Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
> layerscape") hardcoded the order of the MMC devices. This doesn't fit
> the sl28 boards, which come with an onboard eMMC. Thus use the more
> natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
> and /dev/mmcblk1 for the SD card which is removable by the user.
> 
> Please note, that the images for this board already use root=UUID=,
> therefore the actual device number doesn't matter for booting.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

It's ok for me to re-define mmc alias.
Reviewed-by: Yangbo Lu <yangbo.lu@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index fbaecf285d05..6da4a28c4d19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -18,6 +18,8 @@
> 
>  	aliases {
>  		crypto = &crypto;
> +		mmc0 = &esdhc1;
> +		mmc1 = &esdhc;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &lpuart1;
> --
> 2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: freescale: sl28: correct MMC order
@ 2020-11-25  3:03   ` Y.b. Lu
  0 siblings, 0 replies; 6+ messages in thread
From: Y.b. Lu @ 2020-11-25  3:03 UTC (permalink / raw)
  To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel
  Cc: Vladimir Oltean, Rob Herring, Shawn Guo, Leo Li

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Wednesday, November 25, 2020 5:21 AM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Y.b. Lu <yangbo.lu@nxp.com>; Vladimir
> Oltean <vladimir.oltean@nxp.com>; Michael Walle <michael@walle.cc>
> Subject: [PATCH] arm64: dts: freescale: sl28: correct MMC order
> 
> Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
> layerscape") hardcoded the order of the MMC devices. This doesn't fit
> the sl28 boards, which come with an onboard eMMC. Thus use the more
> natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
> and /dev/mmcblk1 for the SD card which is removable by the user.
> 
> Please note, that the images for this board already use root=UUID=,
> therefore the actual device number doesn't matter for booting.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

It's ok for me to re-define mmc alias.
Reviewed-by: Yangbo Lu <yangbo.lu@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index fbaecf285d05..6da4a28c4d19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -18,6 +18,8 @@
> 
>  	aliases {
>  		crypto = &crypto;
> +		mmc0 = &esdhc1;
> +		mmc1 = &esdhc;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &lpuart1;
> --
> 2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: freescale: sl28: correct MMC order
  2020-11-24 21:21 ` Michael Walle
@ 2020-11-30 15:18   ` Michael Walle
  -1 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-30 15:18 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree, linux-kernel
  Cc: Shawn Guo, Li Yang, Rob Herring, Yangbo Lu, Vladimir Oltean

Am 2020-11-24 22:21, schrieb Michael Walle:
> Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
> layerscape") hardcoded the order of the MMC devices. This doesn't fit
> the sl28 boards, which come with an onboard eMMC. Thus use the more
> natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
> and /dev/mmcblk1 for the SD card which is removable by the user.
> 
> Please note, that the images for this board already use root=UUID=,
> therefore the actual device number doesn't matter for booting.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index fbaecf285d05..6da4a28c4d19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -18,6 +18,8 @@
> 
>  	aliases {
>  		crypto = &crypto;
> +		mmc0 = &esdhc1;
> +		mmc1 = &esdhc;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &lpuart1;

This will be superfluous because Vladimirs patch was applied:
https://lore.kernel.org/linux-devicetree/20201130143923.GK4072@dragon/

Thanks!
-michael

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: freescale: sl28: correct MMC order
@ 2020-11-30 15:18   ` Michael Walle
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-30 15:18 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree, linux-kernel
  Cc: Yangbo Lu, Vladimir Oltean, Rob Herring, Shawn Guo, Li Yang

Am 2020-11-24 22:21, schrieb Michael Walle:
> Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
> layerscape") hardcoded the order of the MMC devices. This doesn't fit
> the sl28 boards, which come with an onboard eMMC. Thus use the more
> natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
> and /dev/mmcblk1 for the SD card which is removable by the user.
> 
> Please note, that the images for this board already use root=UUID=,
> therefore the actual device number doesn't matter for booting.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index fbaecf285d05..6da4a28c4d19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -18,6 +18,8 @@
> 
>  	aliases {
>  		crypto = &crypto;
> +		mmc0 = &esdhc1;
> +		mmc1 = &esdhc;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &lpuart1;

This will be superfluous because Vladimirs patch was applied:
https://lore.kernel.org/linux-devicetree/20201130143923.GK4072@dragon/

Thanks!
-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-30 15:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 21:21 [PATCH] arm64: dts: freescale: sl28: correct MMC order Michael Walle
2020-11-24 21:21 ` Michael Walle
2020-11-25  3:03 ` Y.b. Lu
2020-11-25  3:03   ` Y.b. Lu
2020-11-30 15:18 ` Michael Walle
2020-11-30 15:18   ` Michael Walle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.