From: Roberto Sassu <roberto.sassu@huaweicloud.com> To: Paul Moore <paul@paul-moore.com>, linux-security-module@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, roberto.sassu@huawei.com, syzkaller-bugs@googlegroups.com, syzbot <syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com> Subject: Re: [syzbot] [reiserfs?] INFO: task hung in flush_old_commits Date: Wed, 24 May 2023 17:50:03 +0200 [thread overview] Message-ID: <813148798c14a49cbdf0f500fbbbab154929e6ed.camel@huaweicloud.com> (raw) In-Reply-To: <CAHC9VhTM0a7jnhxpCyonepcfWbnG-OJbbLpjQi68gL2GVnKSRg@mail.gmail.com> On Wed, 2023-05-24 at 11:11 -0400, Paul Moore wrote: > On Wed, May 24, 2023 at 5:59 AM syzbot > <syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com> wrote: > > syzbot has bisected this issue to: > > > > commit d82dcd9e21b77d338dc4875f3d4111f0db314a7c > > Author: Roberto Sassu <roberto.sassu@huawei.com> > > Date: Fri Mar 31 12:32:18 2023 +0000 > > > > reiserfs: Add security prefix to xattr name in reiserfs_security_write() > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11c39639280000 > > start commit: 421ca22e3138 Merge tag 'nfs-for-6.4-2' of git://git.linux-.. > > git tree: upstream > > final oops: https://syzkaller.appspot.com/x/report.txt?x=13c39639280000 > > console output: https://syzkaller.appspot.com/x/log.txt?x=15c39639280000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=7d8067683055e3f5 > > dashboard link: https://syzkaller.appspot.com/bug?extid=0a684c061589dcc30e51 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14312791280000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12da8605280000 > > > > Reported-by: syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com > > Fixes: d82dcd9e21b7 ("reiserfs: Add security prefix to xattr name in reiserfs_security_write()") > > > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > Roberto, I think we need to resolve this somehow. As I mentioned > earlier, I don't believe this to be a fault in your patch, rather that > patch simply triggered a situation that had not been present before, > likely because the reiserfs code always failed when writing LSM > xattrs. Regardless, we still need to fix the deadlocks that sysbot > has been reporting. Hi Paul ok, I will try. Roberto > Has anyone dug into the reiserfs code to try and resolve the deadlock? > Considering the state of reiserfs, I'm guessing no one has, and I > can't blame them; I personally would have a hard time justifying > significant time spent on reiserfs at this point. Unless someone has > any better ideas, I'm wondering if we shouldn't just admit defeat with > reiserfs and LSM xattrs and disable/remove the reiserfs LSM xattr > support? Given the bug that Roberto was fixing with the patch in > question, it's unlikely this was working anyway. > > -- > paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Roberto Sassu <roberto.sassu@huaweicloud.com> To: Paul Moore <paul@paul-moore.com>, linux-security-module@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, roberto.sassu@huawei.com, syzkaller-bugs@googlegroups.com, syzbot <syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com> Subject: Re: [syzbot] [reiserfs?] INFO: task hung in flush_old_commits Date: Wed, 24 May 2023 17:50:03 +0200 [thread overview] Message-ID: <813148798c14a49cbdf0f500fbbbab154929e6ed.camel@huaweicloud.com> (raw) In-Reply-To: <CAHC9VhTM0a7jnhxpCyonepcfWbnG-OJbbLpjQi68gL2GVnKSRg@mail.gmail.com> On Wed, 2023-05-24 at 11:11 -0400, Paul Moore wrote: > On Wed, May 24, 2023 at 5:59 AM syzbot > <syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com> wrote: > > syzbot has bisected this issue to: > > > > commit d82dcd9e21b77d338dc4875f3d4111f0db314a7c > > Author: Roberto Sassu <roberto.sassu@huawei.com> > > Date: Fri Mar 31 12:32:18 2023 +0000 > > > > reiserfs: Add security prefix to xattr name in reiserfs_security_write() > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11c39639280000 > > start commit: 421ca22e3138 Merge tag 'nfs-for-6.4-2' of git://git.linux-.. > > git tree: upstream > > final oops: https://syzkaller.appspot.com/x/report.txt?x=13c39639280000 > > console output: https://syzkaller.appspot.com/x/log.txt?x=15c39639280000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=7d8067683055e3f5 > > dashboard link: https://syzkaller.appspot.com/bug?extid=0a684c061589dcc30e51 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14312791280000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12da8605280000 > > > > Reported-by: syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com > > Fixes: d82dcd9e21b7 ("reiserfs: Add security prefix to xattr name in reiserfs_security_write()") > > > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > Roberto, I think we need to resolve this somehow. As I mentioned > earlier, I don't believe this to be a fault in your patch, rather that > patch simply triggered a situation that had not been present before, > likely because the reiserfs code always failed when writing LSM > xattrs. Regardless, we still need to fix the deadlocks that sysbot > has been reporting. Hi Paul ok, I will try. Roberto > Has anyone dug into the reiserfs code to try and resolve the deadlock? > Considering the state of reiserfs, I'm guessing no one has, and I > can't blame them; I personally would have a hard time justifying > significant time spent on reiserfs at this point. Unless someone has > any better ideas, I'm wondering if we shouldn't just admit defeat with > reiserfs and LSM xattrs and disable/remove the reiserfs LSM xattr > support? Given the bug that Roberto was fixing with the patch in > question, it's unlikely this was working anyway. > > -- > paul-moore.com
next prev parent reply other threads:[~2023-05-24 15:50 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-23 3:33 [syzbot] [reiserfs?] INFO: task hung in flush_old_commits syzbot 2023-05-24 9:59 ` syzbot 2023-05-24 15:11 ` Paul Moore 2023-05-24 15:11 ` Paul Moore 2023-05-24 15:50 ` Roberto Sassu [this message] 2023-05-24 15:50 ` Roberto Sassu 2023-05-24 21:57 ` Paul Moore 2023-05-26 9:45 ` Roberto Sassu 2023-05-30 11:21 ` Jan Kara 2023-05-30 15:44 ` Roberto Sassu 2023-06-05 12:36 ` Jan Kara 2023-06-05 12:42 ` Roberto Sassu 2024-03-07 9:27 ` syzbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=813148798c14a49cbdf0f500fbbbab154929e6ed.camel@huaweicloud.com \ --to=roberto.sassu@huaweicloud.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=reiserfs-devel@vger.kernel.org \ --cc=roberto.sassu@huawei.com \ --cc=syzbot+0a684c061589dcc30e51@syzkaller.appspotmail.com \ --cc=syzkaller-bugs@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.