* [PATCH v3] drm/panfrost:fix the exception name always "UNKNOWN"
@ 2021-07-08 7:34 ` ChunyouTang
0 siblings, 0 replies; 3+ messages in thread
From: ChunyouTang @ 2021-07-08 7:34 UTC (permalink / raw)
To: steven.price
Cc: robh, tomeu.vizoso, alyssa.rosenzweig, airlied, daniel,
dri-devel, linux-kernel, ChunyouTang
From: ChunyouTang <tangchunyou@icubecorp.cn>
The exception_code in register is only 8 bits,So if
fault_status in panfrost_gpu_irq_handler() don't
(& 0xFF),it can't get correct exception reason.
and it's better to show all of the register value
to custom,so it's better fault_status don't (& 0xFF).
Signed-off-by: ChunyouTang <tangchunyou@icubecorp.cn>
---
drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index 1fffb6a0b24f..d2d287bbf4e7 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -33,7 +33,7 @@ static irqreturn_t panfrost_gpu_irq_handler(int irq, void *data)
address |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
- fault_status & 0xFF, panfrost_exception_name(pfdev, fault_status & 0xFF),
+ fault_status, panfrost_exception_name(pfdev, fault_status & 0xFF),
address);
if (state & GPU_IRQ_MULTIPLE_FAULT)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3] drm/panfrost:fix the exception name always "UNKNOWN"
@ 2021-07-08 7:34 ` ChunyouTang
0 siblings, 0 replies; 3+ messages in thread
From: ChunyouTang @ 2021-07-08 7:34 UTC (permalink / raw)
To: steven.price
Cc: tomeu.vizoso, airlied, linux-kernel, dri-devel,
alyssa.rosenzweig, ChunyouTang
From: ChunyouTang <tangchunyou@icubecorp.cn>
The exception_code in register is only 8 bits,So if
fault_status in panfrost_gpu_irq_handler() don't
(& 0xFF),it can't get correct exception reason.
and it's better to show all of the register value
to custom,so it's better fault_status don't (& 0xFF).
Signed-off-by: ChunyouTang <tangchunyou@icubecorp.cn>
---
drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index 1fffb6a0b24f..d2d287bbf4e7 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -33,7 +33,7 @@ static irqreturn_t panfrost_gpu_irq_handler(int irq, void *data)
address |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
- fault_status & 0xFF, panfrost_exception_name(pfdev, fault_status & 0xFF),
+ fault_status, panfrost_exception_name(pfdev, fault_status & 0xFF),
address);
if (state & GPU_IRQ_MULTIPLE_FAULT)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] drm/panfrost:fix the exception name always "UNKNOWN"
2021-07-08 7:34 ` ChunyouTang
(?)
@ 2021-07-12 10:02 ` Steven Price
-1 siblings, 0 replies; 3+ messages in thread
From: Steven Price @ 2021-07-12 10:02 UTC (permalink / raw)
To: ChunyouTang
Cc: tomeu.vizoso, airlied, linux-kernel, dri-devel,
alyssa.rosenzweig, ChunyouTang
On 08/07/2021 08:34, ChunyouTang wrote:
> From: ChunyouTang <tangchunyou@icubecorp.cn>
>
> The exception_code in register is only 8 bits,So if
> fault_status in panfrost_gpu_irq_handler() don't
> (& 0xFF),it can't get correct exception reason.
>
> and it's better to show all of the register value
> to custom,so it's better fault_status don't (& 0xFF).
>
> Signed-off-by: ChunyouTang <tangchunyou@icubecorp.cn>
Reviewed-by: Steven Price <steven.price@arm.com>
Boris's change has actually modified panfrost_exception_name() to no
longer take pfdev in drm-misc-next. However, I'll just fix this up when
I apply it.
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index 1fffb6a0b24f..d2d287bbf4e7 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -33,7 +33,7 @@ static irqreturn_t panfrost_gpu_irq_handler(int irq, void *data)
> address |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
>
> dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
> - fault_status & 0xFF, panfrost_exception_name(pfdev, fault_status & 0xFF),
> + fault_status, panfrost_exception_name(pfdev, fault_status & 0xFF),
> address);
>
> if (state & GPU_IRQ_MULTIPLE_FAULT)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-12 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 7:34 [PATCH v3] drm/panfrost:fix the exception name always "UNKNOWN" ChunyouTang
2021-07-08 7:34 ` ChunyouTang
2021-07-12 10:02 ` Steven Price
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.