All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Len Brown <len.brown@intel.com>
Subject: [PATCH 14/19] ACPI: suspend: restore BM_RLD on resume
Date: Sat, 16 May 2009 02:02:11 -0400	[thread overview]
Message-ID: <815ab0fd40579ad2aa42058298073503648762b9.1242453625.git.len.brown@intel.com> (raw)
In-Reply-To: <1242453736-20763-1-git-send-email-lenb@kernel.org>
In-Reply-To: <45cb50e646d1560eff01c5ad0f0df3c7fd6148dd.1242453625.git.len.brown@intel.com>

From: Len Brown <len.brown@intel.com>

In 2.6.29,
31878dd86b7df9a147f5e6cc6e07092b4308782b
"ACPI: remove BM_RLD access from idle entry path"
moved BM_RLD initialization to init-time from run time.

But we discovered that some BIOS do not restore BM_RLD
after suspend, causing device errors on C3 and C4
after resume.  So now the kernel restores BM_RLD.

http://bugzilla.kernel.org/show_bug.cgi?id=13032

Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/processor_idle.c |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index f7ca8c5..c1d59cf 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -202,15 +202,38 @@ static void acpi_state_timer_broadcast(struct acpi_processor *pr,
  * Suspend / resume control
  */
 static int acpi_idle_suspend;
+static u32 saved_bm_rld;
+
+static void acpi_idle_bm_rld_save(void)
+{
+	acpi_read_bit_register(ACPI_BITREG_BUS_MASTER_RLD, &saved_bm_rld);
+}
+static void acpi_idle_bm_rld_restore(void)
+{
+	u32 resumed_bm_rld;
+
+	acpi_read_bit_register(ACPI_BITREG_BUS_MASTER_RLD, &resumed_bm_rld);
+
+	if (resumed_bm_rld != saved_bm_rld)
+		acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_RLD, saved_bm_rld);
+}
 
 int acpi_processor_suspend(struct acpi_device * device, pm_message_t state)
 {
+	if (acpi_idle_suspend == 1)
+		return 0;
+
+	acpi_idle_bm_rld_save();
 	acpi_idle_suspend = 1;
 	return 0;
 }
 
 int acpi_processor_resume(struct acpi_device * device)
 {
+	if (acpi_idle_suspend == 0)
+		return 0;
+
+	acpi_idle_bm_rld_restore();
 	acpi_idle_suspend = 0;
 	return 0;
 }
-- 
1.6.0.6


  parent reply	other threads:[~2009-05-16  6:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  6:01 ACPI & driver patches for 2.6.30-rc5 Len Brown
2009-05-16  6:01 ` [PATCH 01/19] ACPI video: dmi check for broken _BQC on Acer Aspire 5720 Len Brown
2009-05-16  6:01   ` [PATCH 02/19] ACPICA: use acpi.* modparam namespace Len Brown
2009-05-16  6:02   ` [PATCH 03/19] ACPI: video: DMI workaround another broken Acer BIOS enabling display brightness Len Brown
2009-05-16  6:02   ` [PATCH 04/19] ACPI: power: update error message Len Brown
2009-05-16  6:02   ` [PATCH 05/19] ACPI: suspend: don't let device _PS3 failure prevent suspend Len Brown
2009-05-16  6:02   ` [PATCH 06/19] eeepc-laptop: fix wlan rfkill state change during init Len Brown
2009-05-16  6:02   ` [PATCH 07/19] eeepc-laptop: report brightness control events via the input layer Len Brown
2009-05-16  6:02   ` [PATCH 08/19] eeepc-laptop: Work around rfkill firmware bug Len Brown
2009-05-16  6:02   ` [PATCH 09/19] eeepc-laptop: support for super hybrid engine (SHE) Len Brown
2009-05-24  9:28     ` Alan Jenkins
2009-05-24 17:23       ` Corentin Chary
     [not found]         ` <4A198401.3040003@tuffmail.co.uk>
2009-05-25  8:12           ` Corentin Chary
2009-05-25  9:43             ` Alan Jenkins
2009-05-25  9:59               ` Corentin Chary
2009-05-25 10:07                 ` Alan Jenkins
2009-05-25 11:19                   ` Corentin Chary
2009-05-25 11:51                     ` Alan Jenkins
2009-05-26 10:12                       ` Corentin Chary
2009-05-26 10:15                         ` Alan Jenkins
2009-05-26 17:29                           ` Francesco Lattanzio
2009-05-26 17:43                             ` Alan Jenkins
2009-05-26 18:05                               ` Corentin Chary
2009-05-24 20:24       ` Corentin Chary
2009-05-16  6:02   ` [PATCH 10/19] asus-laptop: fix input keycode Len Brown
2009-05-16  6:02   ` [PATCH 11/19] eeepc-laptop: unregister_rfkill_notifier on failure Len Brown
2009-05-16  6:02   ` [PATCH 12/19] thermal: fix off-by-1 error in trip point trigger condition Len Brown
2009-05-16  6:02   ` [PATCH 13/19] ACPI: resume: re-enable SCI-enable workaround Len Brown
2009-05-16  6:02   ` Len Brown [this message]
2009-05-16  6:02   ` [PATCH 15/19] ACPI, i915: build fix Len Brown
2009-05-18  2:49     ` yakui_zhao
2009-05-16  6:02   ` [PATCH 16/19] ACPI processor: introduce module parameter processor.ignore_tpc Len Brown
2009-05-16  6:02   ` [PATCH 17/19] ACPI processor: reset the throttling state once it's invalid Len Brown
2009-05-16  6:02   ` [PATCH 18/19] ACPI: idle: fix init-time TSC check regression Len Brown
2009-05-16  6:02   ` [PATCH 19/19] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=815ab0fd40579ad2aa42058298073503648762b9.1242453625.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.